Comments (5)
juliuscc
commented on August 16, 2024
Hi! That looks like a bug to me. I think it's because of this line.
@s-hoff could you please submit a fix in a new PR?
from cz-conventional-changelog-for-jira.
s-hoff
commented on August 16, 2024
Done, I must have somehow missed that.
Maybe its worth also covering this in the tests? Moving that into a function which would be used to build the options in the existing tests would mean they all cover regressions from introducing new options.
from cz-conventional-changelog-for-jira.
juliuscc
commented on August 16, 2024
Maybe its worth also covering this in the tests? Moving that into a function which would be used to build the options in the existing tests would mean they all cover regressions from introducing new options.
Yeah that makes sense! I agree. I wonder how though 🤔 It's easy to risk just creating tests that work exactly the same as the business logic.
from cz-conventional-changelog-for-jira.
github-actions
commented on August 16, 2024
🎉 This issue has been resolved in version 7.5.1 🎉
The release is available on:
Your semantic-release bot 📦🚀
from cz-conventional-changelog-for-jira.
s-hoff
commented on August 16, 2024
Maybe its worth also covering this in the tests? Moving that into a function which would be used to build the options in the existing tests would mean they all cover regressions from introducing new options.
Yeah that makes sense! I agree. I wonder how though 🤔 It's easy to risk just creating tests that work exactly the same as the business logic.
Thats the Idea behind not making new test cases that go after the options in isolation but rather using the same function to get them for the existing engine tests as well. That way, anything here that influences the existing functionality will break them. In a way they would become more of an integration then unit test suite, which is fine given that they still run just as fast and should not loose much precision for funsing the causes.
If its just the options function I agree, it won’t help especially when adding new options.
from cz-conventional-changelog-for-jira.
Related Issues (20)
- Accept multiline comments in body HOT 4
- Add support for optional exclamation mark (!)
- Add scopeOptional config HOT 1
- Conflicts when repo is using vorpal HOT 1
- Support for multiple JIRA issue per commit HOT 9
- The Continous Deployment is broken HOT 2
- Description prompt doesn't appear to respect JIRA_LOCATION HOT 4
- This configuration doesn't support emojis? HOT 4
- It will not let me set valid jira issue with underscore in name HOT 1
- Use in non-interactive mode? HOT 3
- Merging from other branch clobbers commitizen comment HOT 1
- Enhancement request to support putting the Jira issue number both in the header (pre-type, pre-description, post-description) and in the footer (post-body) HOT 9
- using along side with commitlint, throws error when jiraLocation is set to pre-type HOT 3
- Post-body location seems not working HOT 14
- Allow skipping the type HOT 3
- Option to disable converting Jira issue prefix to uppercase
- commitlint support HOT 1
- Customization of jiraPrefix, # instead of - HOT 1
- Changelog commit link is wrong.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cz-conventional-changelog-for-jira.