Post-body location seems not working about cz-conventional-changelog-for-jira HOT 14 CLOSED

I've checked with package.json configuration and it works fine, so it's not working only with dynamic configuration.

from cz-conventional-changelog-for-jira.

If you would press y and actually commit, does the commit message also omit the Jira-issue? Or is it only in the preview?

from cz-conventional-changelog-for-jira.

The message also omit an issue

from cz-conventional-changelog-for-jira.

Has this worked before? Do you know if the bug came with a recent update?

from cz-conventional-changelog-for-jira.

hadn't tested previous versions

from cz-conventional-changelog-for-jira.

What version of @digitalroute/cz-conventional-changelog-for-jira are you using? We just pushed out an update like two days ago that could be related.

from cz-conventional-changelog-for-jira.

I use "@digitalroute/cz-conventional-changelog-for-jira": "^7.4.1" - the newest one

from cz-conventional-changelog-for-jira.

Could you try exactly version 7.4.0? I suspect there might be a bug with 7.4.1

from cz-conventional-changelog-for-jira.

I've checked - the same situation

from cz-conventional-changelog-for-jira.

That is very strange to me. Would you be willing to investigate the bug and identify what could be wrong?

The jira issue should be added here: https://github.com/digitalroute/cz-conventional-changelog-for-jira/blob/master/engine.js#L267-L274

from cz-conventional-changelog-for-jira.

I think I know where the problem is. I assumed, according to docs, that custom function is going to override the defaults and it's not. I've noticed that there is no jiraMode in my config options so that's why footer had being omitted.

from cz-conventional-changelog-for-jira.

something like:

var engine = require('./engine');
var defaults = require('./defaults');

module.exports = function(overridenOptions) {
  return engine({ ...defaults, ...overridenOptions });
};

in configurable file could help

from cz-conventional-changelog-for-jira.

Aha yeah that makes sense! I agree with your perception that configurable meant that it would be an override over the defaults. Not that you needed to specify every single thing. That actually means that additions of new options are breaking changes sometimes.

Could you submit a PR with your suggested change. I think it looks perfect 👍

from cz-conventional-changelog-for-jira.

🎉 This issue has been resolved in version 7.4.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

from cz-conventional-changelog-for-jira.