Giter Club home page Giter Club logo

mdbook-epub's People

Contributors

blandger avatar dieterplex avatar glatavento avatar michael-f-bryan avatar rams3s avatar simsilver avatar

Stargazers

 avatar  avatar

Watchers

 avatar

Forkers

theowenyoung

mdbook-epub's Issues

mdbook 0.4.15 build fail with rustc 1.64, but works on rustc 1.62

According to rust-lang/rust#99591
Unless we upgrade dependencies or use previous rustc, it would not compile:

> cargo test
   Compiling mdbook v0.4.15
error[E0597]: `local_ctx` does not live long enough
   --> /home/dieter/.cargo/registry/src/github.com-1ecc6299db9ec823/mdbook-0.4.15/src/renderer/html_handlebars/helpers/navigation.rs:154:25
    |
154 |             t.render(r, &local_ctx, &mut local_rc, out)
    |                         ^^^^^^^^^^ borrowed value does not live long enough
155 |         })?;
    |         -
    |         |
    |         `local_ctx` dropped here while still borrowed
    |         borrow might be used here, when `local_rc` is dropped and runs the destructor for type `handlebars::RenderContext<'_, '_>`
    |
    = note: values in a scope are dropped in the opposite order they are defined

For more information about this error, try `rustc --explain E0597`.
error: could not compile `mdbook` due to previous error
warning: build failed, waiting for other jobs to finish...
> rustc -V
rustc 1.64.0 (a55dd71d5 2022-09-19)

For 0.4.15 a workaround may still use 1.62 instead

rustup toolchain intall 1.62
rustup default 1.62

Merge fix-local-md-link to main branch

Hi, thanks for your great work on this project! I really like the two features you submitted. fetching remote images and supporting the local MD link, I tried to merge two branches but there are too many conflicts, so I have no confidence in merging it, would you like to merge these two branches?

TRPL epub compatibility

With epubcheck -f trpl.epub, there are a few fatals:

FATAL(RSC-016): The Rust Programming Language.epub/OEBPS/nav.xhtml(136,91): Fatal Error while parsing file: The element type "T" must be terminated by the matching end-tag "</T>".
FATAL(RSC-016): The Rust Programming Language.epub/OEBPS/ch02-00-guessing-game-tutorial.html(37,37): Fatal Error while parsing file: The string "--" is not permitted within comments.
FATAL(RSC-016): The Rust Programming Language.epub/OEBPS/ch11-01-writing-tests.html(51,27): Fatal Error while parsing file: The string "--" is not permitted within comments.
FATAL(RSC-016): The Rust Programming Language.epub/OEBPS/ch12-05-working-with-environment-variables.html(140,27): Fatal Error while parsing file: The string "--" is not permitted within comments.
FATAL(RSC-016): The Rust Programming Language.epub/OEBPS/ch14-01-release-profiles.html(23,15): Fatal Error while parsing file: The string "--" is not permitted within comments.
FATAL(RSC-016): The Rust Programming Language.epub/OEBPS/ch14-03-cargo-workspaces.html(81,21): Fatal Error while parsing file: The string "--" is not permitted within comments.

Check finished with errors
Messages: 6 fatals

At nav.xhtml L136, they are unescaped chars:

 <li><a href="ch15-01-box.html">15.1. Using Box<T> to Point to Data on the Heap</a></li>

At ch02-00-guessing-game-tutorial.html L37 context, "--" appears in the comment that is not visible to reader:

<p>Look at the generated <em>Cargo.toml</em> file:</p>
<!-- manual-regeneration
cd listings/ch02-guessing-game-tutorial
rm -rf no-listing-01-cargo-new
cargo new no-listing-01-cargo-new --name guessing_game
cd no-listing-01-cargo-new
cargo run
-->

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.