didierfranc / redux-react-starter Goto Github PK

node : v6.10.0
npm : 3.10.10

λ npm start

[email protected] start C:\Projets\React\redux-react-starter
tsc && concurrently "npm run tsc:w" "npm run web" "npm run rest"

typings/modules/react-dom/index.d.ts(165,11): error TS2559: Type 'Component<P, S>' has no properties in common with type 'ComponentLifecycle<P, S>'.
typings/modules/react/index.d.ts(165,11): error TS2559: Type 'Component<P, S>' has no properties in common with type 'ComponentLifecycle<P, S>'.

npm ERR! Windows_NT 10.0.10240
npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" "start"
npm ERR! node v6.10.0
npm ERR! npm v3.10.10
npm ERR! code ELIFECYCLE
npm ERR! [email protected] start: tsc && concurrently "npm run tsc:w" "npm run web" "npm run rest"
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the [email protected] start script 'tsc && concurrently "npm run tsc:w" "npm run web" "npm run rest" '.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the redux-react-starter package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! tsc && concurrently "npm run tsc:w" "npm run web" "npm run rest"
npm ERR! You can get information on how to open an issue for this project with:
npm ERR! npm bugs redux-react-starter
npm ERR! Or if that isn't available, you can get their info via:
npm ERR! npm owner ls redux-react-starter
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR! C:\Projets\React\redux-react-starter\npm-debug.log

Results

Some things are missing to make lighthouse report perfect, especially Manifest stuffs

Any PR fixing that part is welcome 🎆

Version ⤴

• webpack 2
• react-redux 5
• react-router 4

Add

• jest
• styled-components examples

Description

This error appears even if ConnectAdvanced is not used

Reproduce

You can reproduce this bug by running preact branch f68626a

WIP

Everything is fine when switching to react-redux 4.x
Not so much lib diff between react-redux 5.x and 4.x, except lodash-es 🤔

I guess it is a general question about best practices:

There's a reference to a backend API server in urls.js. Where is the code for this server?

Do you think that this starter kit should also show-case handling of booth backend and front-end code in the same repo? Particularly in production, because of the payment model of services like Heroku.

Hi,
thanks for this starter I think it is great.
I see that you are using styled-component which is great.
My problem is that I have no talent with css so I try to use libraries like bootstrap.

The only problem is that I would like to still use css-module and only bundle the css that I actually use in my app. Also doing chuncking on the css.
I do not think this is possible with react-bootstrap. I think you include bootstrap globaly and your component className attr will be plain string.

I guess there is many way to do it I just can not find an efficient one.
I guess my question is:
How to integrate bootstrap to your starter in an efficient manner (because I am terrible with css)?