didero / diderobot Goto Github PK

Instead of having each module handle incoming character encodings properly, make sure that before sending anything to the modules, it's either proper Unicode or proper (utf-8?) strings. Probably easiest through the IrcMessage class, since all incoming messages to modules are put in an instance of that.
Then the problem becomes whether to remove unparsable characters, or to drop the entire message.

Obviously modules using APIs will still have to check that on an individual basis.

Unify outgoing messages too, which should be strings and not Unicode, otherwise Twisted gets angry.

Instead of a separate 'hideInCommandList' variable, check if the user using !help or something is an admin, and if the current module is admin-only.
If the user isn't and the module is, don't list it.
If the user IS an admin, either show all the modules, or add a separate !helpadmin trigger to show the admin-only commands too. Or maybe only show all the admin commands when !help is called in private message, though the distinction may be a bit non-obvious.