dianaayoub / hyf-javascript1 Goto Github PK

well done!

• Try to use js formatter (beautifier) because sometimes your code is so compressed, and I saw some functions in one line and so It will be unreadable.
• By number 11 try to re-solve it (last lecture we got the answers)
• One more thing use simicolumn after 'use strict'
  cheers!

Hi Diana, here is my feedback on your homework.

• You seem to be missing an .eslintrc.json file in the root folder of your repo (i.e. folder hyf-javascript1). Please check the VSCode Tips on why and how to create this file.

step2.js

• Did you install the Spell Checker extension in VSCode? There is a spelling error in your string which is flagged by the spelling checker in my VSCode: 'cotations' should be 'quotations' (or actually, the word 'quote'). (And the word 'use' is duplicated.) Check the VSCode Tips if you haven't installed the Spell Checker yet.

step3.js

• It is standard practice to insert a space just before and after an operator such as =, like in x = 5;. VSCode will do this automatically for you as you type if you apply some settings as we did in class. Can you please check the VSCode Tips and verify the settings for "editor.formatOnType" and ""editor.formatOnPaste"?

step4.js

• Same formatting issue here. By the way, what does 'dndn' mean?

step5.js

• It is a standard practice to format an if statement using multiple lines, like this:

if (a > z) {
  y = a;
}
else {
  y = z;
}

• Note also the spaces around the operators.
• There is also another way of finding the highest of two values. Google for 'mdn math' and see what you can find.

step6.js

• Again, pay attention to formatting.
• Be consistent in your use of quotes. Either use single ' quotes or double " quotes, but make a choice and then stick to it.

step7.js

• What is the purpose of these two lines?

let x = 9;
let y = 'Hello';

step8.js

• Mind the formatting of the if statements.
• Although it is technically permitted, it is not recommended to put more than one statement on a single line.

Change:

console.log(typeof x);console.log("the value of x will be:'number'");

to:

console.log(typeof x);
console.log("the value of x will be:'number'");

• Make sure you get your punctuation right in your text strings. E.g., a colon : should be followed by a space.
• If you console.log SAME TYPE then I would also expect DIFFERENT TYPE: use upper- and lowercase consistently.

step9.js

• Add a space after a colon :.

step10.js

• Formatting.
• Consistent use of quotes.

As you can see my comments were all about formatting. Functionality-wise your code is 100% correct. So pay attention to formatting, but for the rest: well done!