diana-hep / root4j Goto Github PK

https://github.com/diana-hep/root4j/blob/master/pom.xml#L69

By not providing a scope, the dependencies are set to the compile scope by default. This means anyone that includes root4j in their project (directly or not) is going to get hadoop-client 2.7.3 & hadoop-hdfs 2.7.3 and all their transitive dependencies. For infrastructure libraries (like), this is not normally the intention, as most runtime environment will provide such JARs. See Maven docs for more info: https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Dependency_Scope

Hello,

This is very interesting project. I was trying to compile and run, but unfortunately I could not open a root file with histograms with RootFileReader.java. Does it support histograms? Here are the errors:

 [java] Exception in thread "main" java.lang.NullPointerException
 [java] 	at java.util.Properties$LineReader.readLine(Properties.java:434)
 [java] 	at java.util.Properties.load0(Properties.java:353)
 [java] 	at java.util.Properties.load(Properties.java:341)
 [java] 	at org.dianahep.root4j.core.DefaultClassFactory.<init>(DefaultClassFactory.java:39)
 [java] 	at org.dianahep.root4j.RootFileReader.init(RootFileReader.java:217)
 [java] 	at org.dianahep.root4j.RootFileReader.<init>(RootFileReader.java:183)

For some operations, root4j uses the same Hadoop Configuration instance as the one found in Spark, but in other cases it creates a new Hadoop Configuration, so it loses the configuration values set by Spark.

Here's an example of when it creates a new instance:
https://github.com/diana-hep/root4j/blob/master/src/main/java/org/dianahep/root4j/RootFileReader.java#L179

This issue was originally reported as a bug against the stocator program used by IBM Data Science Experience to read files Swift ("Object Storage service"). See: CODAIT/stocator#122