Giter Club home page Giter Club logo

ember-deactivate-issue's Introduction

Reproduction of Deactivate issue

Kind of hard to write a falling test for this as it revolves around the way in which the container is destroyed.

Expected behavior

I would expect the deactivate hook to be called on all routes after completing a test, regardless of where an error has been handled.

Actual behavior

After a test has completed with an error, the deactivate hook is called on all routes above where the error state was handled.

To see issue:

Deactivate not called if error handled above route:

  • Checkout master branch
  • Go to /tests
  • Open console
  • Observe only an error in console, as error was handled above first-route

Deactivate called if error handled below route:

  • Checkout with-error branch
  • Go to /tests
  • Open console
  • Observe 'first-route deactivate called' logged in console, as error was handled in child route of first-route

ember-deactivate-issue's People

Contributors

ember-tomster avatar

Watchers

James Cloos avatar

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.