Giter Club home page Giter Club logo

Comments (2)

devsnd avatar devsnd commented on June 4, 2024

Hi Thomas,

Thanks for your suggestion. Those changes can easily be made, especially for:

info.audio_offset
info.bitrate
info.size
info.comment
info.sample_rate

But:

info.duration

is currently called length. I guess duration is less ambiguous. Maybe we should change the API as long as the library is young. (or keep both?)

info.audio_size

This is essentially info.size - info.audio_offset right?

info.genre

I don't really want to implement this, because this is only additional bloat, see the list of genres in in ID3 tags. But try to convince me if it's important to you 🐧

from tinytag.

rizumu avatar rizumu commented on June 4, 2024

I didn't look into the genres, that does seem silly and I doubt many would ever use it, but if the goal was to be complete to spec than maybe somebody would want it. Better to wait until someone specifically asks.

Since you have length already I don't see a good reason to add or change to duration unless trying to match an official tag spec. Duration is more about time, so I could see that with adding the size attributes, it is slightly more clear what duration is compared to length.

from tinytag.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.