utf-8 error about tinytag HOT 5 CLOSED

Hello @ktkchn,

thanks for reporting! Can you please upload the mp4 file somewhere so i can reproduce the bug? thanks!

from tinytag.

hello @devsnd

I have uploaded the m4a file here
https://drive.google.com/file/d/0B4rXGVsThTq6UjBEcjZCX29aWFU/view?usp=sharing

thanks

complete error traceback:

Traceback (most recent call last):
File "makedb.py", line 39, in
tag=TinyTag.get(fp)
File "/usr/lib/python2.6/site-packages/tinytag/tinytag.py", line 99, in get
tag.load(tags=tags, duration=duration, image=image)
File "/usr/lib/python2.6/site-packages/tinytag/tinytag.py", line 116, in load
self._parse_tag(self._filehandler)
File "/usr/lib/python2.6/site-packages/tinytag/tinytag.py", line 307, in _parse_tag
return self._traverse_atoms(fh, path=self.META_DATA_TREE)
File "/usr/lib/python2.6/site-packages/tinytag/tinytag.py", line 331, in _traverse_atoms
curr_path=curr_path + [atom_type])
File "/usr/lib/python2.6/site-packages/tinytag/tinytag.py", line 331, in _traverse_atoms
curr_path=curr_path + [atom_type])
File "/usr/lib/python2.6/site-packages/tinytag/tinytag.py", line 331, in _traverse_atoms
curr_path=curr_path + [atom_type])
File "/usr/lib/python2.6/site-packages/tinytag/tinytag.py", line 331, in _traverse_atoms
curr_path=curr_path + [atom_type])
File "/usr/lib/python2.6/site-packages/tinytag/tinytag.py", line 331, in _traverse_atoms
curr_path=curr_path + [atom_type])
File "/usr/lib/python2.6/site-packages/tinytag/tinytag.py", line 334, in _traverse_atoms
for fieldname, value in sub_path(fh.read(atom_size)).items():
File "/usr/lib/python2.6/site-packages/tinytag/tinytag.py", line 211, in parse_data_atom
return {fieldname: conversion(data_atom[8:])}
File "/usr/lib/python2.6/site-packages/tinytag/tinytag.py", line 180, in
1: lambda x: codecs.decode(x, 'utf-8'), # UTF-8
File "/usr/lib64/python2.6/encodings/utf_8.py", line 16, in decode
return codecs.utf_8_decode(input, errors, True)
UnicodeDecodeError: 'utf8' codec can't decode byte 0x92 in position 34: invalid start byte

from tinytag.

Hey @ktkchn,

I have reproduced the bug and also found out why TinyTag crashes; The file you provided is malformed and does not adhere to the spec. Apples specification for MP4 allows strings only to be encoded using UTF-8. The file you provided seems to use ISO-8859-1 (also called latin1). Since there is no way to find out which encoding a byte-sequence was encoded in, I cannot just decode your file in a different manner.

I have added a patch that will replace all characters that cannot be decoded with �, so that TinyTag will not crash anymore.

from tinytag.

I have released a new version 0.15.2 that includes this fix.

from tinytag.

thank you!

from tinytag.