Giter Club home page Giter Club logo

Comments (5)

devsnd avatar devsnd commented on May 24, 2024

Hi ibeex,
Thanks for your report!

I have got an idea why it doesn't work, so if you've got the time, please try to change line 230 from

return self._unpad(codecs.decode(b[3:], 'UTF-16'))

to

return codecs.decode(self._unpad(b[3:]), 'UTF-16')

Changing the code as shown above will first remove the zero-termination byte and then decode the string, instead of doing it the other way around.

Since UTF16 always expects get 2 bytes per character as input, but the byte string may be zero-terminated, making giving the bytestring an odd length, so there's a byte "missing", leading to truncated data.

from tinytag.

ibeex avatar ibeex commented on May 24, 2024

Still the same, I am not sure that this mp3 is actually utf-16, mediainfo can read tags but all python libs can't read artist, album tags.
here is new error

/Users/ib/Documents/Python/tst/tinytag/tinytag/__init__.py in _decode_string(self, b)
    228             return self._unpad(codecs.decode(b[1:], 'ISO-8859-1'))
    229         if b[0:3] == b'\x01\xff\xfe':
--> 230             return codecs.decode(self._unpad(b[3:]), 'UTF-16')
    231         return self._unpad(codecs.decode(b, 'ISO-8859-1'))
    232

/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/lib/python2.7/encodings/utf_16.pyc in decode(input, errors)
     14
     15 def decode(input, errors='strict'):
---> 16     return codecs.utf_16_decode(input, errors, True)
     17
     18 class IncrementalEncoder(codecs.IncrementalEncoder):

UnicodeDecodeError: 'utf16' codec can't decode byte 0x4c in position 0: truncated data

from tinytag.

devsnd avatar devsnd commented on May 24, 2024

Ok, could you please upload the MP3 somewhere, so I can try to find out the problem on my own?

from tinytag.

ibeex avatar ibeex commented on May 24, 2024

here it is https://dl.dropboxusercontent.com/u/373323/07%20Lemonworld.mp3

from tinytag.

devsnd avatar devsnd commented on May 24, 2024

Hey @ibeex, I have fixed the problem and added the first few bytes of the mp3 you send to the test suite. Please try it out again now, and feel free to reopen this issue, or open another one, if you find something :)

from tinytag.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.