Comments (4)
im no expert, but the problem here is that the content array has no fixed length and changes between titles (as some titles have more content files than others) and this is C code, not C++ (so no access to std::vector, which in turn would increase code size too).
the only thing i can think of is to make this a pointer?
maybe @WinterMute knows something?
from libogc.
You can't do this with a pointer. A flexible array is effectively syntactic sugar for the memory past the end of the struct. Generally I don't recommend using them since their memory semantics are, well, weird (which is probably why C++ disallows them), but it's impossible to solve this in a way that placates both the C++ compiler and preserves backwards compatibility. You should probably just turn off -Wpedantic
, to be honest, since at this point I think changing that API is unlikely to happen.
from libogc.
ye, thats fair. changing the API would sadly break to much homebrew out there. and if a pointer to replace the array won't work, then i also think turning off the warning is best.
from libogc.
Alright, I guess I'll just use pragmas to disable it temporarily for that include, even though it's a pain, that's still a better option than breaking backwards compatibility or just disabling the warning altogether, potentially breaking some of my code...
from libogc.
Related Issues (20)
- net_getsockopt, net_getsockname, and struct pollfd not implemented HOT 4
- WPAD: Unable to read any Motion Plus data from the Wiimote HOT 3
- Card_Create() fails when game share filename prefixes HOT 2
- Wii MotionPlus being an expansion lead to issues with other expansions. HOT 1
- Ubuntu 21.04 Error: unknown type name 'BOOL' 13 | BOOL MP3Player_IsPlaying(void); HOT 2
- ogc_card_writepage() incorrectly calculates offset after block 1024 HOT 2
- GX_SetDispCopyDst takes a `ht` argument, however it is not used in the function. HOT 4
- Get track location in MP3Player? HOT 2
- DSP task code incorrectly sets flags instead of state in one case HOT 1
- Debug spins after hitting break point and trying to continue HOT 2
- `AESND_Reset` hangs when called HOT 5
- SYSCONF's IPL.CB should be signed, but leads to other issues HOT 15
- [WiiU / vWii] libogc may mistakenly mount WiiU's USB storage drive when multiple USB drives are connected HOT 8
- gctypes.h:9:10: fatal error: 'stdbool.h' file not found HOT 1
- GameCube: printf() does not work properly HOT 7
- PAD_ScanPads() reports GameCube controller continuously connecting and disconnecting HOT 5
- Uncalibrated accelerometer data from the Nunchuck
- Stereo audio output plays with swapped channels HOT 8
- asndlib 2.6.0 has no sound on dolphin (DSP HLE) HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libogc.