devinsays / edd-theme-updater Goto Github PK

Do you think it's too heavy to get theme version using wp_get_theme function?

https://github.com/samikeijonen/mina-olen/blob/master/admin/functions-admin.php#L12

I always forgot to update theme version if it's in several places.

Ideally the developer should just need to put in the custom settings, and everything else is abstracted.

This end, I'd like to move all the admin page functions into a separate file. I'd also like to wrap all of these in a class and make all the strings filterable.

In commit 8698735 there is hardcoded url like this:

/checkout/?edd_license_key=' . $license_key . '&download_id=' . $this->download_id

Is checkout page always /checkout? It's the default page slug but that can be changed, right?

Could we use function edd_get_checkout_uri instead?

https://easydigitaldownloads.com/codex/function-edd_get_checkout_uri.html

Note that I haven't even checked the complete code so I can be terrible wrong here.

There is variable as a first parameter of a gettext function. <?php esc_attr_e( $strings['deactivate-license'] ); ?>.

No big deal but should we just echo the license string and the variable can be inside esc_attr. Something like this:

<?php echo esc_attr( $strings['deactivate-license'] ); ?>

Software licensing have now lifetime license. Should we add the check like mentioned here?

https://easydigitaldownloads.com/blog/software-licensing-3-2-5-released-with-lifetime-license-support/

One thing that comes to my mind is that we could add renew license link in admin also.

http://churchthemes.com/2014/06/05/license-management-improved/

Do you wanna hop in @stevengliebe?

When I enter license key and save, I still need to click Activate License button after that and then license is activated.

Are you having the same "issue"?

From @samikeijonen:

https://gist.github.com/samikeijonen/be0ead5baa143524c171#file-theme-updater-php-L129

I've never been able to get updates in multisite. Not for my own themes or any EDD add-ons.

But this one worked on multisite also in my localhost test! I hope it'll work on live site also. That's a huge bonus in my eyes.

hi, how can i use this for a child theme?

if i load in the style.css the child theme, the tehem crash (will be blank)
have you a idea to fix this?

`<?php
/**

• This is just a demonstration of how theme licensing works with
• Easy Digital Downloads.
• @Package EDD Sample Theme
  */

/**

• Load theme updater functions.
• Action is used so that child themes can easily disable.
  */

function prefix_theme_updater() {
require( get_template_directory() . '/updater/theme-updater.php' );
}
add_action( 'after_setup_theme', 'prefix_theme_updater' );

function child_theme_styles() {
wp_enqueue_style( 'parent-style', get_template_directory_uri() . '/style.css' );
wp_enqueue_style( 'child-theme-css', get_stylesheet_directory_uri() .'/style.css' , array('parent-style'));

}
add_action( 'wp_enqueue_scripts', 'child_theme_styles' );`

I think it would be helpful to have all the strings defined in one place. This makes them easier to edit or filter. Started work on this with: 01304d8

For basic user adding the theme license can be a challenge. Should we add admin notice if license have not been set?

Something like "Click here to enter your license key for getting auto updates".

There could also be admin notice when license have expired.