devinargenta / photokeeper Goto Github PK

The app is looking great so far!! I think there are a couple things technically we can work on, but I also think we should start building out the features we originally talked about!

the main technical thing that we should implement first is:

• use custom UICollectionViewCell. There is minor rote setup that needs to be done to register the cell with the collection view, but it'll simplify things. You basically then need to think of the cell as a generic view that reconfigures itself when a new PhotoObject is dropped into it.

Then I think we should implement some UI that appears at app open that gives you a prompt for a photo subject. For now it can always be the same one, or a random one from a list of prompts. You have some experience thinking this one through, but maybe something like:

1. app open
2. subject prompt screen

• textual prompt
• image background?
• camera button
• library button (to see old/saved photos)
• shuffle button?
• maybe instead of a nav bar navigation you move to a tab bar navigation a la instagram?

PhotoObject will then need to save data relating to which prompt it was taken for

---

hit me up with any questions!!

https://github.com/devinargenta/photokeeper/blob/master/PhotoKeeperTests/PhotoKeeperTests.swift

??? just in general...

https://github.com/devinargenta/photokeeper/blob/master/PhotoKeeper/CameraViewController.swift#L152

saw this somewhere on line, decided to move all my logic vs UI functions into here for cleanliness.... bad??

lots of UI setup in here... seems bad / clunky?
is there a better way to handle all this?

https://github.com/devinargenta/photokeeper/blob/master/PhotoKeeper/CameraViewController.swift#L79

https://github.com/devinargenta/photokeeper/blob/master/PhotoKeeper/CameraViewController.swift#L105

https://github.com/devinargenta/photokeeper/blob/master/PhotoKeeper/ImageStore.swift

is this good? or bad?
am i useing this stuff right?
singletons are bad?

some of this felt good soeme of this felt terrible;