development-bizeta-mestre / nsis-extension Goto Github PK

Hello,

Since the version of this extension was automatically updated to 1.1.8 today, attempting to run any job fails with status similar to the following job output:

Starting: Include Nsis
==============================================================================
Task         : Nsis
Description  : Run Nsis
Version      : 1.1.8
Author       : bizeta
Help         : Run Nsis [More Information](https://github.com/dev-maxima/nsis-extension)
==============================================================================
##[error]File not found: 'C:\a\_work\_tasks\nsis_a459f79f-b932-4ebc-ae19-060fd656b294\1.1.8\ps_modules\VstsTaskSdk\VstsTaskSdk.psd1'
Finishing: Include Nsis

Update the TaskLib so the warning disappears

If I use the unicode true in my script, I can't get the support of plugins.

I recently started to get this sort of warnings when running your tasks:

##[warning]Task 'nsis' (1.1.2) is using deprecated task execution handler. The task should use the supported task-lib: https://aka.ms/tasklib
Could you please have a look? Or if you prefer, I can give it a try and submit a pull request.

FYI, here are the kind of changes that are required: https://github.com/cake-build/cake-vso/pull/49/files

Thanks.

Hello,

When attempting to use this task in 'justInclude' mode, I get an error when I don't provide the 'arguments' parameter. This is superfluous for justInclude, because makensis won't even be invoked by the task.

Here's the input:

- task: bizeta.nsis-task.796c90b1-9f8c-424a-b03b-b789bb5945d3.nsis@1
  displayName: 'Include Nsis'
  inputs:
    justInclude: yes
    includeMorePlugins: yes

And the resulting task output:

Starting: Include Nsis
==============================================================================
Task         : Nsis
Description  : Run Nsis
Version      : 1.1.7
Author       : bizeta
Help         : Run Nsis [More Information](https://github.com/dev-maxima/nsis-extension)
==============================================================================
##[error]Required: 'arguments' input
Finishing: Include Nsis

Running bizeta.nsis-task-2.0.1.vsix results in a clear error that says it's not compatible with the latest version of Visual Studio:

9/30/2022 1:56:47 PM - Found installed product - Visual Studio Community 2022
9/30/2022 1:56:47 PM - VSIXInstaller.NoApplicableSKUsException: This extension is not installable on any currently installed products.
   at VSIXInstaller.ExtensionService.GetInstallableDataImpl(IInstallableExtension extension, String extensionPackParentName, Boolean isRepairSupported, IStateData stateData, IEnumerable`1& skuData)
   at VSIXInstaller.ExtensionService.GetInstallableData(String vsixPath, String extensionPackParentName, Boolean isRepairSupported, IStateData stateData, IEnumerable`1& skuData)
   at VSIXInstaller.ExtensionPackService.IsExtensionPack(IStateData stateData, Boolean isRepairSupported)
   at VSIXInstaller.ExtensionPackService.ExpandExtensionPackToInstall(IStateData stateData, Boolean isRepairSupported)
   at VSIXInstaller.App.Initialize(Boolean isRepairSupported)
   at VSIXInstaller.App.Initialize()
   at System.Threading.Tasks.Task`1.InnerInvoke()
   at System.Threading.Tasks.Task.Execute()

Hi, thanks for the extension.
As know NSISdoes not support installer larger than 2G, there is NSISBI can you add it?

Hi.

The arguments are not being passed to makensis, as you can see below my arguments are '/Dversao=2.0.20.0'.
Passing this arguments to makensis will change de output file and this is not happening.

In my yaml

- task: nsis@3
  inputs:
    arguments: '/Dversao=$(versaoNova)'
    scriptFile: '$(arquivoNSIS)'
    justInclude: 'no'
    includeMorePlugins: 'yes'    
    includeCustomPlugins: 'no'

If you look at line that starts with "2022-05-12T19:33:52.7098740Z" you can see that there is no /D argument.
Just an observation: I'm using powershell and I had trouble to realize that /D has to come before the file...

Am I doing something wrong?
Thank you in advance.

2022-05-12T19:33:51.5919234Z ##[section]Starting: nsis
2022-05-12T19:33:51.6035491Z ==============================================================================
2022-05-12T19:33:51.6035730Z Task : Nsis
2022-05-12T19:33:51.6035871Z Description : Run Nsis
2022-05-12T19:33:51.6036003Z Version : 3.0.0
2022-05-12T19:33:51.6036147Z Author : bizeta
2022-05-12T19:33:51.6036397Z Help : Run Nsis More Information
2022-05-12T19:33:51.6036694Z ==============================================================================
2022-05-12T19:33:52.3143192Z scriptFile = D:\a\1\s\Poliview.Instalador.AprovApi\NSIS\InstaladorAprovApi.nsi
2022-05-12T19:33:52.3150781Z justInclude = no
2022-05-12T19:33:52.3158818Z arguments = /Dversao=2.0.20.0
2022-05-12T19:33:52.3165539Z includeMorePlugins = yes
2022-05-12T19:33:52.3173115Z includeCustomPluginsPath = D:\a\1\s
2022-05-12T19:33:52.3176095Z
2022-05-12T19:33:52.5826600Z Time taken (Unzip): 0 second(s)
2022-05-12T19:33:52.5831378Z
2022-05-12T19:33:52.5914854Z [includeMorePlugins] dump 'D:\a_tasks\nsis_a459f79f-b932-4ebc-ae19-060fd656b294\3.0.0\nsis\nsis-3.08\plugins\x86-ansi':
2022-05-12T19:33:52.6135461Z
2022-05-12T19:33:52.6136433Z
2022-05-12T19:33:52.6139484Z Directory: D:\a_tasks\nsis_a459f79f-b932-4ebc-ae19-060fd656b294\3.0.0\nsis\nsis-3.08\plugins\x86-ansi
2022-05-12T19:33:52.6139845Z
2022-05-12T19:33:52.6139924Z
2022-05-12T19:33:52.6150054Z Mode LastWriteTime Length Name
2022-05-12T19:33:52.6153121Z ---- ------------- ------ ----
2022-05-12T19:33:52.6162998Z -a---- 5/12/2022 1:20 PM 11264 AccessControl.dll
2022-05-12T19:33:52.6179502Z -a---- 9/25/2021 4:50 PM 5632 advsplash.dll
2022-05-12T19:33:52.6194618Z -a---- 9/25/2021 4:50 PM 4096 Banner.dll
2022-05-12T19:33:52.6214866Z -a---- 9/25/2021 4:50 PM 7680 BgImage.dll
2022-05-12T19:33:52.6232689Z -a---- 9/25/2021 4:50 PM 3584 Dialer.dll
2022-05-12T19:33:52.6247080Z -a---- 5/12/2022 1:20 PM 87040 DotNetChecker.dll
2022-05-12T19:33:52.6262104Z -a---- 5/12/2022 1:20 PM 3072 DumpLog.dll
2022-05-12T19:33:52.6276471Z -a---- 5/12/2022 1:20 PM 3584 FindProcDLL.dll
2022-05-12T19:33:52.6291006Z -a---- 9/25/2021 4:50 PM 14848 InstallOptions.dll
2022-05-12T19:33:52.6305492Z -a---- 5/12/2022 1:20 PM 4096 KillProcDLL.dll
2022-05-12T19:33:52.6320294Z -a---- 9/25/2021 4:50 PM 5632 LangDLL.dll
2022-05-12T19:33:52.6334747Z -a---- 9/25/2021 4:50 PM 67584 Math.dll
2022-05-12T19:33:52.6349286Z -a---- 9/25/2021 4:50 PM 9728 nsDialogs.dll
2022-05-12T19:33:52.6363867Z -a---- 9/25/2021 4:50 PM 6656 nsExec.dll
2022-05-12T19:33:52.6378409Z -a---- 9/25/2021 4:51 PM 14848 nsisdl.dll
2022-05-12T19:33:52.6392895Z -a---- 5/12/2022 1:20 PM 7680 services.dll
2022-05-12T19:33:52.6407411Z -a---- 5/12/2022 1:20 PM 8192 Services2.dll
2022-05-12T19:33:52.6421830Z -a---- 5/12/2022 1:20 PM 62976 SimpleSC.dll
2022-05-12T19:33:52.6436203Z -a---- 9/25/2021 4:51 PM 4096 splash.dll
2022-05-12T19:33:52.6451723Z -a---- 9/25/2021 4:51 PM 7680 StartMenu.dll
2022-05-12T19:33:52.6467247Z -a---- 9/25/2021 4:51 PM 12288 System.dll
2022-05-12T19:33:52.6482273Z -a---- 5/12/2022 1:20 PM 4608 ToolTips.dll
2022-05-12T19:33:52.6496782Z -a---- 9/25/2021 4:51 PM 3584 TypeLib.dll
2022-05-12T19:33:52.6511742Z -a---- 9/25/2021 4:51 PM 4096 UserInfo.dll
2022-05-12T19:33:52.6526140Z -a---- 5/12/2022 1:20 PM 48640 UserMgr.dll
2022-05-12T19:33:52.6540612Z -a---- 9/25/2021 4:51 PM 8192 VPatch.dll
2022-05-12T19:33:52.6546236Z
2022-05-12T19:33:52.6585479Z [includeMorePlugins] dump 'D:\a_tasks\nsis_a459f79f-b932-4ebc-ae19-060fd656b294\3.0.0\nsis\nsis-3.08\plugins\x86-unicode':
2022-05-12T19:33:52.6595357Z
2022-05-12T19:33:52.6596242Z
2022-05-12T19:33:52.6597592Z Directory: D:\a_tasks\nsis_a459f79f-b932-4ebc-ae19-060fd656b294\3.0.0\nsis\nsis-3.08\plugins\x86-unicode
2022-05-12T19:33:52.6597888Z
2022-05-12T19:33:52.6597961Z
2022-05-12T19:33:52.6606752Z Mode LastWriteTime Length Name
2022-05-12T19:33:52.6609333Z ---- ------------- ------ ----
2022-05-12T19:33:52.6618137Z -a---- 5/12/2022 1:20 PM 15360 AccessControl.dll
2022-05-12T19:33:52.6633441Z -a---- 9/25/2021 4:51 PM 6144 advsplash.dll
2022-05-12T19:33:52.6648135Z -a---- 9/25/2021 4:51 PM 4096 Banner.dll
2022-05-12T19:33:52.6968661Z -a---- 9/25/2021 4:51 PM 7680 BgImage.dll
2022-05-12T19:33:52.6971171Z -a---- 9/25/2021 4:51 PM 3584 Dialer.dll
2022-05-12T19:33:52.6971915Z -a---- 5/12/2022 1:20 PM 87040 DotNetChecker.dll
2022-05-12T19:33:52.6977258Z -a---- 5/12/2022 1:20 PM 3072 DumpLog.dll
2022-05-12T19:33:52.6986498Z -a---- 5/12/2022 1:20 PM 28160 FindProcDLL.dll
2022-05-12T19:33:52.6987242Z -a---- 9/25/2021 4:51 PM 15872 InstallOptions.dll
2022-05-12T19:33:52.6987853Z -a---- 5/12/2022 1:20 PM 36864 KillProcDLL.dll
2022-05-12T19:33:52.6990930Z -a---- 9/25/2021 4:51 PM 5632 LangDLL.dll
2022-05-12T19:33:52.7034371Z -a---- 9/25/2021 4:51 PM 69120 Math.dll
2022-05-12T19:33:52.7035823Z -a---- 9/25/2021 4:52 PM 9728 nsDialogs.dll
2022-05-12T19:33:52.7036437Z -a---- 9/25/2021 4:52 PM 7168 nsExec.dll
2022-05-12T19:33:52.7037045Z -a---- 9/25/2021 4:52 PM 15360 nsisdl.dll
2022-05-12T19:33:52.7037632Z -a---- 5/12/2022 1:20 PM 62976 SimpleSC.dll
2022-05-12T19:33:52.7038261Z -a---- 9/25/2021 4:52 PM 4096 splash.dll
2022-05-12T19:33:52.7038971Z -a---- 9/25/2021 4:52 PM 7680 StartMenu.dll
2022-05-12T19:33:52.7039557Z -a---- 9/25/2021 4:52 PM 12288 System.dll
2022-05-12T19:33:52.7040150Z -a---- 9/25/2021 4:52 PM 3584 TypeLib.dll
2022-05-12T19:33:52.7040728Z -a---- 9/25/2021 4:52 PM 4096 UserInfo.dll
2022-05-12T19:33:52.7041313Z -a---- 5/12/2022 1:20 PM 56832 UserMgr.dll
2022-05-12T19:33:52.7041951Z -a---- 9/25/2021 4:52 PM 8704 VPatch.dll
2022-05-12T19:33:52.7042339Z
2022-05-12T19:33:52.7042722Z
2022-05-12T19:33:52.7043016Z
2022-05-12T19:33:52.7098740Z Executing nsis D:\a_tasks\nsis_a459f79f-b932-4ebc-ae19-060fd656b294\3.0.0\nsis\nsis-3.08\makensis.exe with arguments: "D:\a\1\s\Poliview.Instalador.AprovApi\NSIS\InstaladorAprovApi.nsi"
2022-05-12T19:33:52.7477741Z ##[command]"D:\a_tasks\nsis_a459f79f-b932-4ebc-ae19-060fd656b294\3.0.0\nsis\nsis-3.08\makensis.exe" "D:\a\1\s\Poliview.Instalador.AprovApi\NSIS\InstaladorAprovApi.nsi"
2022-05-12T19:33:52.8637419Z Processing config: D:\a_tasks\nsis_a459f79f-b932-4ebc-ae19-060fd656b294\3.0.0\nsis\nsis-3.08\nsisconf.nsh
2022-05-12T19:33:52.8668584Z Processing script file: "D:\a\1\s\Poliview.Instalador.AprovApi\NSIS\InstaladorAprovApi.nsi" (ACP)
2022-05-12T19:33:55.9703533Z warning 7010: File: "....\AprovApi_PublishedWebsites\AprovApi*.xml" -> no files found. (D:\a\1\s\Poliview.Instalador.AprovApi\NSIS\InstaladorAprovApi.nsi:367)
2022-05-12T19:33:55.9958241Z warning 7010: File: "....\AprovApi_PublishedWebsites\AprovApi*.html" -> no files found. (D:\a\1\s\Poliview.Instalador.AprovApi\NSIS\InstaladorAprovApi.nsi:370)
2022-05-12T19:33:56.0275492Z warning 7010: File: "....\AprovApi_PublishedWebsites\AprovApi*.less" -> no files found. (D:\a\1\s\Poliview.Instalador.AprovApi\NSIS\InstaladorAprovApi.nsi:372)
2022-05-12T19:33:56.2496891Z warning 7010: File: "....\AprovApi_PublishedWebsites\AprovApi*.png" -> no files found. (D:\a\1\s\Poliview.Instalador.AprovApi\NSIS\InstaladorAprovApi.nsi:375)
2022-05-12T19:33:56.2513794Z warning 7010: File: "....\AprovApi_PublishedWebsites\AprovApi*.jpg" -> no files found. (D:\a\1\s\Poliview.Instalador.AprovApi\NSIS\InstaladorAprovApi.nsi:376)
2022-05-12T19:33:56.2531001Z warning 7010: File: "....\AprovApi_PublishedWebsites\AprovApi*.jpeg" -> no files found. (D:\a\1\s\Poliview.Instalador.AprovApi\NSIS\InstaladorAprovApi.nsi:377)
2022-05-12T19:33:56.2548161Z warning 7010: File: "....\AprovApi_PublishedWebsites\AprovApi*.gif" -> no files found. (D:\a\1\s\Poliview.Instalador.AprovApi\NSIS\InstaladorAprovApi.nsi:378)
2022-05-12T19:33:56.2565718Z warning 7010: File: "....\AprovApi_PublishedWebsites\AprovApi*.resx" -> no files found. (D:\a\1\s\Poliview.Instalador.AprovApi\NSIS\InstaladorAprovApi.nsi:379)
2022-05-12T19:34:01.7651528Z
2022-05-12T19:34:01.7652444Z Processed 1 file, writing output (x86-unicode):
2022-05-12T19:34:01.7697046Z
2022-05-12T19:34:01.7697522Z Output: "D:\a\1\s\Poliview.Instalador.AprovApi\NSIS\instalador\API-APROV-SieconSP7-1.0.4.exe"
2022-05-12T19:34:01.7852357Z Install: 4 pages (256 bytes), 8 sections (2 required) (16576 bytes), 856 instructions (23968 bytes), 517 strings (22430 bytes), 1 language table (278 bytes).
2022-05-12T19:34:01.7853349Z Uninstall: 1 page (128 bytes), 1 section (2072 bytes), 20 instructions (560 bytes), 65 strings (2560 bytes), 1 language table (194 bytes).
2022-05-12T19:34:01.7853855Z Datablock optimizer saved 7255 KiB (~45.5%).
2022-05-12T19:34:01.7854088Z
2022-05-12T19:34:01.7854379Z Using zlib compression.
2022-05-12T19:34:01.7854823Z
2022-05-12T19:34:01.7855136Z EXE header size: 52736 / 39936 bytes
2022-05-12T19:34:01.7855500Z Install code: 9902 / 63972 bytes
2022-05-12T19:34:01.7855850Z Install data: 8832627 / 59409152 bytes
2022-05-12T19:34:01.7856224Z Uninstall code+data: 10894 / 15215 bytes
2022-05-12T19:34:01.8194037Z CRC (0xA6039F04): 4 / 4 bytes
2022-05-12T19:34:01.8194499Z
2022-05-12T19:34:01.8194847Z Total size: 8906163 / 59528279 bytes (14.9%)
2022-05-12T19:34:01.8195119Z
2022-05-12T19:34:01.8195397Z 8 warnings:
2022-05-12T19:34:01.8195918Z 7010: File: "....\AprovApi_PublishedWebsites\AprovApi*.xml" -> no files found. (D:\a\1\s\Poliview.Instalador.AprovApi\NSIS\InstaladorAprovApi.nsi:367)
2022-05-12T19:34:01.8196650Z 7010: File: "....\AprovApi_PublishedWebsites\AprovApi*.html" -> no files found. (D:\a\1\s\Poliview.Instalador.AprovApi\NSIS\InstaladorAprovApi.nsi:370)
2022-05-12T19:34:01.8197391Z 7010: File: "....\AprovApi_PublishedWebsites\AprovApi*.less" -> no files found. (D:\a\1\s\Poliview.Instalador.AprovApi\NSIS\InstaladorAprovApi.nsi:372)
2022-05-12T19:34:01.8198273Z 7010: File: "....\AprovApi_PublishedWebsites\AprovApi*.png" -> no files found. (D:\a\1\s\Poliview.Instalador.AprovApi\NSIS\InstaladorAprovApi.nsi:375)
2022-05-12T19:34:01.8199014Z 7010: File: "....\AprovApi_PublishedWebsites\AprovApi*.jpg" -> no files found. (D:\a\1\s\Poliview.Instalador.AprovApi\NSIS\InstaladorAprovApi.nsi:376)
2022-05-12T19:34:01.8199746Z 7010: File: "....\AprovApi_PublishedWebsites\AprovApi*.jpeg" -> no files found. (D:\a\1\s\Poliview.Instalador.AprovApi\NSIS\InstaladorAprovApi.nsi:377)
2022-05-12T19:34:01.8200479Z 7010: File: "....\AprovApi_PublishedWebsites\AprovApi*.gif" -> no files found. (D:\a\1\s\Poliview.Instalador.AprovApi\NSIS\InstaladorAprovApi.nsi:378)
2022-05-12T19:34:01.8201189Z 7010: File: "....\AprovApi_PublishedWebsites\AprovApi*.resx" -> no files found. (D:\a\1\s\Poliview.Instalador.AprovApi\NSIS\InstaladorAprovApi.nsi:379)
2022-05-12T19:34:01.8261191Z
2022-05-12T19:34:01.8261489Z
2022-05-12T19:34:01.8514293Z ##[section]Finishing: nsis

Hi,

This is where the Q&A link on https://marketplace.visualstudio.com/items?itemName=bizeta.nsis-task&ssr=false#qna sent me, so I'm asking here. Can this be used in an Azure Pipeline? If so, how do you use it in the pipeline?

I've switched from AWS Codepipeline to Azure Pipeline because my new code signing certificate lives in Azure Key Vault. In AWS Codepipeline I just stored the makensis.exe in my repo and used it to compile the installers (i.e. ./makensis.exe /V1 "$(scriptname)" ). Azure Pipeline is blocking the execution of the binary for security reasons, but I found this plugin which seems like it could be used.

If it can indeed be used in Azure Pipeline, is there any chance you could provide an example of the yaml that is required and any additional setup steps required to get the pipeline to see this extension? There is some information in the readme, but it wasn't clear to me what I need to put to make it work.

One other thing that wasn't exactly clear to me was what you meant by the following:

Include NSIS as an environnement variable called NSIS_EXE that you can use in the following tasks.

Do you mean this?

variables:
  - name: NSIS
    value: NSIS_EXE

Thanks for the help!