devdeer / doctorflox Goto Github PK

VSTS shows error

##[error]Invoke-WebRequest : The response content cannot be parsed because the Internet Explorer engine is not available, or
Internet Explorer's first-launch configuration is not complete. Specify the UseBasicParsing parameter and try again.

• Check if sender and target are set in received message.

We want the NuGet push to happen only if the version has changed in the NuSpec.

We should invert the if-logic inside the property to simplify the understanding.

Set the copyright to 2017-2018

After all tests are implemented we should release the version finally.

• Update nuspec
• Edit Wiki-Links

Missing clean separation of View, Viewmodel and Model in the Sample Project.

The FirstOrDefault checks for FullName of the type which can resove to null which will throw an exception when Equals gets called on it.

We will have to completely recreate the core logic

• Create new project containing all types from current Logic.Wpf.
• Use new project in unit tests
• Use new project in sample
• Change CI build to change NuGet

When calling the CreateWindowInstance the second time AssociatedView will not be retrieved. Seems to be an issue with the old view model staying in memory.

We need a sample project for this way of view-model-resolving.

Hello,
there is a missing summary for the event ErrorsChanged in BaseDataModel.cs

/// <inheritdoc />
public event EventHandler<DataErrorsChangedEventArgs> ErrorsChanged;

and

/// <inheritdoc />
public IEnumerable GetErrors(string propertyName)

Best regards

Is it possible to add a DataService to the big sample app. My idea was to show how communication to a external Unit oder a Database can be made. Maybe it is helpful to pick a dispatcher timer, let it run in the dataservice and change the percentage of the progress bar. I think that this can explain how communication with external data can be realized.

• Check if messages are sent and received
• Check if Reset works
• Check if ResetAll works

We are missing a XML doc on the parameter validationResults.

Would be cool, if you could do something like

GetValueFromOtherView<ViewModelType>(vm => vm.SelectedNumber)

so that you could automatically raise a new model view coming up and sending a message back to the calling view model containing the desired data. This should only happen, when the second view results in DialogResult.OK.

https://github.com/devdeer/DoctorFlox/blob/168bc0c18e6f5233d1c95579a98abf049649aed5/src/Ui/Ui.WpfSample/ViewModels/MainViewModel.cs#L154

By naming the method "RunAsyncMessengerSample" it would state clearly that its a sample method and has nothing to do with the tests of the project.

• Check if messages are sent and received
• Check if Reset works
• Check if ResetAll works