devcodepush / improved-lifetime-supply-calculator Goto Github PK

Hi, @armanpartovi !
I was able to finish reviewing your exercise right now. Congratulations, is very well done :)

• Your code is super clean and well structured.
• Great indentation
• The 3 objects are well done
• The function definition is super well done as well.

Just some feedback to improve and finish the exercise:

• As we saw in class, I think you could comment or delete from line 1 to line 14, as the information you have is better structure in 3 objects (as you have done later) than in 12 different flat variables.
• After that, please review your last lines. When you invoke the function 3 times, what you want to pass as arguments are the objects information, not the 12 variables that you have already deleted or commented. ¿How you would do that? Give it a try and let me know! :)

Again, super well done!! 👏🏻👏🏻 Just need to review those details and it's perfectttt!