devblackops / github-action-psscriptanalyzer Goto Github PK

It would be great if this could edit the last comment instead of creating new ones for each push.

I have a few suggestions for improvements. These are not tested, but should work 😀

Errors
Errors could be directly sent back to Actions by changing entrypoint.ps1 L35 to:

foreach ($i in $errors) {
    Write-Output "::error file=$($i.ScriptName),line=$($i.Line),col=$($i.Column)::$($i.RuleName) - $($i.Message)"
}

Warnings
Warnings could be directly sent back to Actions by changing entrypoint.ps1 L38 to:

foreach ($i in $warnings) {
    echo "::warning file=$($i.ScriptName),line=$($i.Line),col=$($i.Column)::$($i.RuleName) - $($i.Message)"
}

PSSA ParseError
PSSA also outputs "ParseErrors". These currently seem to be ignored by this Action, but could be reported with other errors like by changing entrypoint.ps1 L27 to:

$errors   = $issues.Where({($_.Severity -eq 'Error') -or ($_.Severity -eq 'ParseError')})

Reference: https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-a-warning-message

Hi,

The action started failing today, it seems something in Github changed that now it's failing actions with an empty output: entry in actions.yml:

##[error]devblackops/github-action-psscriptanalyzer/v2/action.yml (Line: 30, Col: 9): Unexpected value ''
##[error]devblackops/github-action-psscriptanalyzer/v2/action.yml (Line: 30, Col: 9): Unexpected value ''
##[error]System.ArgumentException: Unexpected type 'NullToken' encountered while reading 'outputs'. The type 'MappingToken' was expected.

(taken from this run: https://github.com/alpeb/linkerd2/runs/946382403?check_suite_focus=true )

Is anybody else experiencing the same issue?

Thanks!

Since github-action-psscriptanalyzer is a repo with a few PowerShell scripts, I think you have an opportunity to give a real example by running github-action-psscriptanalyzer on the github-action-psscriptanalyzer codebase.

The name of the steps in the sample code is "lint", but this tool is not a linter. It's a static code analysis tool [1]. The name should be updated to accurately reflect what the tool does and reduce confusion about its purpose.

[1] https://github.com/PowerShell/PSScriptAnalyzer

When use this PSSA Github Actions, there is no comment push on PR
and on github action log, i get :

Invoke-RestMethod : {"message":"Resource not accessible by integration","documentation_url":"https://developer.github.com/v3/issues/comments/#create-a-comment"}
At /entrypoint.ps1:61 char:5
+     Invoke-RestMethod @params > $null
+     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo          : InvalidOperation: (Method: POST, Reque\u2026application/json
}:HttpRequestMessage) [Invoke-RestMethod], HttpResponseException
+ FullyQualifiedErrorId : WebCmdletWebResponseException,Microsoft.PowerShell.Commands.InvokeRestMethodCommand
##[error]Docker run failed with exit code 1

You can look PowerAruba/PowerArubaCP#23 and https://github.com/PowerAruba/PowerArubaCP/pull/23/checks

I used this config:

name: ci

on:
  push:
    branches:
      - main
  pull_request:
    branches:
      - main

jobs:
  lint:
    name: Run PSScriptAnalyzer
    runs-on: ubuntu-latest
    steps:
      - name: Checkout 🛎
        uses: actions/checkout@v2

      - name: Lint 🕵🏻‍♂️
        uses: devblackops/github-action-psscriptanalyzer@master
        with:
          repoToken: ${{ secrets.GITHUB_TOKEN }}

and even though it finds:

no comment is posted on the PR.

I get the failure
Invoke-RestMethod: /entrypoint.ps1:61 Line | 61 | Invoke-RestMethod @params > $null | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | {"message":"Resource not accessible by | integration","documentation_url":"https://docs.github.com/rest/reference/issues#create-an-issue-comment"}

when attempting to let this lint a PR from a forked repo. I have tried following articles telling me to turn on 'Send write tokens to workflows from fork pull requests' for the organization (which I assume the repos inside it would inherit), however within the org repo there isn't an individual setting for the repo to turn this on (it is at the org level only). Trying to figure out if I'm missing something in the XAML to ensure it uses the appropriate secrets token.