dev-labs-bg / fast-list Goto Github PK

Why Library Compatibility Minimum Android SDK: API level 19?

Will be great get Android SDK: API level 16 Compatibility, if it possible

Cheers!

This code should check to see if a manager is already set and if it is it should not change it.

As a user, it would be helpful to be able to pass in a custom *LayoutManager to the bind function.

Hey, your library looks nice, thanks for sharing.
But wanna got more anothers useful features with your library, such as:

• Item click and item chlid click listeners
• Header and footer
• Auto load more
• Item grouping
• Showing a custom view when adapter is empty
• Draggable and swipeable item
  etc.
  Cheers!

In the DiffUtil code

As suggested by a teammate the areItemsTheSame and the areContentsTheSame should probably be reversed, since the compare closure seems more in line with comparing the contents. So it will look like this instead
`

        override fun areItemsTheSame(oldItemPosition: Int, newItemPosition: Int): Boolean {
            return items[oldItemPosition] == newList[newItemPosition]
        }

        override fun areContentsTheSame(oldItemPosition: Int, newItemPosition: Int): Boolean {
            return compare(items[oldItemPosition], newList[newItemPosition])
        }`

Or alternatively for more flexibility, you can change the lambda to have an additional param
compare: (T, T, Boolean)
where the Boolean lets the method know if this is the contentsTheSame check or not

Final comment, could you be making unnecessary copies of the new list
items = newList.toMutableList()
I am not sure if this is needed at all where you can just do
items = newList
Or if if has to be mutable
if (newList is MutableList) items = newList else items = newList.toMutableList()

I can send all these changes as a pull request if you like

First: great lib! I'm using it and it's really practical

Second: Would be great to add support for horizontal recyclerviews

        recyclerView.bind(list, R.layout.recycler_view_item) { item: FragmentItem ->
            name.text = item.name
            path.text = item.path
        }
                .layoutManager(LinearLayoutManager(this))

Activity crashed with log "java.lang.NoClassDefFoundError: Failed resolution of: Lcom/list/rados/fast_list/FastListViewHolder;"

used in a Android module library with release 1.2 .

As a user it would be very helpful and a lot more intuitive to be able to bind items based on their class type, instead of an special Item class with type.

Just wanted to know if you would like to see a pull request with DiffUtil integration?
I think it can be done with observable from kotlin std library.

https://developer.android.com/reference/android/support/v7/util/DiffUtil

I need to use the adapter's position in my project. How do I get it?