detectlanguage / detectlanguage-php Goto Github PK

Your engine works very fine, in general. But after testing a little, I found that there are annoying cases of misinterpretation, one of which is found directly in your instructions.

How can it be that a word like "señor" is interpreted as Portuguese at all? In Portuguese, your example sentence would read "Bom dia senhor".

Likewise, a construction like "Fjord- und Familienpferde", which is clearly German, is interpreted as Norwegian, probably due to the word "Fjord" which takes preference here.

The same is true for the sequence "Fjordpferd, Fjord, Pferde, Pferd, Fjordpferde, Fjordgestüt, Gestüt" which has lots of words nonexistent in Norwegian. Google detects it as German and translates into Norwegian with "Fjord hest, fjord, hester, hest, fjordhest, Fjord Stud, Stud".

I think the 2nd test is proof that "Fjord" is the trigger for the characterization as Norwegian. Acknowledging this, how big is the chance that other words would trigger wrong language characterizations as well?

Hi

I've been a longtime (and happy!) user. I'm currently converting my site to Laravel and thus also my languagedetect routine. This however gives me an error:

DetectLanguage::detect("Buenos dias señor"); throws an error while DetectLanguage::detect("Buenos dias senor"); doesn't (same with é, à etc)

The error thrown is
` Invalid server response:

at vendor/detectlanguage/detectlanguage/lib/DetectLanguage/Client.php:45
41▕ $response_body = self::$request_method($url, $params);
42▕ $response = json_decode($response_body);
43▕
44▕ if (!is_object($response))
➜ 45▕ throw new Error("Invalid server response: $response_body");
46▕
47▕ if (isset($response->error))
48▕ throw new Error($response->error->message);
`

In Client.php the params-parameter is

array:1 [
  "q" => b"Buenos dias señor"
]

I'm guessing the 'b' doesn't belong there :) I can't seem to find where it's coming from?! it's already present in $text in the detect() class in DetectLanguage.php.