desmos-labs / desmjs Goto Github PK

Currently DesmJS only offers a custom implementation of the Signer class: WalletConnectSigner. Even thought this is surely useful for some cases (eg. when we want to give users the ability to log into a DApp using DPM), it's not sufficient to cover all options.

For this reason, I think we also need to add a KeplrSigner class that implements the Signer instance and relies on Keplr to manage the accounts and sign the transactions.

This implementation should then live inside its own package keplr that can be published at @desmoslabs/desmjs-keplr

In order to let clients interact with smart contracts through DesmJS we need to update the generate-code.sh to allow it to generate the useful .ts code from the proto files.

Currently DesmJS only offers a custom implementation of the Signer class: WalletConnectSigner. Even thought this is surely useful for some cases (eg. when we want to give users the ability to log into a DApp using DPM), it's not sufficient to cover all options.

For this reason, I think we also need to add a LedgerSigner class that implements the Signer instance and relies on a direct connection (either USB or Bluetooth) with a Ledger device to manage the accounts and sign the transactions.

This implementation should then live inside its own package ledger that can be published at @desmoslabs/desmjs-ledger

Bug description

Recently updated @desmoslab/desmjs to v2.0.0-beta.5

Going into node_modules, only the following directories are present:

ls node_modules/@desmoslabs/desmjs-types/
>>> README.md    cosmos_proto desmjs       desmos       gogoproto    google       ibc          node_modules package.json

But checking with package.json of @desmoslabs/desmjs-types, there should be more files included, note that cosmos is missing, causing errors when trying to use the module.

  ...
  "files": [
    "cosmos/",
    "cosmos_proto/",
    "desmjs/",
    "desmos/",
    "gogoproto/",
    "google/",
    "ibc/",
    "*.md",
    "!wasmd-0.16/**/*.md",
    "!wasmd-0.18/**/*.md"
  ],
  ...

Steps to reproduce

yarn upgrade @desmoslabs/[email protected]
yarn start

errors encountered:

more similar errors...
ERROR in ./node_modules/@desmoslabs/desmjs-types/ibc/core/client/v1/client.js 53:18-71
Module not found: Error: Can't resolve '../../../../cosmos/upgrade/v1beta1/upgrade' in 'path-to-react-project/node_modules/@desmoslabs/desmjs-types/ibc/core/client/v1'

Expected behavior

No errors

Currently new versions of DemsJS are published by hand using the yarn publish command. This however has two main problems:

• developers need to have a NPM access_token in order to log into the repository and be able to publish new versions
• developers need to manually update the versions of packages before publishing them

Instead, what we can do is make sure that new packages versions are published when a new DesmJS tag is created by using GitHub actions. This way secrets will leave inside the repository and developers do not need to manually update the version each time.

In order to allow clients to correctly interact with cosmwasm smart contracts we need to allow them to use the related messages.
It's useful to extend the get-proto.sh script to make it able to also download the proto files of CosmWasm from which later the useful .ts structure are generated.

Currently DesmJS only offers a custom implementation of the Signer class: WalletConnectSigner. Even thought this is surely useful for some cases (eg. when we want to give users the ability to log into a DApp using DPM), it's not sufficient to cover all options.

For this reason, I think we also need to add a MnemonicSigner class that implements the Signer instance and stores the encoded mnemonic into a safe place on the browser.

This implementation should then live inside its own package mnemonic that can be published at @desmoslabs/desmjs-mnemonic