derfloh205 / craftsim Goto Github PK

6x CraftSim/ProfitCalculation.lua:30: attempt to perform arithmetic on field '?' (a nil value)
[string "@CraftSim/ProfitCalculation.lua"]:30: in function handleInspiration' [string "@CraftSim/ProfitCalculation.lua"]:244: in function getMeanProfit'
[string "@CraftSim/StatweightCalculation.lua"]:65: in function CalculateStatWeights' [string "@CraftSim/StatweightCalculation.lua"]:81: in function getProfessionStatWeightsForCurrentRecipe'
[string "@CraftSim/CraftSim.lua"]:350: in function TriggerModulesByRecipeType' [string "@CraftSim/CraftSim.lua"]:87: in function <CraftSim/CraftSim.lua:83> [string "=[C]"]: in function Init'
[string "@Blizzard_Professions/Blizzard_ProfessionsCrafting.lua"]:273: in function SelectRecipe' [string "@Blizzard_Professions/Blizzard_ProfessionsCrafting.lua"]:262: in function <...lizzard_Professions/Blizzard_ProfessionsCrafting.lua:253> [string "=[C]"]: ? [string "@SharedXML/CallbackRegistry.lua"]:143: in function <SharedXML/CallbackRegistry.lua:142> [string "=[C]"]: ? ... [string "@SharedXML/Scroll/ScrollUtil.lua"]:322: in function SelectElementDataByPredicate'
[string "@Blizzard_ProfessionsTemplates/Blizzard_ProfessionsRecipeList.lua"]:162: in function SelectRecipe' [string "@Blizzard_Professions/Blizzard_ProfessionsCrafting.lua"]:692: in function Init'
[string "@Blizzard_Professions/Blizzard_ProfessionsCrafting.lua"]:242: in function <...lizzard_Professions/Blizzard_ProfessionsCrafting.lua:241>
[string "=[C]"]: ?
[string "@SharedXML/CallbackRegistry.lua"]:143: in function <SharedXML/CallbackRegistry.lua:142>
[string "=[C]"]: ?
[string "@SharedXML/CallbackRegistry.lua"]:146: in function TriggerEvent' [string "@Blizzard_Professions/Blizzard_ProfessionsFrame.lua"]:133: in function SetProfessionInfo'
[string "@Blizzard_Professions/Blizzard_ProfessionsFrame.lua"]:88: in function <...s/Blizzard_Professions/Blizzard_ProfessionsFrame.lua:59>

Locals:
self =

17x ...rfaceCraftSim/Data/SpecNodeData/SpecData.lua:240: attempt to index local 'nodeInfo' (a nil value)
[string "@CraftSim/Data/SpecNodeData/SpecData.lua"]:240: in function <...rfaceCraftSim/Data/SpecNodeData/SpecData.lua:223>
[string "=(tail call)"]: ?
[string "@CraftSim/Data/DataExport.lua"]:852: in function exportRecipeData' [string "@CraftSim/Main/CraftSim.lua"]:409: in function TriggerModulesByRecipeType'
[string "@CraftSim/Main/CraftSim.lua"]:146: in function TriggerModulesErrorSafe' [string "@CraftSim/Main/CraftSim.lua"]:179: in function <CraftSim/Main/CraftSim.lua:164> [string "=[C]"]: ? [string "=[C]"]: in function Init'
[string "@Blizzard_ProfessionsTemplates/Blizzard_ProfessionsRecipeSchematicForm.lua"]:191: in function <...emplates/Blizzard_ProfessionsRecipeSchematicForm.lua:185>
[string "=[C]"]: in function Show' [string "@FrameXML/UIParent.lua"]:2915: in function SetUIPanel'
[string "@FrameXML/UIParent.lua"]:2758: in function ShowUIPanel' ... [string "=[C]"]: in function UseAction'
[string "@FrameXML/SecureTemplates.lua"]:364: in function `handler'
[string "@FrameXML/SecureTemplates.lua"]:690: in function <FrameXML/SecureTemplates.lua:672>
[string "@FrameXML/SecureTemplates.lua"]:704: in function <FrameXML/SecureTemplates.lua:697>
[string "@FrameXML/SecureTemplates.lua"]:746: in function <FrameXML/SecureTemplates.lua:730>
[string "=[C]"]: ?
[string "@FrameXML/SecureHandlers.lua"]:266: in function <FrameXML/SecureHandlers.lua:263>
[string "=[C]"]: ?
[string "@FrameXML/SecureHandlers.lua"]:296: in function <FrameXML/SecureHandlers.lua:279>
[string "=(tail call)"]: ?

Locals:
self =

Trace:

1x CraftSim/StatweightCalculation.lua:93: bad argument #1 to 'pairs' (table expected, got nil)
[string "=[C]"]: in function `pairs'
[string "@CraftSim/StatweightCalculation.lua"]:93: in function `GetExpectedQualityBySkill'
[string "@CraftSim/Frames.lua"]:1345: in function `UpdateSimModeStatDetails'
[string "@CraftSim/SimMode.lua"]:95: in function `InitSimModeData'
[string "@CraftSim/CraftSim.lua"]:343: in function `TriggerModulesByRecipeType'
[string "@CraftSim/CraftSim.lua"]:100: in function <CraftSim/CraftSim.lua:99>

Recipe: https://www.wowhead.com/spell=376564/fiddle-with-khazgorite-fabric-cutters

Checking for thresholds before should fix it:

    if thresholds then
        for _, threshold in pairs(thresholds) do
            if skill > threshold then
                expectedQuality = expectedQuality + 1
            end
        end
    end

This is commonly caused by using the old method of accessing the global GameTooltip as opposed to the new tooltip processor calls.

This bug has been occurring where the profit calculation doesn't update when checking "Use Best Quality Reagents" and ends up showing a stale profit despite having new materials assigned.

Steps to reproduce:

1. Open up a material to craft
2. View the CraftSim Average Profit (104g 20s 43c)
3. Press "Use Best Quality Reagents"
4. Compare the CraftSim Average Profit

Expected:
CraftSim Average Profit should immediately update (-120g 27s 93c)

Actual:
CraftSim Average Profit is stuck on the old value (104g 20s 43c).

5. Now that the profit is out of sync, uncheck "Use Best Quality Reagents"
6. Compare the CraftSim Average Profit

Expected:
CraftSim Average Profit should be the same as when we first saw it in step 2 (104g 20s 43c)

Actual:
CraftSim Average Profit shows the old value that should have shown in step 4 (-120g 27s 93c)

Workaround:
Reassigning any of the reagent qualities by clicking on a reagent then pressing accept will properly recalculate the CraftSim Average Profit. It will however break again if you repeat the reproduction steps again.

Goblin alchemist currently showing 272 (105+167) base skill for frost flasks in WoW UI (Tepid Versatility for example). CraftSim says 277. Is the +5 from goblin racial maybe calculated wrong?

The Blacksmith Hammer Black Dragon Touched Hammer, Item ID 191228 has a bonus "When inspired, increases the Skill provided to Dragon Isles crafts by 15%.".
This bonus is not taken into any calculations, as also shown in Simulation Mode

Getting this error when trying to do a recraft on a pair of engineering googles.
As soon as i choose the item to recraft the error shows.
It only happens when i try to recraft my googles. All other items has no error.

There seems to be quiet a difference between the price of quality 2 and quality 3 safety components. Sometimes it seems possible, to save money by using a quality 2 safety component instead of a quality 3 safety component, and use higher quality materials of materials with a smaller difference in price between quality 2 and 3. This might result in a lower total price to craft.

Readout:

24x CraftSim/Util/Tooltip.lua:13: attempt to call method 'GetItem' (a nil value)
[string "@CraftSim/Util/Tooltip.lua"]:13: in function <CraftSim/Util/Tooltip.lua:12>
[string "=(tail call)"]: ?
[string "=[C]"]: in function securecallfunction' [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:60: in function <SharedXML/Tooltip/TooltipDataHandler.lua:55> [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:80: in function <SharedXML/Tooltip/TooltipDataHandler.lua:76> [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:116: in function <SharedXML/Tooltip/TooltipDataHandler.lua:106> [string "=[C]"]: in function SetAttribute'
[string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:141: in function <SharedXML/Tooltip/TooltipDataHandler.lua:134>
[string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:282: in function <SharedXML/Tooltip/TooltipDataHandler.lua:240>
[string "=[C]"]: in function securecallfunction' [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:237: in function ProcessInfo'
[string "@SharedXML/Tooltip/TooltipComparisonManager.lua"]:249: in function SetItemTooltip' ... [string "@FrameXML/GameTooltip.lua"]:527: in function GameTooltip_ShowCompareItem'
[string "@SharedXML/Tooltip/TooltipDataRules.lua"]:161: in function func' [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:49: in function <SharedXML/Tooltip/TooltipDataHandler.lua:44> [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:71: in function <SharedXML/Tooltip/TooltipDataHandler.lua:67> [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:135: in function <SharedXML/Tooltip/TooltipDataHandler.lua:134> [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:282: in function <SharedXML/Tooltip/TooltipDataHandler.lua:240> [string "=[C]"]: in function securecallfunction'
[string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:237: in function ProcessInfo' [string "@Blizzard_EncounterJournal/Blizzard_EncounterJournal.lua"]:2092: in function EncounterJournal_SetTooltipWithCompare'
[string "*Blizzard_EncounterJournal.xml:1382_OnEnter"]:3: in function <[string "*Blizzard_EncounterJournal.xml:1382_OnEnter"]:1>

Hi!
first of all thanks a lot for making this tool!
is it possible to include the tag "smartavgbuy" in the material costs for crafting items?
I have personally setup a string like this in TSM, which I used in previous expansions to better gauge when crafts are profitable when you did shopping previously when costs were lower than current market price.
the string:
min(smartavgbuy, dbmarket, crafting, vendorbuy, convert(dbmarket))

thanks!

I was doing the quest "To Give One's Heart" in the Ruby Lifeshrine on my jewelcrafting alt and received the following error when I crafted the quest item. Thanks.

6x .../Modules/ReagentOptimization/ReagentOptimization.lua:310: attempt to index field '?' (a nil value)
[string "@CraftSim/Modules/ReagentOptimization/ReagentOptimization.lua"]:310: in function optimizeKnapsack' [string "@CraftSim/Modules/ReagentOptimization/ReagentOptimization.lua"]:178: in function OptimizeReagentAllocation'
[string "@CraftSim/Main/CraftSim.lua"]:481: in function TriggerModulesByRecipeType' [string "@CraftSim/Main/CraftSim.lua"]:129: in function TriggerModulesErrorSafe'
[string "@CraftSim/Main/CraftSim.lua"]:162: in function <CraftSim/Main/CraftSim.lua:147>
[string "=[C]"]: ?
[string "=[C]"]: in function Init' [string "@Blizzard_ProfessionsTemplates/Blizzard_ProfessionsRecipeSchematicForm.lua"]:251: in function Refresh'
[string "@Blizzard_Professions/Blizzard_ProfessionsCrafting.lua"]:151: in function <...lizzard_Professions/Blizzard_ProfessionsCrafting.lua:120>

Locals:
self =

The temporary buff "Alchemically Inspired" https://www.wowhead.com/spell=382093/alchemically-inspired appears not to be added to the calculations of the profit/craft, nor in towards the Inspiration % when you look at the simulation mode. This buff can be applied consistently with the Advanced Phial Experimentation tree.

If I add the buff, or click it off, the addon does not seem to take this into account.

The addon does seem to calculate the temporary buff like the Sagacious Incense, and it updates it's estimates as expected.

I have a chef's hat with Multicraft and Crafting Speed boni, and when I take it off and set CraftSim show Top Multicraft for Top Gear, the addon displays the chef's hat as Top Gear correctly but displays incorrect Multicraft bonus. See below screenshot:

In the screenshot, the chef's hat will give new 2.25% bonus of Multicraft but at the same time the widget shows Multicraft: +0.00% in the summary.

Just updated to the recent version and noticed I can't see the crafting cost or any SIM details for crushing or prospecting.

The Glassware node affects the reagents that take fractured glass in crafting: empty soul cage, draconic vial, and frameless lens. but this is missing in the experimental specialization data.

Version: 5.0

It seemed that in the simulation mode it showed 2% more inspiration than seemed correct.

Hello, it would be very nice if the hidden skill bonus could be implemented into CraftSim. Here is a video with some info on what it does/why it's relevant https://www.youtube.com/watch?v=bcMKDfaI9oY

For the actual numbers it seems like you have an equal chance of 1/6 to get +0/1/2/3/4/5% of the recipe's base difficulty as bonus skill. This can push some crafts into being profitable that would otherwise not be (for example some stuff that can be crafted at 3 skill below T3 with everything maxed out).
This should definitely be an opt-in experimental feature for now since we don't know for sure how it works.

For instance LW recipe for Flaring Cowl has 6 reagents[1] but when entering simulation mode, there is only 5 of the shown.
The Resilient Leather is completely left out making it impossible to simulate this craft properly.

[1] https://www.wowhead.com/spell=375197/flaring-cowl

Is there any chance at all to (either optionally or by default) make the black windows we have now into blizzard style windows?
Similar to profession window.
The current black and white borders layout is very ugly and sort of ruins the immersion :(

Not a big deal as its visual only
Thank you

The "reach inspiration breakpoint" feature seems to sometimes suggest too low quality materials.
It seems to sometimes select material qualities in such way that there seems to be still a low amount of skill points missing (like 1.6 points) to cover the skill points required for a guaranteed highest quality craft in the case of an "inspiration" proc. In the case(s) where I have seen this it seemed possible to cover that by selecting higher quality materials.

i have 0 idea of addon development or lua in general but i am currently writing a weak aura to auto reply to various crafting requests. would it be possible to provide some sort of API in your addon that can generate required materials based and output it to a weakaura?

Hi, I was just sending myself a live preview to check out this awesome feature and I noticed that the %chance did not change after I selected the Finishing#2 reagent.
Yes, it did request an update (this message in the top right) and I waited until it finished, nothing changed.

In the screenshots I have the normal crafting and live preview with and without finishing reagent.

It mentions TSM but I do not use the TSM crafting panel so it has nothing to do with that. It seems to happen most frequently when browsing for crafting orders at my crafting table.

5x CraftSim/DataExport.lua:456: bad argument #1 to 'pairs' (table expected, got nil)
[string "=[C]"]: in function `pairs'
[string "@CraftSim/DataExport.lua"]:456: in function `GetProfessionGearStatsByLink'
[string "@CraftSim/DataExport.lua"]:554: in function `GetEquippedProfessionGear'
[string "@CraftSim/GearSim.lua"]:109: in function `GetProfessionGearCombinations'
[string "@CraftSim/GearSim.lua"]:369: in function `SimulateBestProfessionGearCombination'
[string "@CraftSim/CraftSim.lua"]:358: in function `TriggerModulesByRecipeType'
[string "@CraftSim/CraftSim.lua"]:87: in function <CraftSim/CraftSim.lua:83>
[string "=[C]"]: in function `Init'
[string "@Blizzard_ProfessionsTemplates/Blizzard_ProfessionsRecipeSchematicForm.lua"]:188: in function <...emplates/Blizzard_ProfessionsRecipeSchematicForm.lua:182>
[string "=[C]"]: in function `Show'
[string "@FrameXML/UIParent.lua"]:2890: in function `SetUIPanel'
[string "@FrameXML/UIParent.lua"]:2733: in function `ShowUIPanel'
...
[string "@TradeSkillMaster/LibTSM/Util/Event.lua"]:132: in function `ProcessEvent'
[string "@TradeSkillMaster/LibTSM/Util/Event.lua"]:150: in function <TradeSkillMaster/LibTSM/Util/Event.lua:141>
[string "=[C]"]: ?
[string "=[C]"]: in function `UseAction'
[string "@FrameXML/SecureTemplates.lua"]:364: in function `handler'
[string "@FrameXML/SecureTemplates.lua"]:690: in function <FrameXML/SecureTemplates.lua:672>
[string "@FrameXML/SecureTemplates.lua"]:704: in function <FrameXML/SecureTemplates.lua:697>
[string "@FrameXML/SecureTemplates.lua"]:746: in function `SecureActionButton_OnClick'
[string "@FrameXML/ActionButton.lua"]:1175: in function <FrameXML/ActionButton.lua:1145>
[string "=[C]"]: ?

Locals:
(*temporary) = nil
(*temporary) = "table expected, got nil"
 = <function> defined =[C]:-1

I am getting the following error the first time I open the craft window after logging in/reloading UI.

Interface/AddOns/CraftSim/Data/DataExport.lua:584: bad argument #1 to 'pairs' (table expected, got nil)

This is occurring on multiple characters. The error appears to be coming from GetProfessionGearStatsByLink

I got your addon to help me figure out ways to reach inspiration breakpoints without having to own the materials. It's great for that.

However, every time I log in it warns me no price source is found and suggests some addons I could get to fix that. I don't want to. I just want this little material shuffling feature. Can I be spared the warning?

Checking for operationInfo before seem to "fix" it:

	local operationInfo = schematicForm:GetRecipeOperationInfo()
    if operationInfo then
        recipeData.expectedQuality = operationInfo.craftingQuality
    else 
        return nil
    end

Got the following two errors when crafting some Azureweave Expedition Packs. Was using a tool with Resourcefulness.

Message: ...face/AddOns/CraftSim/Modules/CraftResults/Frames.lua:34: attempt to index field 'inspiration' (a nil value)
Time: Tue Jan 31 18:36:41 2023
Count: 2
Stack: ...face/AddOns/CraftSim/Modules/CraftResults/Frames.lua:34: attempt to index field 'inspiration' (a nil value)
[string "=[C]"]: ?
[string "@Interface/AddOns/CraftSim/Modules/CraftResults/Frames.lua"]:34: in function `UpdateRecipeData'
[string "@Interface/AddOns/CraftSim/Modules/CraftResults/CraftResults.lua"]:405: in function `AddResult'
[string "@Interface/AddOns/CraftSim/Modules/CraftResults/CraftResults.lua"]:334: in function `callback'
[string "@Interface/AddOns/CraftSim/Util/Util.lua"]:66: in function `ContinueOnAllItemsLoaded'
[string "@Interface/AddOns/CraftSim/Modules/CraftResults/CraftResults.lua"]:333: in function `processCraftResults'
[string "@Interface/AddOns/CraftSim/Modules/CraftResults/CraftResults.lua"]:217: in function <...ddOns/CraftSim/Modules/CraftResults/CraftResults.lua:216>

Locals: 

Message: ...face/AddOns/CraftSim/Modules/CraftResults/Frames.lua:34: attempt to index field 'inspiration' (a nil value)
Time: Tue Jan 31 18:36:47 2023
Count: 2
Stack: ...face/AddOns/CraftSim/Modules/CraftResults/Frames.lua:34: attempt to index field 'inspiration' (a nil value)
[string "=(tail call)"]: ?
[string "@Interface/AddOns/CraftSim/Modules/CraftResults/Frames.lua"]:34: in function `UpdateRecipeData'
[string "@Interface/AddOns/CraftSim/Modules/CraftResults/CraftResults.lua"]:405: in function `AddResult'
[string "@Interface/AddOns/CraftSim/Modules/CraftResults/CraftResults.lua"]:334: in function <...ddOns/CraftSim/Modules/CraftResults/CraftResults.lua:333>
[string "@Interface/AddOns/CraftSim/Util/Util.lua"]:74: in function <Interface/AddOns/CraftSim/Util/Util.lua:68>
[string "=[C]"]: in function `xpcall'
[string "@Interface/FrameXML/ObjectAPI/AsyncCallbackSystem.lua"]:76: in function `FireCallbacks'
[string "@Interface/FrameXML/ObjectAPI/AsyncCallbackSystem.lua"]:35: in function <Interface/FrameXML/ObjectAPI/AsyncCallbackSystem.lua:31>
[string "=[C]"]: ?
[string "=[C]"]: in function `accessor'
[string "@Interface/FrameXML/ObjectAPI/AsyncCallbackSystem.lua"]:52: in function `AddCallback'
[string "@Interface/FrameXML/ObjectAPI/Item.lua"]:330: in function `ContinueOnItemLoad'
[string "@Interface/AddOns/CraftSim/Util/Util.lua"]:80: in function `ContinueOnAllItemsLoaded'
[string "@Interface/AddOns/CraftSim/Modules/CraftResults/CraftResults.lua"]:333: in function `processCraftResults'
[string "@Interface/AddOns/CraftSim/Modules/CraftResults/CraftResults.lua"]:217: in function <...ddOns/CraftSim/Modules/CraftResults/CraftResults.lua:216>

Locals: <none>

hi again!
I am trying out the custom TSM strings. however there's no way to reset back to the defaults.
such option would be lovely.

thanks!

Hello, first of all love your addon, thank you!
I couldnt find this feature (maybe its there already) but i would like a visual identifier that i need to craft this item to get "first craft" bonus skill.
I have a lot of alts, and currently have to click each item 1 at a time to check this.
Then i learn more recipes, and i have to remember to do it ALL over again, in which case i have to redo it all because i just forget what i checked.
I think this would be a great feature , and could be enabled by default but of course optional in settings :)

Hope you consider it, thank you!!

example:

When you click on a Life-Bound recipe (like Life-Bound Belt), CraftSim does nothing. If you click on a different non-Life-Bound recipe and then click on a Life-Bound recipe, it continues to display the previous recipe instead of the Life-Bound one.

When a costumer asked me with the command about a recipe for 405 ilvl, the addon answered him correct ranks (rank 3 and rank 5) but with uncorrect item levels (from the bracket without Primal Infusion)

In CraftSim Specialization Info it should account for Primordial/Elemental leatherworking points currently does not. This seems to affect more than just Flaring Cowl (other leather patterns have this issue "String of Spiritual Knick-Knacks" where the Mail patterns do not)

Hey,
Love your work, the addon is great, ive found a few issues though

Craftsim does not correctly calculate Profit for all Missives in Inscription (seems like some issue with quality?)
https://gyazo.com/985db9a1e6712f2219ea371ea500460f

Also with Combatant Gear (Specifically Crimson Combatant's Emblem)

It does not appear to be updating pricing data when using Auctioneer as source, idk if this is just me or something more?
https://gyazo.com/97b1f5ef25a6f032e16853f94d2669eb

Thanks

Hi today i found out that recrafting gear with all Q3 mats is not the same as crafting new gear with all Q3 mats.

Simulator shows 100% Q5

In recrafts few points are missing

would it be possible to add separete simulation for recrafts of items that are not currently in you inventory?

Love the new feature to specify optional reagents in the Simulation Mode tab, thanks for that!

EDIT: It appears if I apply the Fluidic reagent in the default blizzard frame, then check the "Simulation Mode" box, the values are correct.

Only issue I've found with it so far, is that it looks like its using +15% inspiration skill for all ranks.

In the "Inspiration Skill" line in the simulation box, I see the following values:

• (No Fluidic)
  • 65 (50.0*1.30+15)
• (R1 Fluidic)
  • 72.5 (50.0*1.45+22.5)
• (R2 Fluidic)
  • 72.5 (50.0*1.45+22.5)
• (R3 Fluidic)
  • 72.5 (50.0*1.45+22.5)

For me, (Blacksmithing) R3 should be getting to 78 skill, which is probably rounded. I'm not sure on how the exact calculation works. I have the Epic hammer (+15%) as well as 15 points into Poigant Plans, which is giving another +15%. This appears to be reflected correctly with the (50.0*1.30) portion.

I'm sure this is already on your radar, just wanted to point it out in case its not.

Thanks so much for your work on this, its absolutely fantastic!

Error when crafting non DF items, in this case Lightless Silk Pouch with Tailoring.

Message: ...ddOns/CraftSim/Modules/CraftResults/CraftResults.lua:299: attempt to index field 'stats' (a nil value)
Time: Fri Feb  3 23:57:54 2023
Count: 6
Stack: ...ddOns/CraftSim/Modules/CraftResults/CraftResults.lua:299: attempt to index field 'stats' (a nil value)
[string "=[C]"]: ?
[string "@Interface/AddOns/CraftSim/Modules/CraftResults/CraftResults.lua"]:299: in function `processCraftResults'
[string "@Interface/AddOns/CraftSim/Modules/CraftResults/CraftResults.lua"]:217: in function <...ddOns/CraftSim/Modules/CraftResults/CraftResults.lua:216>

Locals: 

I get these when opening work orders for: Primal Molten Longsword, Primal Molten Pauldrons.
Not sure what triggers it, previously opening the work order for the shoulders didn't give this error.

1x ...rfaceCraftSim/Data/SpecNodeData/SpecData.lua:152: CraftSim Error: Node ID not implemented: 23911
[string "=[C]"]: in function error' [string "@CraftSim/Data/SpecNodeData/SpecData.lua"]:152: in function GetStatsFromSpecNodeData'
[string "@CraftSim/Data/DataExport.lua"]:247: in function handlePlayerProfessionStatsV2' [string "@CraftSim/Data/DataExport.lua"]:359: in function handlePlayerProfessionStats'
[string "@CraftSim/Data/DataExport.lua"]:863: in function exportRecipeData' [string "@CraftSim/Main/CraftSim.lua"]:435: in function TriggerModulesByRecipeType'
[string "@CraftSim/Main/CraftSim.lua"]:169: in function TriggerModulesErrorSafe' [string "@CraftSim/Main/CraftSim.lua"]:202: in function <CraftSim/Main/CraftSim.lua:187> [string "=[C]"]: ? [string "=[C]"]: in function Init'
[string "@Blizzard_ProfessionsTemplates/Blizzard_ProfessionsRecipeSchematicForm.lua"]:191: in function <...emplates/Blizzard_ProfessionsRecipeSchematicForm.lua:185>
[string "=[C]"]: in function Show' [string "@Blizzard_Professions/Blizzard_ProfessionsCrafterOrderPage.lua"]:766: in function ViewOrder'
[string "@Blizzard_Professions/Blizzard_ProfessionsCrafterOrderPage.lua"]:63: in function <...Professions/Blizzard_ProfessionsCrafterOrderPage.lua:58>

Locals:
(*temporary) = "CraftSim Error: Node ID not implemented: 23911"

Hi,

As stated in the headline there is a bug with items not having correct ranks both for guarentee and inspiration proccs.
This is only tested for Leatherworking

The issue only seems to occur when asking for items that require a Primal Infusion or Concentrated Infusion.
The customer asks for the 418 version which i can craft np, but what is returned via the automatic reply is rank 3 (412 ilvl). I have set the automatic reply to only show the inspiration procc item, so showing rank 3 is a problem.

I have rank 4 as guarentee and inspiration procc rank 5 on all crafts with Primal Infusion (405 ilvl) or Concentrated Primal (418 ilvl)

Attached is a screenshot of a few tests, all of them asking for a 418 (rank 5) and me returning with the inspiration chance item of 412 (rank 3) which should show 418 (rank 5).

The following error occurs when opening the mining or herbalism journal without knowing how to refine herbs or ore.

19x ...ceCraftSim/Modules/SimulationMode/Frames.lua:689: attempt to index field 'currentRecipeData' (a nil value)
[string "@CraftSim/Modules/SimulationMode/Frames.lua"]:689: in function UpdateVisibility' [string "@CraftSim/Main/CraftSim.lua"]:388: in function TriggerModulesByRecipeType'
[string "@CraftSim/Main/CraftSim.lua"]:111: in function TriggerModulesErrorSafe' [string "@CraftSim/Main/CraftSim.lua"]:134: in function <CraftSim/Main/CraftSim.lua:124> [string "=[C]"]: ? [string "=[C]"]: in function Init'
[string "@Blizzard_Professions/Blizzard_ProfessionsCrafting.lua"]:273: in function SelectRecipe' [string "@Blizzard_Professions/Blizzard_ProfessionsCrafting.lua"]:262: in function <...lizzard_Professions/Blizzard_ProfessionsCrafting.lua:253> [string "=[C]"]: ? [string "@SharedXML/CallbackRegistry.lua"]:143: in function <SharedXML/CallbackRegistry.lua:142> [string "=[C]"]: ? [string "@SharedXML/CallbackRegistry.lua"]:146: in function TriggerEvent'
...
[string "@SharedXML/Scroll/ScrollUtil.lua"]:322: in function SelectElementDataByPredicate' [string "@Blizzard_ProfessionsTemplates/Blizzard_ProfessionsRecipeList.lua"]:162: in function SelectRecipe'
[string "@Blizzard_Professions/Blizzard_ProfessionsCrafting.lua"]:692: in function Init' [string "@Blizzard_Professions/Blizzard_ProfessionsCrafting.lua"]:242: in function <...lizzard_Professions/Blizzard_ProfessionsCrafting.lua:241> [string "=[C]"]: ? [string "@SharedXML/CallbackRegistry.lua"]:143: in function <SharedXML/CallbackRegistry.lua:142> [string "=[C]"]: ? [string "@SharedXML/CallbackRegistry.lua"]:146: in function TriggerEvent'
[string "@Blizzard_Professions/Blizzard_ProfessionsFrame.lua"]:133: in function `SetProfessionInfo'
[string "@Blizzard_Professions/Blizzard_ProfessionsFrame.lua"]:88: in function <...s/Blizzard_Professions/Blizzard_ProfessionsFrame.lua:59>

Locals:
self =

This seems to be because the addon will try to open simulation mode on an entry for which it is invalid, like the individual ore and herb entries. Clicking to a valid entry like refine herb or ore will fix the issue and prevent the lua from reappearing until the next UI reload or relog.

Please make all existing and future functions with "disable" button.
I really don't want to see "control panel" all the time. And same thing for the tooltip TSM/Auctionator intergration.

I got the following LUA error when opening a Public Work Order for "S.A.V.I.O.R.":

1x ...faceCraftSim/Modules/CostOverview/Frames.lua:50: attempt to concatenate field 'link' (a nil value)
[string "@CraftSim/Modules/CostOverview/Frames.lua"]:50: in function Fill' [string "@CraftSim/Modules/CostOverview/CostOverview.lua"]:19: in function CalculateCostOverview'
[string "@CraftSim/Main/CraftSim.lua"]:611: in function TriggerModulesByRecipeType' [string "@CraftSim/Main/CraftSim.lua"]:169: in function TriggerModulesErrorSafe'
[string "@CraftSim/Main/CraftSim.lua"]:202: in function <CraftSim/Main/CraftSim.lua:187>
[string "=[C]"]: ?
[string "=[C]"]: in function Init' [string "@Blizzard_ProfessionsTemplates/Blizzard_ProfessionsRecipeSchematicForm.lua"]:191: in function <...emplates/Blizzard_ProfessionsRecipeSchematicForm.lua:185> [string "=[C]"]: in function Show'
[string "@Blizzard_Professions/Blizzard_ProfessionsCrafterOrderPage.lua"]:766: in function `ViewOrder'
[string "@Blizzard_Professions/Blizzard_ProfessionsCrafterOrderPage.lua"]:63: in function <...Professions/Blizzard_ProfessionsCrafterOrderPage.lua:58>

Locals:
self =

It seems to be item specific - I can't craft this item but the error won't pop up with other ones I can't make.

Edit: it also pops up for Fierce Illimited Diamond but not Elemental Lariat (I can make neither).
No sign of it for any recipes I can craft, though I could only check with Treatises since work orders are extremely hard to find.

When shift-clicking an item from chat to look at it in the dressing room, this message pops up where is the item ID of the item in question.

For example, a Drakebreaker's Mallet has item ID 199094. When shift-clicking to look at it in the dressing room from a chat window, the message "No player named '199094' is currently playing." pops up.

Right now I am using Auctionator and sometimes when I do scan when some craft reagens display at very low price. It happends because that price was actually lowest, but had only 1 item of it (either it was just lazy seller or low price baiter). Meanwhile it is possible to override that price it is not always comfortable way, because "average" price may vary a lot. It could be much better if override had option like "Override if price is lower than X" or something which could do something similar.

Since the last update, it seems like new crafts are having the material bonus capped as if they're recrafts or something?

E.g. I have a new craft of a 280 difficulty recipe. It should be able to get 70 skill (25%) material bonus, but in sim mode it caps at 34.6

Trace:

3x Usage: self:SetNormalTexture(asset)
[string "=[C]"]: in function `SetNormalTexture'
[string "@CraftSim/Frames.lua"]:1310: in function `UpdateSimModeFrames'
[string "@CraftSim/SimMode.lua"]:71: in function `InitSimModeData'
[string "@CraftSim/CraftSim.lua"]:343: in function `TriggerModulesByRecipeType'
[string "@CraftSim/CraftSim.lua"]:100: in function <CraftSim/CraftSim.lua:99>

This should fix it:

            if itemData.itemTexture then 
                inputFrame.icon:SetNormalTexture(itemData.itemTexture)
            end

2x CraftSim/CraftSim.lua:165: attempt to index local 'recipeInfo' (a nil value)
[string "@CraftSim/CraftSim.lua"]:165: in function <CraftSim/CraftSim.lua:160>
[string "=[C]"]: ?
[string "=[C]"]: in function Hide' [string "@FrameXML/UIParent.lua"]:3355: in function <FrameXML/UIParent.lua:3350> [string "=[C]"]: ? [string "=[C]"]: in function securecall'
[string "@FrameXML/UIParent.lua"]:3393: in function <FrameXML/UIParent.lua:3362>
[string "=[C]"]: in function `CloseWindows'
[string "@DeModal/core/DeModalMixin.lua"]:61: in function <DeModal/core/DeModalMixin.lua:58>
[string "=[C]"]: ?

Locals:
professionInfo =