der-fruhling-entertainment / create-train-perspective Goto Github PK

Describe the bug
When leaving the train on a slope, the easing back to an upright posture is jittery in a similar way to #22.

To Reproduce
Steps to reproduce the behavior:

1. Get train.
2. Take the train over a slope.
3. Jump off the train.
4. Observe jittery easing (or "diminish(ment)", apparently).

Expected behavior
Non-jittery easing.

Describe the bug
The player's legs do not rotate with the train correctly.

To Reproduce
Steps to reproduce the behavior:

1. Take a seat on a train.
2. Take the train over some turns.
3. Observe the player's legs turning incorrectly.

Expected behavior
The player's legs should turn with the train.

Describe the bug
The camera does it's own thing while in third-person mode on a train on a slope.

To Reproduce
Steps to reproduce the behavior:

1. Get train.
2. Take the train over a slope.
3. Enter third-person mode.
4. Move mouse around.
5. Observe weirdness.

Expected behavior
Not this.

Describe the bug
While trains are on a slope, players on the train will experience jittery movement.

To Reproduce
Steps to reproduce the behavior:

1. Get train.
2. Take it over a slope.
3. Observe jittery movement.

Expected behavior
It should not be jittery.

Is your feature request related to a problem? Please describe.
When you're on the train, you turn with it, but not on a rollercoaster (minecart contraption). How would it be if this mod made it possible on all contraptions?

Describe the solution you'd like
How about turning on all contraptions?

Implement 1.18.2 support.

Extension of #48. Blocked by #48.

Describe the bug
While train is on a slope and looking sideways, player camera looks down at real floor rather than perspective-adjusted floor.

To Reproduce
Steps to reproduce the behavior:

1. Get train
2. Take train over a slope
3. Look to a side
4. Attempt to look down from the side
5. Observe incorrect perspective adjustment

Expected behavior
Expected the player to look at the train when looking down.

Describe the bug
When entering a slope from certain angles, the camera will rotate the incorrect way.

To Reproduce
Steps to reproduce the behavior:

1. Get train
2. Take train over a slope on the offending angles
3. Observe camera movement

Expected behavior
Consistency. Isn't this an issue I've already fixed???

It's gone through a couple phases at this point and could be optimized significantly.

Describe the bug
The block targeting does not respect perspective changes from the mod.

To Reproduce
Steps to reproduce the behavior:

1. Get train.
2. Take the train on a slope.
3. Attempt to find which block the game thinks you're looking at.
4. Observe incorrect targeting.

Expected behavior
Crosshair should indicate targeted block accurately.

Describe the bug
A slight jittering is noticeable in some instances. Probably caused by this mod's overwriting of getViewYRot() in LocalPlayer. Compatibility for such change may be difficult to achieve.

To Reproduce
Steps to reproduce the behavior:

1. ??? (varies depending on mod, happens with "do a barrel roll" when crossing between -180° and 180° yaw)
2. Observe slight jittering.

Expected behavior
No jittering.

Describe the bug
When on a slope, on some axis and while standing, the mod is leaning the wrong way.

To Reproduce
Steps to reproduce the behavior:

1. Get train.
2. Take train over a slope going towards -Z.
3. Observe leaning.

Expected behavior
Player should lean as if they are sitting on the train.

Is your feature request related to a problem? Please describe.
Players vertically rotate (or "lean") when viewed in third-person view or by other players, but this is not reflected by the player's camera.

Describe the solution you'd like
Implement vertically rotating the camera when the player's train is on a slope. It would need to rotate around the player's feet.

Describe the bug
The player's perspective does not translate correctly when the player is standing on a train currently on a slope. The camera will appear as if it is moving forwards and backwards because in this case the camera is not being adjusted to be at the position rotated around the player's feet, as in the behavior while seated.

To Reproduce
Steps to reproduce the behavior:

1. Get train.
2. Take train over a slope.
3. Ensure that you are standing on the train, not seated.
4. Observe lack of proper camera movement. (emphasized in third-person view)

Expected behavior
The camera should be placed where the head appears.

crash with figura installed

Steps to reproduce the behavior:
1.install figura and Create: Train Perspective
2. crash your game :D
crash-2024-06-03_21.05.42-client.txt
debug.log
latest.log

Describe the bug
when one person is sitting in a train and they go on a slope and an other player has the train loaded their camera also tilts. also happens when not looking at the train.

To Reproduce
Steps to reproduce the behavior:

1. make a slope and build a train
2. make one person drive the train and the other person watch
3. drive the train on the slope and the camera of both playes tilt

Expected behavior
that the camera of the player thats watching the train isn't tilting

Screenshots

Describe the bug
When the player's train is on a slope and the slant of the slope changes, the player's "leaning" effect will appear jittery.

To Reproduce
Steps to reproduce the behavior:

1. Take a seat on a train.
2. Take the train over some slopes.
3. Observe the jittery "leaning" effect.

Expected behavior
The jittery effect should instead be smooth.

Describe the bug
crash on start up

To Reproduce
Steps to reproduce the behavior:

1. install figura, immersive aircraft, create: train perspective
2. launch game

some more info: disabling any of those 3 mods will fix the issue

crash-2024-06-14_17.13.35-client.txt
debug.log
latest.log

Describe the bug
While train is turning, perspective clearly moves slightly.

To Reproduce
Steps to reproduce the behavior:

1. Get train.
2. Take train over some turns.
3. Observe perspective.

Expected behavior
Perspective appears locked.

Most likely, this function does not depend on you, but still. How about fixing the player's camera in a standing position as well?.
When I didn't know about the existence of your mod, I tried to use "create: interactive", for the sake of fixing the camera inside the train (it works both standing and sitting), I didn't use any other functions, but the problem is that "interactive" is a big mod with a bunch of mechanics and problems I don't need (while he's in beta).

(I am incredibly grateful to you for this mod).

1.19.2 support would be nice, because a lot of other create additions haven't updated yet.
Maybe 1.18.2, but I feel like that is not as important.

Is your feature request related to a problem? Please describe.
It bothers me that whenever you stand in the train and drive around a bend, everything shakes extremely.

Describe the solution you'd like
Reduce it to half. It's quite disturbing, but not so exaggerated.

Additional context
You could also add that players who are not sitting in the train are pushed forward when the train brakes and backwards when the train accelerates.

Is your feature request related to a problem? Please describe.
Some config options would be nice.

Describe the solution you'd like
Config options. Possibly:

• Vertical leaning toggle
• Total mod disable

Additional context
Add any other context or screenshots about the feature request here.

Describe the bug
Leaning is jittery when viewing the player's in third-person.

To Reproduce
Steps to reproduce the behavior:

1. Get train.
2. Take the train over a slope
3. While train is going over slope, use third-person
4. Observe jittering

Expected behavior
Smooth leaning

Describe the bug
While a train is on a slope, the player moving their head causes sounds to rapidly cut out and back in and sunrise/sunset fog to do something similar. This is probably because some vector is not being transformed properly.

I believe this is still an issue. Due to it's nature I haven't been able to reproduce it reliably, so it's possible this was fixed already.

To Reproduce
Steps to reproduce the behavior:

1. Get train.
2. Take train over a slope.
3. Turn your player's head while a sound is playing (train sounds work) or the sun is rising/setting.
4. Listen to the sounds being strange and observe sunrise/sunset.

Expected behavior
A clear and concise description of what you expected to happen.