dengwirda / jigsaw-geo-matlab Goto Github PK

When I install the jigsaw conda package, I now have jigsaw and tripod in my path. However, when I try to call jigsaw.m, I get:

error: JIGSAW's executable not found -- has JIGSAW been compiled from src?

The problem seems to be 2-fold. First, the expectation is that jigsaw is installed locally rather than in my path, whereas I would think the first place to look would be in my path:
https://github.com/dengwirda/jigsaw-geo-matlab/blob/master/jigsaw.m#L280-L281
Second, the file naming convention seems to be different than what the conda package produces (here's there's a 64d or 64r appended).

I presume there is plan to update this repo following the 0.9.10 release, and I wanted to just point out this issue to make sure it's part of such an update.

Using: jigsaw-geo64r.exe
downloaded from archive: dengwirda-jigsaw-geo-matlab-66d396d (zenodo)

Running the example for the uniform geo mesh at 150, 30, 20, 10km spacings, the number of points specified in the output file (points=N) does not match the actual number of points listed in the text file. Not sure if there is a similar problem with the listed number of triangles.

As I work on #12, I am realizing that it would be simplest to separate the python wrapper from the library itself.

What would be ideal would be for this package to have a standard build process to install both the executable and the libraries in a system-wide location via make install. Then the cython code could link to those libraries and not have to worry about hacking the linking process.

Is this something you would consider providing?

Hi @dengwirda...just getting up to speed on jigsaw. Thanks for this amazing package!

Us python users would love a python API to jigsaw-geo. Wrapping c++ libraries for python is very common and easy to do thanks to cython. Here are some instructions on how this works:
https://github.com/cython/cython/wiki/WrappingCPlusPlus

I'm wondering if you have considered doing this or if someone else has done it already. @toddringler mentioned that they use python to interact with jigsaw. I would consider spending some time on it myself, but I don't want to repeat effort that has already been done elsewhere.

Thanks again for contributing this fantastic tool to our community.

Need to add support for mesh-spacing functions defined on unstructured ellipsoidal surface meshes...