demians12 / flowave-infrastructure Goto Github PK

Each file should have a documentation or even be commented. It helps new engineers fix bugs identifying faster incorrect code or a non good practice.

the source path in pritunl is wrong after refactoring

• this file cannot be public
• it must be centralized in root terraform folder

Define a set standardized tests for all modules

• standardize the variable names to make the code easier to maintain and read.
• Create a centralized variable.tf for all files and organize its code to make easier finding a specific variable.

A readme file organized in topics such as presentation, description, table of contents (in case a large readme file) and images

It would be helpful a refactoring of the existent terraform code before keep updating the project.

a terraform folder with a lot of files with any dependencies is a bad practice.

• Separate resources in folders according its use
• Use standardized and clear names to make easier identify what resource that folder and files implement.
• Create documentation teaching what commands are necessary to apply the configuration with no errors and the correct sequence of provisioning.
• If possible create scripts using bash script or Go to automate the applying