Giter Club home page Giter Club logo

Comments (9)

r10s avatar r10s commented on June 21, 2024 2

i will try out the suggestions from simon to build core with the PR from link2xt

yeah, that works out. i am in business again :) thanks a lot for help, i would have no chance to build desktop without your help 🙏

from deltachat-desktop.

Simon-Laux avatar Simon-Laux commented on June 21, 2024 1

deltachat-node has no arm/m1 prebuild, so it is always built. the "linking" to node step somehow fails for you, it looks like a nodejs header problem. For me node 18.18.2 worked.

Anyways might be easier to figure this issue out with a local core, so:

  • delete node_modules folder
  • checkout core repo, run npm run build in both repo-root folder and deltachat-jsonrpc/typescript/
  • run npm i ../deltachat-core-rust ../deltachat-core-rust/deltachat-jsonrpc/typescript in desktop repo (path should point to your core checkout)

deltachat-desktop/docs/UPDATE_CORE.md

Lines 47 to 55 in 2ac3deb

If you already have a core git checkout, you can skip the first step.
1. clone the core repo, right next to your desktop repo folder: `git clone [email protected]:deltachat/deltachat-core-rust.git`
2. go into your core checkout and run `git pull` to update it to the newest version, then create a branch for your changes
3. run `npm i` and `npm run build` inside `../deltachat-core-rust/`
4. run `npm i` and `npm run build` inside `../deltachat-core-rust/deltachat-jsonrpc/typescript/`
5. go into your desktop repo and run `npm i ../deltachat-core-rust/deltachat-jsonrpc/typescript` and `npm i ../deltachat-core-rust`
Note that you need to run step 3 and 4 again after each change to core sourcecode.

from deltachat-desktop.

link2xt avatar link2xt commented on June 21, 2024 1

This change seems to fix the problem in my case: deltachat/deltachat-core-rust#5489
I tried on macOS with node 20 installed via nix profile install nixpkgs#nodejs.

from deltachat-desktop.

link2xt avatar link2xt commented on June 21, 2024

Probably prebuild for the used core was not uploaded to npm.

EDIT: seems to be uploaded already :/

from deltachat-desktop.

r10s avatar r10s commented on June 21, 2024

i also tried over with node 18 - similar issue:

log

EDIT: also same with node 20

from deltachat-desktop.

link2xt avatar link2xt commented on June 21, 2024

Similar issue: balena-io/balena-cli#2721

from deltachat-desktop.

link2xt avatar link2xt commented on June 21, 2024

@r10 What is your output of cc --version?

In my case problems happen with:

Apple clang version 15.0.0 (clang-1500.3.9.4)
Target: arm64-apple-darwin23.4.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

It seems part of the problem is new clang which treats -Wincompatible-function-pointer-types as error by default.

from deltachat-desktop.

link2xt avatar link2xt commented on June 21, 2024

I have reproduced it with Node 18 and Xcode 15.3 in CI on macos-14 runner (macos-latest does not have Xcode 15.3): https://github.com/deltachat/deltachat-core-rust/actions/runs/8791852121/job/24126899012?pr=5488

Fix is at deltachat/deltachat-core-rust#5489

from deltachat-desktop.

r10s avatar r10s commented on June 21, 2024

@Simon-Laux , @link2xt , @adbenitez thanks a lot for help! ❤️ i will try out the suggestions from simon to build core with the PR from link2xt.

but please do not let that block things and go forward to merge and do whatever is needed :)

EDIT: @link2xt cc --version shows the same for me:

Apple clang version 15.0.0 (clang-1500.3.9.4)
Target: arm64-apple-darwin23.4.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

and, yes, iirc, there was an xcode update

from deltachat-desktop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.