Some dialogs slow in loading async state when opening about deltachat-desktop HOT 5 CLOSED

the real solution would be to not need a spinner, by using a virtual list for this, there is already an issue for this: #1830

Show group members (only slow on first load)

It's not slow for me, how many group members do you have? under which circumstances? what means "first load" (app or dialog?)?

Also I prefer skeleton items to a spinner.

from deltachat-desktop.

Cool, I'll change the title then. Agree that we should look into the root of the problem first.

the real solution would be to not need a spinner, by using a virtual list for this, there is already an issue for this: #1830

I'm looking at a 800ms loading delay for opening the ViewGroup dialog for the first time, rendering ca. 30 contacts, not sure if a virtual list is a solution to this problem. Maybe we have different issues in different dialogs?

I've tried hooking in the React Debugger into the Electron Extensions to do some profiling but it didn't work out on first attempt (not sure what's the issue yet). So far I could only use the default Dev Tool profiler. It's clear that the bottleneck sits in the frontend code from looking at it, but without the React Debugger we will not easily find out where, or my source maps are not working ..

from deltachat-desktop.

Ah, I think I found the issue, at least for the ViewGroup dialogue. Probably also this issue only pops up when doing a development build:

There's invalid HTML in ViewGroup which causes React to throw an error when opening the component for the first time:

"react-dom.development.js:67 Warning: validateDOMNesting(...): <p> cannot appear as a descendant of <p>."

After fixing the invalid element the dialog opens faster ✨

from deltachat-desktop.

After fixing the invalid element the dialog opens faster ✨

Thats btw indirectly fixed by #3627

from deltachat-desktop.

I'm closing this now as the other dialog's issue is discussed in #1830

from deltachat-desktop.