Giter Club home page Giter Club logo

Comments (2)

r10s avatar r10s commented on August 24, 2024

did some research: the function was introduced in 2016 at signalapp/Signal-Android@f2b81d8 to fix signalapp/Signal-Android#5381

the signal-bug seemed to be introduced shortly before by disallowing file:-uri alltogether.

the fix allows file:-uri unless they are created by the app itself.

tbh, not sure what the idea of that is and if that would affect us at all - we're only creating files in the internal app-space, and there the share-to-delta should not have access at all

from deltachat-android.

link2xt avatar link2xt commented on August 24, 2024

File URLs are probably avoided for security reasons, so other apps cannot "share" to Delta Chat a file URL to its own accounts.toml or other easy-to-guess filename. Smart Voice Recorder is some app that passes file URLs to Signal and they wanted to support it so allowed file URLs as long as they don't point to internal files of the app itself.

we're only creating files in the internal app-space, and there the share-to-delta should not have access at all

The other app does not need to have access to Delta Chat files such as accounts.toml to guess the URL and pass it to Delta Chat.

from deltachat-android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.