deducteam / ekstrakto Goto Github PK

Some remarks/suggestions about

• all and lemmas_lpo are the same targets: one should be removed of fixed
• all does not include proof_*.lpo: shouldn't all be lemmas_lpo+proof?
• isn't the prefix "lemmas" in the rule lemmas/%.lp: lemmas/%.p is useless?
• with lambdapi, you do not need to add the dependencies. So, the rules lemmas/%.lpo : lemmas/%.lp %s.lpo and proof_%s.lpo: ... are subsumed by the rule %.lpo: %.lp

There are many calls to Sys.getcwd(). One is enough.

But why is it necessary to know the current directory at all? If not, then calls to Sys.getcwd() should be removed.

There are many things coming from zenon_modulo that are not useful for ekstrakto.

In phrase.ml, almost every thing except the contents of phrase.mli.

Similarly, there seems to be various things in expr.ml that could be removed.

Is namespace really useful either?

Finally, we could remove the things of misc.ml that are not used too.

All .mli files but expr.mli can be removed. I don't understand why, when I remove expr.mli, I get an error in Phrase.no_duplicates:

File "src/phrase.ml", line 36, characters 31-33:
Error: This expression has type unit
       This is not a function; it cannot be applied.

The expression is <>.