Add verbose flag to ok() in integrator.py to suppress output? about dedalus HOT 4 CLOSED

Original comment by Benjamin Brown (Bitbucket: Benjamin Brown).

Implementing this in integrator looks like it requires adding a verbosity flag to the integrator call:

#!python
    def __init__(self, problem, domain, timestepper, verbose=True):

        # Input parameters
        self.problem = problem
        self.domain = domain

        # Output control
        self.verbose = verbose

and then in the ok(): def:

#!python
    @property
    def ok(self):
        if self.time >= self.sim_stop_time:
            ok_flag = False
            if (self.verbose): print('Simulation stop time reached.')
        elif (time.time() - self.start_time) >= self.wall_stop_time:
            ok_flag = False
            if (self.verbose): print('Wall stop time reached.')
        elif self.iteration >= self.stop_iteration:
            ok_flag = False
            if (self.verbose): print('Stop iteration reached.')
        else:
            ok_flag = True

        return ok_flag

This implementation appears to work.

from dedalus.

Original comment by J. S. Oishi (Bitbucket: jsoishi).

That will work, but a better way would be to have a code-wide verbose flag
using the not-yet-ported from Dedalus 1 configuration subsystem.

from dedalus.

Original comment by Keaton Burns (Bitbucket: kburns).

More specifically I'm planning on moving these messages to a logging handler (something like the Dedalus1 version, as well), with a global configuration system like Jeff mentioned that will control what log levels are printed, etc.

from dedalus.

Original comment by Keaton Burns (Bitbucket: kburns).

• changed state from "new" to "resolved"

As of commit acc2cd1, these messages are passed as "info" calls to the logger. Logging levels can be configured for the desired level of verbosity.

from dedalus.