Non-linear products about dedalus HOT 6 CLOSED

Original comment by Keaton Burns (Bitbucket: kburns).

• changed priority from "major" to "critical"

from dedalus.

Original comment by Keaton Burns (Bitbucket: kburns).

• Edited issue description

from dedalus.

Original comment by Keaton Burns (Bitbucket: kburns).

• changed priority from "critical" to "minor"

This has been implemented in a much more general operator-based approach, and is functional as of commit 413a9a3. The interface with the rest of the code (i.e. all parts outside of Operators.py) is pretty rough (nonlinear.py, pencils.py, etc) and in need of improvement.

In particular: currently its inelegant to define the F / RHS expressions in a domain independent fashion since they are inherently composed of operations between (necessarily existing) field objects. This is currently circumvented with an eval(f_string) approach, but perhaps theres a better (more purely symbolic?) alternative.

from dedalus.

Original comment by Keaton Burns (Bitbucket: kburns).

Also: the current evaluation structure does a good job avoiding redundant / unnecessary transposes and transforms, but duplicated operations are still performed independently. This should be eliminated, perhaps with some sort of class register.

from dedalus.

Original comment by Keaton Burns (Bitbucket: kburns).

• changed state from "new" to "resolved"

from dedalus.

Original comment by Keaton Burns (Bitbucket: kburns).

• changed state from "resolved" to "closed"

from dedalus.