Giter Club home page Giter Club logo

chari's Introduction

chari's People

Contributors

brigittaforrai avatar dfogaras avatar phraktle avatar rszaloki avatar treerz avatar

Stargazers

 avatar

Watchers

 avatar

chari's Issues

Holy shit! Love it! Beautiful App guys ;-D Consider adding an escapeHatch!

Love the work here :-D thank you for taking this on! We built something similar (but never really put a front end to it). It was a long time ago, on an old solidity version and an old version of the Giveth DApp but I figure you might want to see it:

https://github.com/Giveth/fund-forwarder/blob/master/contracts/FundForwarder.sol

What I really want to encourage is a solution to the edge case for potential failures of kind benefactors that maybe think they can just send tokens to the address, and then they would be stuck in the contracts.

It is best practice to create an escapeHatch as a safety net in these edge case scenarios...

This is what we use (may need to be updated to the newest solidity version:

https://github.com/Giveth/common-contract-deps/blob/master/contracts/Escapable.sol

I can't tell you how often this happens... It happens more with people that feel comfortable with ETH financially, but not necessarily are comfortably technically! Even in Moloch, there is 100 W-ETH stuck forever because of the lack of an escapehatch...

You do have an upgradeable contract, so that might be able to work out, but it would be a bit of a hassle.

My 2 wei!

Much love,
Griff

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.