Giter Club home page Giter Club logo

mashshare's People

Contributors

ilgityildirim avatar razvanaldea89 avatar rene-hermenau avatar stayallive avatar yahelc avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

mashshare's Issues

Notice: Array to string conversion

Greetings,

we have just encountered with these kind of warning messages.
When you load a page for the first time, some warning messages appear (check the attachment). When you refresh it, warning messages disseppear.
We were checking that file and we noticed that this code

$this->data->$service[0] = $count;

should be

$this->data->service[0] = $count; // without $ at service[0]

After this change warning messages no longer appear.
Can you please fix that? Thank you.

Best regards
JaWs

warnings

Option to make buttons large on mobile devices

e.g. fb button:

@media only screen and (max-width: 568px){
#mashbar-header .mashsb-buttons a {
    min-width: 140px;
}
#mashbar-header .mashicon-facebook {
    text-align: left;
}

#mashbar-header .mashicon-facebook .text {
    text-indent: initial;
    line-height: 0;
    display: inline-block;
     margin-left:5pxt;
}

}

Ajax based themes are not showing mashshare buttons

Ticket: https://secure.helpscout.net/conversation/213645628/446/?folderId=780867

mashshare_filter_content() in template-functions.php prevents share buttons from display in condition !is_main_query()

It seems as when some ajax based themes are creating the post data outside the main_query as a result the automatic share buttons are not shown.

Let's consider if is_main_query condition is needed or if that option should be selectable.
Removing that option completely can lead to increase of db requests on some themes.

This issue only happens rare!

Add filter for an additional customizations

Hi,

We have suggestion about some filters to increase plugin's customizability.
E.g. We want to have an additional shortcode option - display or not to display secondary-shares.

Customer should customizate it within their theme functions.php to avoid some issues, e.g. during updating your plugin.So we would like to add some extra filters within your template-functions.php to filtering shortcode arguments and the counter of the services.

We'll do it by contribution.
@jawtemplates team

Better explanation of open graph and twitter card integration

If these settings are activated MashShare is creating its own open graph tags and the twitter card data and populates them with data coming from the MashShare meta box.
If the mashshare meta box fields are not used the open graph fields will be filled with the YOAST open graph data. So the MashShare open graph data and twitter cards will be containing the same data that YOAST would be using

We did that to support user who are not using a plugin like the YOAST one to make sure their site contains useful open graph data for a better sharing experience

So, if you do not want to use the mashshare meta box just deactivate MashShare Open graph and twitter card it and it is working as before.

Mashshare plugin causing PHP errors on blank search page

Hello,

We've noticed that if you go to e.g. search and type some unsearchable stuff it will throw lots of php errors - this happens even if we get to a page.

Notice: Trying to get property of non-object in /home/webs/.../wp-content/plugins/mashsharer/includes/template-functions.php on line 890
Notice: Trying to get property of non-object in /home/webs/.../wp-content/plugins/mashsharer/includes/scripts.php on line 44
Notice: Trying to get property of non-object in /home/webs/.../wp-content/plugins/mashsharer/includes/scripts.php on line 45
Notice: Trying to get property of non-object in /home/webs/.../wp-content/plugins/mashsharer/includes/template-functions.php on line 743
Notice: Trying to get property of non-object in /home/webs/.../wp-content/plugins/mashsharer/includes/template-functions.php on line 221
Notice: Trying to get property of non-object in /home/webs/.../wp-content/plugins/mashsharer/includes/template-functions.php on line 230
Notice: Undefined property: stdClass::$share_count in /home/webs/.../wp-content/plugins/mashsharer/includes/mashengine.php on line 136
Notice: Trying to get property of non-object in /home/webs/.../wp-content/plugins/mashsharer/includes/template-functions.php on line 241
Notice: Trying to get property of non-object in /home/webs/.../wp-content/plugins/mashsharer/includes/template-functions.php on line 249
Notice: Trying to get property of non-object in /home/webs/.../wp-content/plugins/mashsharer/includes/template-functions.php on line 250

We'll try contribute the fix :)
@jawtemplates team

PHP error

Hi There. i recently bought the plugin and its throwing this error, Please
mashare-error
file attached.

Notice: Undefined property: stdClass::$share_count in /usr/www/users/everlkgzgb/wp-content/plugins/mashsharer/includes/mashengine.php on line 133
mashare-error

Use a popup code for subscribe form or pure js.

The content of the subscribe button should be generated via js to prevent indexing from search engines

<script>

/*HTML Code hier in die Variable 'form' hinein */

var form = '<form>  First name:<br>  <input type="text" name="firstname"><br>  Last name:<br>
  <input type="text" name="lastname"></form>';

document.write(form);

</script>

Suggestions

Ticket: #900

  • Most popular posts by Category widget
  • Reset Share Counts (page / post based button would be amazing instead of purging all -this was requested before-)
  • Restrict sharing to specific categories

Twitter share text including website name

I just upgraded to MashShare 3.0.4 and noticed that the Twitter share text now includes the website name. For example...

Before: "This Is The Article Title"

Now: "This Is The Article Title - Website Name"

Any way to change that? I don't want the website name to be included. I have Yoast SEO enabled, so I'm not using the MashShare tags.

Purge Cache Option - Returning abnormal very high sharecount

It happens from time to time that one of the networks api is returning a very high abnormal share count.

MashShare is not changing the cached share count when the requested one is smaller than the previous one so this wrong share count stays forever in the database until the requested share count becomes higher than the stored one.

We need a button for purging the shares of specific post so user is able to fix that on his own.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.