deanroddey / cidlib Goto Github PK

XMLFormat pretty mode corrupts a Microsoft Open XML file/Excel 2015 styles file.

Attached is a test file before and after pretty formatting.

Excel error generated:

Removed Part: /xl/styles.xml part with XML error. (Styles) Whitespace expected. Line 4, column 43.

Before section:

<numFmt numFmtId="164" formatCode="&quot;$&quot;#,##0.00"/>

After section:

<numFmt numFmtId="164" formatCode=""$"#,##0.00"/>

styles_after.txt
styles_before.txt

XMLFormat behaves oddly when used in a makefile in Visual Studio 2017. The makefile line immediately after the XMLFormat line will display unprintable characters instead of tabs and CR/LF's.

The makefile echoes message 1, then XMLFormat, then message 2, then message 3. Message 2 is affected, and message 3 is OK.

Add XMLFormat to the path and run "nmake test" from the Visual Studio 2017 developer prompt

repro.zip

XMLFormat pretty mode generates a lot of unnecessary naked carriage returns on lines by themselves when run on a Microsoft Open XML file

The entire xml prior to conversion is attached

sheet9.txt

XMLFormat changes Microsoft Open XML double quotes to single quotes

Before: <?xml version="1.0" encoding="UTF-8" standalone="yes" ?>

After: <?xml version='1.0' encoding='UTF-8' standalone='yes' ?>

The entire xml prior to conversion is attached

sheet9.txt

Attached is a test file (Microsoft Open XML file/Excel 2015).

XMLFormat pretty mode will generate inconsistent output of cell formulas.

Example 1 output:

<f t="shared" ref="I7:I38" ca="1" si="3">$I6+$M6</f>

Example 2 output:

<f t="shared" ref="J7:J38" ca="1" si="4">
IFERROR(NPER(SP_MortRate/12,PMT(SP_MortRate/12,SP_MortNper,SP_MortOriginBalance,0,0)-SP_MortExtraPayment,$I7,0,0),0)
</f>

Example 1 is correct and consistent with the source file. Example 2 interjects a CR/LF before and after the formula value.

It appears the CR/LF interjection behavior is perhaps triggered by the formula exceeding a certain length (60 or so?). This is undesirable as formulas can contain cr/lf characters and the XML data itself shouldn't be changed. All these should be generated consistently with the source file.

sheet9.txt

If the outdir doesn't exist with the overwrite and recurse flags set, XMLFormat simply returns with nothing done.

XMLFormat.exe /SrcDir=xlsm_repo\ /OutDir=xlsm_repo2\ /Spec=*.xml /Fmt=Pretty /Overwrite /Recurse

XMLFormat corrupts Microsoft Open XML files with the pretty mode. The XML file created has significant changes and is not rendered correctly by the Edge browser when opened. In addition, if the pretty file is fed back into XMLFormat with the flat mode, it generates the following error:

The parse failed
Expected an attribute name here

The file prior to conversion is attached

sheet9.txt

If the same directory is used for the srcdir and outdir with overwrite and recurse, it erases every file in the directory regardless of spec.

XMLFormat.exe /SrcDir=xlsm_repo\ /OutDir=xlsm_repo\ /Spec=*.xml /Fmt=Pretty /Overwrite /Recurse