Worldgen creates vanilla doubletall plants with imvalid metadata about tfcraft HOT 10 CLOSED

Just want to make sure I'm understanding this correctly. When using the released version, 0.79.22.761, the crash doesn't happen because there are no flowers being generated?

When you are using a development build though, it does happen? Which development build are you using exactly? What is the most recent commit in the build?

from tfcraft.

Correct, 0.79.22.761 did not generate the flowers and did not crash, so if the error existed it didn't manifest. And I was testing with development version 9e9a10c. I ran the development build inside eclipse and outside with the same results.

from tfcraft.

Now when you say "with the same results" you mean that you generated a brand new world with the specific seed and this new world also generated the flower that caused the crash, right? If you are doing nothing more than copying the world save over, the crash is going to continue to happen because the flower already exists.

from tfcraft.

So I regenerated the world from only the seed 4 times now and it succeeded each time (no crash). And then took the broken world and deleted the region data and regenerated it and it also worked (no crash). In each case, no flowers spawned at all at the given location. In a previous test, I deleted the region data and was able to reproduce the crash - I must have miscalculated the region that time.

There was also a nearby hotspring that changed shape each time so evidence the biome decorator is not based on seed.

from tfcraft.

So I'm digging through the code, and it seems like this has to be a vanilla bug. The setting of the metadata for the flower is determined by a field that is never edited with TFC's code.

from tfcraft.

Considering its a vanilla flower I believe it. Is that biome decorator even supposed to activate for TFC?

from tfcraft.

We don't ever explicitly call it, but that doesn't mean there will never be some fluke where the game thinks the biome is a vanilla one and tries to call it before it realized the biome is a TFC one.

from tfcraft.

Ok, I'll delete them from my world for now and keep a copy of my broken save in case its useful sometime. Hopefully the error doesn't come up again for me or anyone else (it seems very rare).

from tfcraft.

Here's a link of it happening to somebody else without TFC installed:
http://www.minecraftforum.net/forums/support/modded-client-support/2516236-help-with-crash

And here's another one:
https://bugs.mojang.com/browse/MC-73593

So I'm going to go ahead and close this since it's not a TFC issue.

from tfcraft.

The official bug report says the client is modded (bungeecord/craftbukkit) so something deeper might be happening. I'm going to keep an eye on it for a while in case I can find something (maybe a forge bug? who knows).

from tfcraft.