deadlymc / protosky Goto Github PK

View Code? Open in Web Editor NEW

18.0 18.0 23.0 360 KB

License: MIT License

Java 100.00%

protosky's People

Contributors

Stargazers

Watchers

protosky's Issues

Server support?

On https://modrinth.com/mod/basicskyblock, it says the mod is compatible for both client and server. However, I haven't been able to make it work on a server.

Is this possible? If not, will there be server support in the future?

This could be a issue with my computer but on 1.1.6-1.18.2 doesn't generate an end portal. I tried the other 1.18.2 version, and it worked fine. I could provide screenshots if needed but I have given enough information here to explain my issue. (Yes I have structures enabled)

Endportal Frames dont generate (neither do end cities)

If I create a new world in 1.19, End Portals and End cities (the shulkers and the elytra) dont generate. This error is not entirely consistent, as sometimes (very rarely) they do generate. Most of the time they dont. I cant find any correlation between that and i dont know if its my PC or the mod. (Skyblock is the only mod installed)

1.18.2 causes a `RuntimeException` when loaded

Running on the the latest fabric server for 1.18.2. Looks like some minor changes that need to be made. I might be able to take a closer look later on.

Crash Report (click to expand)

---- Minecraft Crash Report ----
// There are four lights!

Time: 2/28/22, 7:12 PM
Description: Exception in server tick loop

java.lang.RuntimeException: Mixin transformation of net.minecraft.class_2881 failed
    at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:252)
    at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:150)
    at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:155)
    at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
    at net.minecraft.class_3218.<init>(class_3218.java:244)
    at net.minecraft.server.MinecraftServer.method_3786(MinecraftServer.java:415)
    at net.minecraft.server.MinecraftServer.method_3735(MinecraftServer.java:330)
    at net.minecraft.class_3176.method_3823(class_3176.java:180)
    at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:670)
    at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:273)
    at java.base/java.lang.Thread.run(Thread.java:833)
Caused by: org.spongepowered.asm.mixin.transformer.throwables.MixinTransformerError: An unexpected critical error was encountered
    at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:392)
    at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:234)
    at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClassBytes(MixinTransformer.java:202)
    at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:247)
    ... 10 more
Caused by: org.spongepowered.asm.mixin.injection.throwables.InjectionError: Critical injection failure: Callback method adjustExitPortalLocation(ZLorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;)V in mixins.protosky.json:EnderDragonFightMixin from mod protosky failed injection check, (0/1) succeeded. Scanned 1 target(s). Using refmap protosky-refmap.json
    at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.postInject(InjectionInfo.java:468)
    at org.spongepowered.asm.mixin.transformer.MixinTargetContext.applyInjections(MixinTargetContext.java:1385)
    at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyInjections(MixinApplicatorStandard.java:1052)
    at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyMixin(MixinApplicatorStandard.java:400)
    at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.apply(MixinApplicatorStandard.java:325)
    at org.spongepowered.asm.mixin.transformer.TargetClassContext.apply(TargetClassContext.java:421)
    at org.spongepowered.asm.mixin.transformer.TargetClassContext.applyMixins(TargetClassContext.java:403)
    at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:363)
    ... 13 more


A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- System Details --
Details:
    Minecraft Version: 1.18.2
    Minecraft Version ID: 1.18.2
    Operating System: Windows 11 (amd64) version 10.0
    Java Version: 17.0.2, Azul Systems, Inc.
    Java VM Version: OpenJDK 64-Bit Server VM (mixed mode, sharing), Azul Systems, Inc.
    Memory: 2137836432 bytes (2038 MiB) / 2579496960 bytes (2460 MiB) up to 4294967296 bytes (4096 MiB)
    CPUs: 24
    Processor Vendor: GenuineIntel
    Processor Name: 12th Gen Intel(R) Core(TM) i9-12900K
    Identifier: Intel64 Family 6 Model 151 Stepping 2
    Microarchitecture: unknown
    Frequency (GHz): 3.19
    Number of physical packages: 1
    Number of physical CPUs: 16
    Number of logical CPUs: 24
    Graphics card #0 name: NVIDIA GeForce RTX 3080 Ti
    Graphics card #0 vendor: NVIDIA (0x10de)
    Graphics card #0 VRAM (MB): 4095.00
    Graphics card #0 deviceId: 0x2208
    Graphics card #0 versionInfo: DriverVersion=30.0.14.7141
    Memory slot #0 capacity (MB): 16384.00
    Memory slot #0 clockSpeed (GHz): 4.80
    Memory slot #0 type: Unknown
    Memory slot #1 capacity (MB): 16384.00
    Memory slot #1 clockSpeed (GHz): 4.80
    Memory slot #1 type: Unknown
    Virtual memory max (MB): 37373.29
    Virtual memory used (MB): 17362.18
    Swap memory total (MB): 4864.00
    Swap memory used (MB): 2.96
    JVM Flags: 1 total; -Xmx4G
    Server Running: true
    Player Count: 0 / 20; []
    Data Packs: vanilla
    World Generation: Stable
    Is Modded: Definitely; Server brand changed to 'fabric'
    Type: Dedicated Server (map_server.txt)

Shipwreck bounding boxes are in the wrong spot and eyes of ender aren't filled into end portal frames correctly because ChunkRandom is not the same as vanilla

Randomness for structures is different between this mod and vanilla. Both this mod and vanilla are reproducible, but this mod's output is different.

There is only two structures that are affected by this: beached shipwrecks and end portals. Beached shipwrecks will be ±3 blocks vertically from vanilla. This is because they are randomly moved down while generating by a max of three blocks. See the third to last line of this function to see the vanilla code and here for the mod's code. This code looks different, but it will output the same thing if the randomness were to be corrected.

End portals will be not have the same eyes filled in as in vanilla, but they will still have the same probability of being filled and it will be repeatable. This function were it uses Random for the vanilla code and here for this mod's code

These issues aren't issues in my use of random. They are issues with the random getting passed to the mod's handlers being not the same as the ones passed to vanilla. I validate if the random is correct by breaking in the debugger and looking at the current seed of the rng. After a lot of debugging it seems to be match until here, but and not by here. The first one is looping through all structures and the second one is looping though all the found instances of that structure in the current chunk.

If this issue causes you a large enough problem that can't be solved by knowing what the issue is and how it behaves you may fix it. I was unable figure it with multiple days of trying so I have given up. Maybe a different pair of eyes will be able to figure it out.

1.19 support

Any ETA on when 1.19 will be supported?

I tried building from the current master branch but the dev jar didn't work on my server.

Crash when generating using a structure NBT file

Crash log: https://paste.ee/p/XapXy
Datapack used: Soaring Sky Data.zip

When trying to use a custom structure .nbt file to place down an island when generating a world, the game completely crashes upon first load and upon any further attempts to load the world. There are numerous errors along the lines of We are asking a region for a chunk out of bound, followed by either a chunk or region coordinate which is different depending on the structure I use. I've tried with various different structures, attached is the latest one.

Option to leave the End unchanged?

Is it possible to add such option?

Support for 1.16.3

Will there be support for 1.16.3? This is the last update for 1.16 so there will be many months before a new update happens.

Did you removed end cities?

I tried to find end city with world seed, but I didn't find any mob or item frame with elytra.

Ghost spawn ceiling

Worlds generated using this mod results in a 'ghost ceiling' being created at the height of what the original terrain is at, resulting in the highest spawnable block being significantly higher than the ones in the chunk, as seen in the image.

Upload 1.1.2 to curseforge

Exception on loading/creating map

Got this on crash report:

Click me

Description: Exception initializing level

java.lang.NoClassDefFoundError: net/minecraft/class_7924
at protosky.stuctures.StructureHelper.handleStructures(StructureHelper.java:358)
at net.minecraft.class_2806.handler$caf000$FEATURES(class_2806.java:559)
at net.minecraft.class_2806.method_20613(class_2806.java)
at net.minecraft.class_2806.method_12154(class_2806.java:292)
at net.minecraft.class_3898.method_17225(class_3898.java:679)
at com.mojang.datafixers.util.Either$Left.map(Either.java:38)
at net.minecraft.class_3898.method_17224(class_3898.java:673)
at java.base/java.util.concurrent.CompletableFuture$UniCompose.tryFire(CompletableFuture.java:1150)
at java.base/java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:482)
at net.minecraft.class_3900.method_17634(class_3900.java:62)
at net.minecraft.class_3846.method_16907(class_3846.java:91)
at net.minecraft.class_3846.method_16900(class_3846.java:146)
at net.minecraft.class_3846.run(class_3846.java:102)
at java.base/java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1395)
at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373)
at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182)
at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655)
at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622)
at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165)
Caused by: java.lang.ClassNotFoundException: net.minecraft.class_7924
... 19 more

A detailed walkthrough of the error, its code path and all known details is as follows:

-- Head --
Thread: Server thread
Stacktrace:
at protosky.stuctures.StructureHelper.handleStructures(StructureHelper.java:358)
at net.minecraft.class_2806.handler$caf000$FEATURES(class_2806.java:559)
at net.minecraft.class_2806.method_20613(class_2806.java)
at net.minecraft.class_2806.method_12154(class_2806.java:292)
at net.minecraft.class_3898.method_17225(class_3898.java:679)
at com.mojang.datafixers.util.Either$Left.map(Either.java:38)
at net.minecraft.class_3898.method_17224(class_3898.java:673)
at java.base/java.util.concurrent.CompletableFuture$UniCompose.tryFire(CompletableFuture.java:1150)
at java.base/java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:482)
at net.minecraft.class_3900.method_17634(class_3900.java:62)
at net.minecraft.class_3846.method_16907(class_3846.java:91)
at net.minecraft.class_3846.method_16900(class_3846.java:146)
at net.minecraft.class_3846.run(class_3846.java:102)

-- Affected level --
Details:
All players: 0 total; []
Chunk stats: 625
Level dimension: minecraft:overworld
Level spawn location: World: (168,64,-168), Section: (at 8,0,8 in 10,4,-11; chunk contains blocks 160,-64,-176 to 175,319,-161), Region: (0,-1; contains chunks 0,-32 to 31,-1, blocks 0,-64,-512 to 511,319,-1)
Level time: 0 game time, 0 day time
Level name: Skyblock
Level game mode: Game mode: survival (ID 0). Hardcore: false. Cheats: false
Level weather: Rain time: 0 (now: false), thunder time: 0 (now: false)
Known server brands: fabric
Level was modded: true
Level storage version: 0x04ABD - Anvil
Stacktrace:
at net.minecraft.server.MinecraftServer.method_3786(MinecraftServer.java:367)
at net.minecraft.server.MinecraftServer.method_3735(MinecraftServer.java:315)
at net.minecraft.class_1132.method_3823(class_1132.java:68)
at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:636)
at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:257)
at java.base/java.lang.Thread.run(Thread.java:833)

-- System Details --
Details:
Minecraft Version: 1.19.3
Minecraft Version ID: 1.19.3
Operating System: Windows 10 (amd64) version 10.0
Java Version: 17.0.3, Microsoft
Java VM Version: OpenJDK 64-Bit Server VM (mixed mode), Microsoft
Memory: 1622546720 bytes (1547 MiB) / 2147483648 bytes (2048 MiB) up to 2147483648 bytes (2048 MiB)
CPUs: 12
Processor Vendor: GenuineIntel
Processor Name: Intel(R) Xeon(R) CPU E5-2620 v2 @ 2.10GHz
Identifier: Intel64 Family 6 Model 62 Stepping 4
Microarchitecture: Ivy Bridge (Server)
Frequency (GHz): 2.10
Number of physical packages: 1
Number of physical CPUs: 6
Number of logical CPUs: 12
Graphics card #0 name: NVIDIA GeForce 9500 GT
Graphics card #0 vendor: NVIDIA (0x10de)
Graphics card #0 VRAM (MB): 1024.00
Graphics card #0 deviceId: 0x0640
Graphics card #0 versionInfo: DriverVersion=21.21.13.4201
Memory slot #0 capacity (MB): 2048.00
Memory slot #0 clockSpeed (GHz): 1.60
Memory slot #0 type: DDR3
Memory slot #1 capacity (MB): 8192.00
Memory slot #1 clockSpeed (GHz): 1.60
Memory slot #1 type: DDR3
Memory slot #2 capacity (MB): 2048.00
Memory slot #2 clockSpeed (GHz): 1.60
Memory slot #2 type: DDR3
Memory slot #3 capacity (MB): 8192.00
Memory slot #3 clockSpeed (GHz): 1.60
Memory slot #3 type: DDR3
Virtual memory max (MB): 28658.52
Virtual memory used (MB): 13300.88
Swap memory total (MB): 8192.00
Swap memory used (MB): 263.93
JVM Flags: 13 total; -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=32M -XX:+DisableExplicitGC -XX:+AlwaysPreTouch -XX:+ParallelRefProcEnabled -Xms2048M -Xmx2048M -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xss1M

Outdated Gradle

When I build with intellij, it seems to get through most of the process then exit with the following error:

Build file 'C:\Users\hatch\Documents\GitHub\ProtoSky\build.gradle' line: 2

An exception occurred applying plugin request [id: 'fabric-loom', version: '1.2-SNAPSHOT']

Failed to apply plugin 'fabric-loom'.
You are using an outdated version of Gradle (7.4). Gradle 8.1 or higher is required.

Try:

Run with --stacktrace option to get the stack trace.
Run with --info or --debug option to get more log output.
Run with --scan to get full insights.

The Gradle version seems to be something directly baked into this installation, not a program on my machine. Should I manually update it?

deadlymc / protosky Goto Github PK

protosky's People

Contributors

Stargazers

Watchers

Forkers

protosky's Issues

A detailed walkthrough of the error, its code path and all known details is as follows:

Recommend Projects

Recommend Topics

Recommend Org