deadalready / node-easy-config Goto Github PK

Hello,

Thanks for your module first.
It seems that i can't overrite the folder option using :

var config = require('easy-config').loadConfig({'folder': __dirname});
Is this right ?

I write in cmd node server.js and in cmd get

/node_modules/easy-config/lib/utils.js:26
Object.keys(obj).forEach(function (key) {
^
TypeError: Object.keys called on non-object
at Function.keys (native)

First off, great library -- I love it. Had some issues using the folder override from the command line. Added --folder=/home/user/workspace/config and it was still using the default. I inspected the code and found

config.js around line 187

// Overwrite settings from command line
    cmdLine.forEach(function (val) {
        if (val.charAt(0) === '-' && val.charAt(1) !== '-') {
            var tmp = val.substr(1).split('=');
            options[tmp[0]] = utils.typeCast(tmp[1]);
        }
    });

Which checks for a single -. The documentation says to use '--' to prefix the option, so I wasn't sure which was correct. I changed the !== to === and the substr(1) to substr(2), and it seemed to work well. But I wanted to write an issue report before I presumed what your intended behavior was. Thanks! Keep up the good work.

// Overwrite settings from command line
    cmdLine.forEach(function (val) {
        if (val.charAt(0) === '-' && val.charAt(1) === '-') {
            var tmp = val.substr(2).split('=');
            options[tmp[0]] = utils.typeCast(tmp[1]);
        }
    });