Add a Zurb Foundation Frontend Extra? about pagy HOT 7 CLOSED

Overall the integration looks like it should be a fairly simple task.

Indeed it should be very simple: you can start from the pagy_nav_bootstrap helper and just edit it (mostly the class names).

Which are the issues you ran into?

from pagy.

I just took another look at this. My first issue was with some malformed HTML, but I was able to resolve that.

I know I got a bit confused integrating Foundation's recommended screen reading content...into link.call I think. But that could probably be left off if needed.

Now my main issue is that my Previous and Next buttons are getting an arrow from Foundation and another from pagy_t (eg pagy_t('pagy.nav.next')). Should I just skip pagy_t here and hard code "Next" and "Previous"?

from pagy.

Hi @dwieringa, glad that you are making progress!

Indeed the pagy_t is getting the full string (including the chevron) from the I18n dictionary, and it looks like the Foundation CSS adds another one to it.

If it is just for your own use, you can skip the pagy_t, but if you are going to share it in an extra for everybody else (and I hope so), I think you should remove the class and use the original pagy_t that allows people to translate/change it by just changing the entry in the dictionary file.

Not sure whether that class adds something else that is important for the pagination style.

from pagy.

If that class is adding something important, and in case you want to start the foundation extra ;)... there is a third solution, which is adding a couple of extra entries in the dictionary file like pagy.nav.next_text_onlyand pagy.nav.prev_text_only, so you could use that in the helpers.

from pagy.

I just searched https://github.com/zurb/foundation-sites and it appears the pagination-previous and pagination-next classes only add the arrows, so for now, I'll alter my pagy extra to leave those off.

I'll plan on submitting a PR once I'm done with it. :)

from pagy.

I've submitted PR #79

I haven't looked at adding support for the compact or responsive extras yet.

from pagy.

Thank you!

from pagy.