Comments (7)
Overall the integration looks like it should be a fairly simple task.
Indeed it should be very simple: you can start from the pagy_nav_bootstrap
helper and just edit it (mostly the class names).
Which are the issues you ran into?
from pagy.
I just took another look at this. My first issue was with some malformed HTML, but I was able to resolve that.
I know I got a bit confused integrating Foundation's recommended screen reading content...into link.call
I think. But that could probably be left off if needed.
Now my main issue is that my Previous
and Next
buttons are getting an arrow from Foundation and another from pagy_t
(eg pagy_t('pagy.nav.next')
). Should I just skip pagy_t
here and hard code "Next" and "Previous"?
from pagy.
Hi @dwieringa, glad that you are making progress!
Indeed the pagy_t
is getting the full string (including the chevron) from the I18n dictionary, and it looks like the Foundation CSS adds another one to it.
If it is just for your own use, you can skip the pagy_t
, but if you are going to share it in an extra for everybody else (and I hope so), I think you should remove the class and use the original pagy_t
that allows people to translate/change it by just changing the entry in the dictionary file.
Not sure whether that class adds something else that is important for the pagination style.
from pagy.
If that class is adding something important, and in case you want to start the foundation
extra ;)... there is a third solution, which is adding a couple of extra entries in the dictionary file like pagy.nav.next_text_only
and pagy.nav.prev_text_only
, so you could use that in the helpers.
from pagy.
I just searched https://github.com/zurb/foundation-sites and it appears the pagination-previous
and pagination-next
classes only add the arrows, so for now, I'll alter my pagy extra to leave those off.
I'll plan on submitting a PR once I'm done with it. :)
from pagy.
I've submitted PR #79
I haven't looked at adding support for the compact
or responsive
extras yet.
from pagy.
Thank you!
from pagy.
Related Issues (20)
- Add ARIA attributes to foundation helpers
- Add ARIA attributes to materialize helpers
- Add ARIA attributes to semantic helper
- Add ARIA attributes to uikit helper
- Bug: pagy_search wrong number of arguments HOT 10
- Bug: Alias for an aggregate result is removed HOT 9
- Bug: Issue with Arel scope passed to pagy method HOT 3
- Docs: 7.0 has an undocumented breaking change for active page styling HOT 5
- Docs: Which branch should PRs be made against? HOT 3
- Docs: Update performance metrics HOT 5
- Trim doesn't call with pagy_nav_js when first page is active
- Bug: Adapt with Mongoid add extention HOT 1
- Bug: Pagy::Backend#pagy_get_vars `count_args` gets ignored HOT 3
- Docs: https://ddnexus.github.io/pagy/quick-start/#configure HOT 1
- Bug: Missing initializer in documentation HOT 1
- Bug: wrong number of arguments (given 2, expected 0) HOT 2
- Bug: wrong number of arguments (given 2, expected 0) HOT 1
- Bug: Pagy not working with Geocoder gem
- Bug: Undocumented backwards-incompatible change of empty "page" parameter introduced in 6.4.0 HOT 3
- Docs: lost section about wrap existing pagination with pagy_calendar HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pagy.