ddnet / ddnet7 Goto Github PK

View Code? Open in Web Editor NEW

6.0 5.0 7.0 72.56 MB

DDNet port to TW 0.7

License: Other

CMake 2.24% Python 4.48% Batchfile 0.01% C 12.11% Shell 0.01% C++ 79.95% Objective-C 1.13% Objective-C++ 0.08%

ddnet teeworlds

ddnet7's Introduction

Not updated anymore since we have 0.7 client support in DDNet: https://github.com/ddnet/ddnet

Old description:

DDNet work in progress for teeworlds version 0.7 (server only!)

ported by fokkonaut from https://github.com/ddnet/ddnet to the latest teeworlds base http://github.com/teeworlds/teeworlds

ddnet7's People

Contributors

Stargazers

Watchers

Forkers

chillerdragon fokkonaut lryjnks def- timakro trafilaw

ddnet7's Issues

Only best finishes will be written in the database

hey,

I saw that only the best finishes will be written in the database, normally it should all finishes written in the database ^^

https://i.imgur.com/VSIWCgj.png <-- Finish from Candy 89 sec on neverGores2
After I search it in the database, I didn't found it
https://i.imgur.com/HLUOjeO.png <-- This are only new records

~Law

need a script to convert 0.6 -> 0.7 maps

Having it in the client won't work while we're keeping 0.6 and 0.7 servers running: ddnet/ddnet#1910

Feature Missing: Vote Veto after 20 min

If I'm blind close this issue xd

Crash CServer::UpdateClientMapListEntries

Thread 1 "multimap_srv_d" received signal SIGSEGV, Segmentation fault.
0x00005555555a8cd1 in CServer::UpdateClientMapListEntries (this=0x7ffff62e9010) at /opt/twserver/git/ddnet7/src/engine/server/server.cpp:907
907					m_aClients[ClientID].m_pMapListEntryToSend = m_aClients[ClientID].m_pMapListEntryToSend->m_pNext;
#0  0x00005555555a8cd1 in CServer::UpdateClientMapListEntries (this=0x7ffff62e9010) at /opt/twserver/git/ddnet7/src/engine/server/server.cpp:907
#1  0x00005555555ac185 in CServer::Run (this=0x7ffff62e9010) at /opt/twserver/git/ddnet7/src/engine/server/server.cpp:1609
#2  0x00005555555af6fa in main (argc=2, argv=0x7fffffffe4e8) at /opt/twserver/git/ddnet7/src/engine/server/server.cpp:2386

Thread 1 "ddrace1_srv_d" received signal SIGSEGV, Segmentation fault.
0x00005555555a8cd1 in CServer::UpdateClientMapListEntries (this=0x7fff00000000) at /opt/twserver/git/ddnet7/src/engine/server/server.cpp:907
907					m_aClients[ClientID].m_pMapListEntryToSend = m_aClients[ClientID].m_pMapListEntryToSend->m_pNext;
#0  0x00005555555a8cd1 in CServer::UpdateClientMapListEntries (this=0x7fff00000000) at /opt/twserver/git/ddnet7/src/engine/server/server.cpp:907
#1  0x000cc2be5e442cf2 in ?? ()
#2  0x00007ffff62e9010 in ?? ()
#3  0x00000045f6c115e0 in ?? ()
#4  0x0000001200000005 in ?? ()
#5  0x00007fffffffe3a0 in ?? ()
#6  0x00005555555ac185 in CServer::Run (this=0x7fffffffdfe0) at /opt/twserver/git/ddnet7/src/engine/server/server.cpp:1609
#7  0x0000000000000000 in ?? ()

Crash in game/server/gamecontext.cpp:920 CPlayer::GetTeam() 0x0 segfault

Thread 1 "multimap_srv_d" received signal SIGSEGV, Segmentation fault.
0x00005555555d06d6 in CPlayer::GetTeam (this=0x0) at /opt/twserver/git/ddnet7/src/game/server/player.h:31
31		int GetTeam() const { return m_Team; };
#0  0x00005555555d06d6 in CPlayer::GetTeam (this=0x0) at /opt/twserver/git/ddnet7/src/game/server/player.h:31
#1  0x00005555555e00e4 in CGameContext::OnClientEnter (this=0x7ffff5ab7010, ClientID=7) at /opt/twserver/git/ddnet7/src/game/server/gamecontext.cpp:920
#2  0x00005555555a985e in CServer::ProcessClientPacket (this=0x7ffff62e8010, pPacket=0x7fffffffd8a0) at /opt/twserver/git/ddnet7/src/engine/server/server.cpp:1048
#3  0x00005555555ab212 in CServer::PumpNetwork (this=0x7ffff62e8010) at /opt/twserver/git/ddnet7/src/engine/server/server.cpp:1381
#4  0x00005555555ac23a in CServer::Run (this=0x7ffff62e8010) at /opt/twserver/git/ddnet7/src/engine/server/server.cpp:1619
#5  0x00005555555af75e in main (argc=2, argv=0x7fffffffe4a8) at /opt/twserver/git/ddnet7/src/engine/server/server.cpp:2386

No such command: sv_reset_file.

We'll need that for DDNet official servers.

specvoted and pausevoted dont work

Wrong time in spectate

If I spec a player, its shows the wrong time. Normally it should show the time of the player who I'm specing, but atm. its only my time or the time of the server ^^.

skipped invalid command 'random_map'

same with random_unfinished_map

Add anti spam commands

Hey,

we have the problem, that some of players abuse the commands with spam like this:
https://i.imgur.com/hafT2aN.png

Would be nice if there are a anti spam command

skipped invalid command 'info'

Needed as a dummy command in votes

Bullets on Bullets map go crazy

as reported by TEINI94:

Bullets novice map bullets go crazy * 0.7

top5 command not added to autocpmplete

need ddnet.tw/status support

https://github.com/ddnet/ddnet-scripts/blob/master/servers/scripts/teeworlds.py probably doesn't support the 64 player packets for 0.7, right?

Different cc/c++ versions

CMakeLists.txt check only checks C compiler works, but my C++ compiler has a different version, so different checks work.

maximum number of vote options reached

Need more votes on DDNet servers

On Kobra 3 on 0.7.4 servers the tune zone 1 setting hook_drag_accel -3 isn't working

reported by @konrad, confirmed moment ago

no team ranks top5team etc

no team ranks top5team etc

as reported by TEINI94

Red spawn does not work

Blue spawn probably as well. Maps like Hardstyle 3 only have red spawns and are thus unusable.

Remove cheats from production systems

Add TestDDraceNetwork and sv_test_cmds.

Remove tracking of whispers in logs!

The whisper function should be where private conversations take place. I've noticed that a lot of server admins of bigger servers like to read through the logs including the whispers.
Imo tracking them does nothing but undermine the privacy of the players.

Flappy Bird map not working properly?

As reported by TEINI94:

may just check out solo map flappy bird (u can finish it in 17sec if u know how) and

Travis CI fails

CMake Error at CMakeLists.txt:371 (message):

  You must install SDL2 to compile the DDNet client

-- Automatically downloading GTest to be able to run tests

-- Configuring done

-- Generating done

-- Build files have been written to: /Users/travis/build/ddnet/ddnet7/build_debug/googletest-download

Scanning dependencies of target googletest

[ 11%] Creating directories for 'googletest'

[ 22%] Performing download step (git clone) for 'googletest'

Cloning into 'googletest-src'...

Note: checking out 'release-1.8.1'.

You are in 'detached HEAD' state. You can look around, make experimental

changes and commit them, and you can discard any commits you make in this

state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may

do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at 2fe3bd99 Merge pull request #1433 from dsacre/fix-clang-warnings

[ 33%] No patch step for 'googletest'

[ 44%] Performing update step for 'googletest'

[ 55%] No configure step for 'googletest'

[ 66%] No build step for 'googletest'

[ 77%] No install step for 'googletest'

[ 88%] No test step for 'googletest'

[100%] Completed 'googletest'

[100%] Built target googletest

-- Looking for WavpackOpenFileInputEx

-- Looking for WavpackOpenFileInputEx - not found

-- Configuring incomplete, errors occurred!

See also "/Users/travis/build/ddnet/ddnet7/build_debug/CMakeFiles/CMakeOutput.log".

See also "/Users/travis/build/ddnet/ddnet7/build_debug/CMakeFiles/CMakeError.log".

The command "cmake -Werror=dev -DDOWNLOAD_GTEST=ON -DDEV=ON .." exited with 1.

0.02s$ make run_tests

make: *** No rule to make target `run_tests'.  Stop.

The command "make run_tests" exited with 2.

0.05s$ cd ../build

The command "cd ../build" exited with 0.

0.01s$ ./DDNet-Server shutdown

/Users/travis/.travis/functions: line 109: ./DDNet-Server: No such file or directory

The command "./DDNet-Server shutdown" exited with 127.

https://travis-ci.org/ddnet/ddnet7/builds/622053658

sv_team don't work in cfg & sv_kill_delay has no effect

If you try to change sv_team in cfg it don't work
And if you set sv_kill_delay to 1, it has no effect

~Law

Add sv_rcon_helper_password

Hey,

it would be awesome if not only Admin & Mod has permission to F2(rcon).
DDNet has the option too so I would like to use the option in DDNet7 -

Add /map command

Since the client vote search is currently buggy it should be a priority to fix searching a map at least from the server side.

Missing /r reply to whisper

Since ddnet uses the 0.7 vanilla whisper system it would make sense to also activate the /r reply command. But yikes it would be the same as /r as in rescue. Maybe use /c converse like in 0.6?

Crash in CPlayer::Tick (this=0x0) at game/server/player.cpp:124

[2020-02-19 13:46:18][register]: fetching server counts
[2020-02-19 13:46:18][register]: chose 'master4.teeworlds.com' as master, sending heartbeats
[2020-02-19 13:46:19][register]: no firewall/nat problems detected
[2020-02-19 13:46:19][register]: server registered
[2020-02-19 13:55:14][server]: player is ready. ClientID=0 addr=<{XXX.XXX.XXX.XXX:58642}>
[2020-02-19 13:55:15][server]: 'nameless' -> 'nameless'
[2020-02-19 13:55:17][server]: player has entered the game. ClientID=0 addr=<{XXX.XXX.XXX.XXX:58642}>
[2020-02-19 13:55:17][sql]: Getting best time done
[2020-02-19 13:55:17][server]: client dropped. cid=0 addr=<{unknown type 0}> reason='Error sending data'
[2020-02-19 13:55:17][game]: kill killer='0:0:nameless' victim='0:0:nameless' weapon=-3 special=0
Thread 1 "ddrace1_srv_d" received signal SIGSEGV, Segmentation fault.
0x00005555555ebd24 in CPlayer::IsDummy (this=0x0) at /opt/twserver/git/ddnet7/src/game/server/player.h:33
33		bool IsDummy() const { return m_Dummy; }
#0  0x00005555555ebd24 in CPlayer::IsDummy (this=0x0) at /opt/twserver/git/ddnet7/src/game/server/player.h:33
#1  0x00005555555f326e in CPlayer::Tick (this=0x0) at /opt/twserver/git/ddnet7/src/game/server/player.cpp:124
#2  0x00005555555de5ac in CGameContext::OnTick (this=0x7ffff5ab7010) at /opt/twserver/git/ddnet7/src/game/server/gamecontext.cpp:619
#3  0x00005555555ac193 in CServer::Run (this=0x7ffff62e8010) at /opt/twserver/git/ddnet7/src/engine/server/server.cpp:1599
#4  0x00005555555af75e in main (argc=2, argv=0x7fffffffe4d8) at /opt/twserver/git/ddnet7/src/engine/server/server.cpp:2386

Crash CServer::UpdateClientRconCommands

[2020-02-26 23:30:53][server]: player is ready. ClientID=0 addr=<{X.X.X.X:55722}>
[2020-02-26 23:30:53][server]: 'A' -> 'A'
[2020-02-26 23:30:53][server]: player has entered the game. ClientID=0 addr=<{X.X.X.X:55722}>
[2020-02-26 23:30:53][sql]: Getting best time done
[2020-02-26 23:30:53][server]: player is ready. ClientID=1 addr=<{X.X.X.X:56223}>
[2020-02-26 23:30:53][server]: 'X' -> 'X'
[2020-02-26 23:30:53][server]: player has entered the game. ClientID=1 addr=<{x.x.x.x:56223}>
[2020-02-26 23:30:53][sql]: Getting best time done
[2020-02-26 23:30:54][server]: client dropped. cid=0 addr=<{unknown type 0}> reason='Error sending data'
[2020-02-26 23:30:54][game]: kill killer='0:0:A' victim='0:0:A' weapon=-3 special=0

#0  0x00005555555a8a69 in CServer::UpdateClientRconCommands (this=0x7ffff62e8010) at /opt/twserver/git/ddnet7/src/engine/server/server.cpp:877
#1  0x00005555555ac1da in CServer::Run (this=0x7ffff62e8010) at /opt/twserver/git/ddnet7/src/engine/server/server.cpp:1608
#2  0x00005555555af75e in main (argc=2, argv=0x7fffffffe4d8) at /opt/twserver/git/ddnet7/src/engine/server/server.cpp:2386

Version number has to be encoded in SQL inserts

in race, teamrace, saves tables. Also don't allow loading save from other server kind. I propose versions 6 and 7, with all existing entries getting 6.

Crash on server start in network_server.cpp:287 (errornous client id)

It depends on some config option. I did not find out yet which exactly caused it.

[2020-02-11 12:56:02][engine]: running on unix-linux-amd64
[2020-02-11 12:56:02][engine]: arch is little endian
[2020-02-11 12:56:02][storage]: couldn't open storage.cfg
[2020-02-11 12:56:02][storage]: using standard paths
[2020-02-11 12:56:02][storage]: added path '$USERDIR' ('/home/chiller/.teeworlds')
[2020-02-11 12:56:02][storage]: added path '$DATADIR' ('/usr/share/games/teeworlds/data')
[2020-02-11 12:56:02][storage]: added path '$CURRENTDIR' ('/home/chiller/spamsrv-test')
[2020-02-11 12:56:02][storage]: added path '$APPDIR' ('./bin')
[2020-02-11 12:56:02][console]: executing 'autoexec.cfg'
[2020-02-11 12:56:02][console]: executing 'servers/8330.cfg'
[2020-02-11 12:56:02][console]: executing 'ddrace.cfg'
[2020-02-11 12:56:02][console]: No such command: sv_gametype.
[2020-02-11 12:56:02][assert]: /home/chiller/git/ddnet7/src/engine/shared/network_server.cpp(287): errornous client id

Seems like it is a auth issue since this appears in the logs when the assert is removed:

[2020-02-11 12:52:35][server]: ClientID=0 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=1 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=2 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=3 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=4 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=5 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=6 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=7 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=8 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=9 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=10 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=11 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=12 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=13 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=14 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=15 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=16 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=17 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=18 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=19 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=20 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=21 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=22 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=23 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=24 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=25 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=26 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=27 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=28 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=29 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=30 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=31 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=32 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=33 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=34 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=35 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=36 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=37 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=38 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=39 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=40 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=41 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=42 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=43 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=44 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=45 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=46 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=47 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=48 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=49 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=50 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=51 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=52 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=53 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=54 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=55 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=56 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=57 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=58 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=59 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=60 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=61 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=62 with key=(null) logged out by key removal
[2020-02-11 12:52:35][server]: ClientID=63 with key=(null) logged out by key removal

UPDATE:

The issue is caused by this config:

sv_rcon_password "foo"
sv_rcon_password "bar"

Setting votes config breaks sv_player_slots

sv_vote_kick "0"
sv_vote_spectate "0"
sv_vote_kick "1"
sv_vote_spectate "1"

With at least one of these two settings passed to the server on start up no matter if turned on or off it will cause trouble. It is not possible to add the server to favorites and the server thinks it has 0 slots (sv_player_slots gets set to 0) and thus the client can not change the team. The whole server info message seems to be broken. It has to be in config seems like setting it on the admin console while the server is running is fine.

$ valgrind --leak-check=full -v --track-origins=yes ./DDNet7-Server "sv_vote_kick 0"
[...]
[2020-02-28 11:02:50][XXXXXXXXXXXx]: 64 0
==8459== Conditional jump or move depends on uninitialised value(s)
==8459==    at 0x1857E0: CGameContext::OnInit() (gamecontext.cpp:2326)
==8459==    by 0x14F98D: CServer::Run() (server.cpp:1513)
==8459==    by 0x1534B1: main (server.cpp:2386)
==8459==  Uninitialised value was created by a heap allocation
==8459==    at 0x4835DEF: operator new(unsigned long) (vg_replace_malloc.c:334)
==8459==    by 0x152FD0: CreateServer() (server.cpp:2295)
==8459==    by 0x1530CA: main (server.cpp:2326)
==8459== 
[2020-02-28 11:02:50][server]: version 0.7 802f1be60a05665f
[2020-02-28 11:02:50][server]: +-------------------------+
[2020-02-28 11:02:50][server]: | rcon password: 'fBSaNK' |
[2020-02-28 11:02:50][server]: +-------------------------+
[2020-02-28 11:02:50][engine/mastersrv]: refreshing master server addresses
[2020-02-28 11:02:50][register]: refreshing ip addresses
--8459-- Reading syms from /lib/x86_64-linux-gnu/libnss_mdns4_minimal.so.2
--8459--    object doesn't have a symbol table
--8459-- Reading syms from /lib/x86_64-linux-gnu/libresolv-2.28.so
--8459--   Considering /usr/lib/debug/.build-id/02/6c3ba167f64f631eb8781fca2269fbc2ee7ca5.debug ..
--8459--   .. build-id is valid
--8459-- Reading syms from /lib/x86_64-linux-gnu/libnss_dns-2.28.so
--8459--   Considering /usr/lib/debug/.build-id/bb/8b756d3859e8fe20d7aa6d8255f27942589f47.debug ..
--8459--   .. build-id is valid
[2020-02-28 11:02:50][engine/mastersrv]: saving addresses
[2020-02-28 11:02:50][register]: fetching server counts
[2020-02-28 11:02:50][register]: chose 'master2.teeworlds.com' as master, sending heartbeats

$ valgrind --leak-check=full -v --track-origins=yes ./DDNet7-Server
[2020-02-28 11:02:32][XXXXXXXXXXXx]: 64 64
[2020-02-28 11:02:32][server]: version 0.7 802f1be60a05665f
[2020-02-28 11:02:32][server]: +-------------------------+
[2020-02-28 11:02:32][server]: | rcon password: 'c2dWXd' |
[2020-02-28 11:02:32][server]: +-------------------------+
[2020-02-28 11:02:32][engine/mastersrv]: refreshing master server addresses
[2020-02-28 11:02:32][register]: refreshing ip addresses
--8407-- Reading syms from /lib/x86_64-linux-gnu/libnss_mdns4_minimal.so.2
--8407--    object doesn't have a symbol table
--8407-- Reading syms from /lib/x86_64-linux-gnu/libresolv-2.28.so
--8407--   Considering /usr/lib/debug/.build-id/02/6c3ba167f64f631eb8781fca2269fbc2ee7ca5.debug ..
--8407--   .. build-id is valid
--8407-- Reading syms from /lib/x86_64-linux-gnu/libnss_dns-2.28.so
--8407--   Considering /usr/lib/debug/.build-id/bb/8b756d3859e8fe20d7aa6d8255f27942589f47.debug ..
--8407--   .. build-id is valid
[2020-02-28 11:02:32][engine/mastersrv]: saving addresses
[2020-02-28 11:02:32][register]: fetching server counts
[2020-02-28 11:02:32][register]: chose 'master1.teeworlds.com' as master, sending heartbeats

void CGameContext::OnInit()
{
	// [...]
	// clamp sv_player_slots to 0..MaxClients
	dbg_msg("XXXXXXXXXXXx", "%d %d", Server()->MaxClients(), g_Config.m_SvPlayerSlots);
	if(Server()->MaxClients() < g_Config.m_SvPlayerSlots)
		g_Config.m_SvPlayerSlots = Server()->MaxClients();

#ifdef CONF_DEBUG
	// clamp dbg_dummies to 0..MaxClients-1
	if(Server()->MaxClients() <= g_Config.m_DbgDummies)
		g_Config.m_DbgDummies = Server()->MaxClients();
	if(g_Config.m_DbgDummies)
	{
		for(int i = 0; i < g_Config.m_DbgDummies ; i++)
			OnClientConnected(Server()->MaxClients() -i-1, true, false);
	}
#endif
}

Seems like since 078bf54 the ConchainSettingUpdate attached to sv_vote_kick. sv_vote_kick_min and sv_vote_spectate sets sv_player_slots to the value of CNetServer::m_MaxClients which is set in the CServer::Run function. But CGameContext::OnConsoleInit is called from CServer::main()->CServer::RegisterCommands()->m_pGameServer->OnConsoleInit() already.

before 078bf54:

CServer::main()
CServer::Run()
  CNetServer::Open()
    CNetServer::m_MaxClients = g_Config.m_SvPlayerSlots
  CGamecontext::OnInit()
    g_Config.m_SvPlayerSlots = CNetServer::m_MaxClients

after 078bf54:

CServer::main()
  CServer::RegisterCommands()
    CServer::OnConsoleInit()
      CGameContext::OnConsoleInit()
         g_Config.m_SvPlayerSlots = CNetServer::m_MaxClients
CServer::Run()
  CNetServer::Open()
    CNetServer::m_MaxClients = g_Config.m_SvPlayerSlots
  CGamecontext::OnInit()

sv_map_vote in cfg don't work

Hey,

if you try to add sv_map_vote 0 it doesn't work, its everytime 1.

~Law

Teamranks do not get saved

Requesting existing /top5team or /rankteam works but new ones do not get saved.

too weak connection: out of buffer

On Vanilla client when voting for a different server type, noticed on far away servers like Chile.

Save broken

TODO: translate
discord report:
Bei save und load läuft die zeit weiter wenn man /save hat. Also Nach load ist dann time added die man weg war. Kann man das fixen?

LoadMapSettings crash

Nullpointer access:

(gdb) bt
#0  __strlen_sse2 () at ../sysdeps/x86_64/multiarch/../strlen.S:120
#1  0x0000556e5ee1ba5d in str_length (str=str@entry=0x0) at /home/teeworlds/src7/master/src/base/system.c:1833
#2  0x0000556e5edca5c0 in CGameContext::LoadMapSettings (this=this@entry=0x7fd802d31010)
    at /home/teeworlds/src7/master/src/game/server/gamecontext.cpp:2355
#3  0x0000556e5edcac8d in CGameContext::OnInit (this=0x7fd802d31010)
    at /home/teeworlds/src7/master/src/game/server/gamecontext.cpp:1959
#4  0x0000556e5edab028 in CServer::Run (this=0x7fd803562010)
    at /home/teeworlds/src7/master/src/engine/server/server.h:82
#5  0x0000556e5eda46d9 in main (argc=3, argv=0x7fff3e395898)
    at /home/teeworlds/src7/master/src/engine/server/server.cpp:1979

Add telegun grenade and laser

While working on /save I realized those are not defined

CCharacterCore::m_HasTelegunGun
CCharacterCore::m_HasTelegunGrenade
CCharacterCore::m_HasTelegunLaser

maps using this feature are probably not finishable right now.

Lots of crashes in gameworld.h:42

Core was generated by `./DDNet7-Server -f servers/9304.cfg'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x000055d5377fd8f2 in CProjectile::CProjectile (this=0x55d538fb2950, pGameWorld=<optimized out>, Type=2, 
    Owner=-1, Pos=..., Dir=..., Span=-2, Freeze=<optimized out>, Explosive=false, Force=0, SoundImpact=6, Layer=0, 
    Number=0) at /home/teeworlds/src7/master/src/game/server/gameworld.h:42
42		class CGameContext *GameServer() { return m_pGameServer; }
[Current thread is 1 (Thread 0x7fa6cb3bf980 (LWP 18682))]
(gdb) bt
#0  0x000055d5377fd8f2 in CProjectile::CProjectile (this=0x55d538fb2950, pGameWorld=<optimized out>, Type=2, 
    Owner=-1, Pos=..., Dir=..., Span=-2, Freeze=<optimized out>, Explosive=false, Force=0, SoundImpact=6, Layer=0, 
    Number=0) at /home/teeworlds/src7/master/src/game/server/gameworld.h:42
#1  0x000055d53780bd00 in IGameController::OnEntity (this=0x55d538ff4170, Index=34, Pos=..., Layer=0, 
    Flags=<optimized out>, Number=0) at /home/teeworlds/src7/master/src/game/server/entity.h:17
#2  0x000055d537805659 in CGameContext::OnInit (this=0x7fa6ca202010)
    at /home/teeworlds/src7/master/src/game/server/gamecontext.cpp:2213
#3  0x000055d5377e4819 in CServer::Run (this=0x7fa6caa33010)
    at /home/teeworlds/src7/master/src/engine/server/server.h:83
#4  0x000055d5377dbd4e in main (argc=3, argv=0x7fff0c84bf48)
    at /home/teeworlds/src7/master/src/engine/server/server.cpp:2386

Seems to happen a lot on all DDNet7 servers.

failing to load client textures

[2019-11-28 13:49:49][client]: loaded map 'heavens'
[2019-11-28 13:49:49][datafile]: loading data index=0 size=10 uncompressed=10
[2019-11-28 13:49:49][game/png]: failed to open file. filename='mapres/bg_clou.png'
[2019-11-28 13:49:49][datafile]: loading data index=1 size=10 uncompressed=10
[2019-11-28 13:49:49][game/png]: failed to open file. filename='mapres/bg_clou.png'
[2019-11-28 13:49:49][datafile]: loading data index=2 size=10 uncompressed=10
[2019-11-28 13:49:49][game/png]: failed to open file. filename='mapres/bg_clou.png'
[2019-11-28 13:49:49][datafile]: loading data index=3 size=4 uncompressed=4
[2019-11-28 13:49:49][game/png]: failed to open file. filename='mapres/s�x<�.png'

No more log file being written

I updated the servers 3 days ago. No more log files are written since then. even though "logfile servers/9303.log" is set.

sv_vote_map_delay has no effect

Unpredictable behaviour when holding input and hitting an unfreeze

Holding hook while frozen and hitting an unfreeze sometimes doesn't trigger a hook. I don't know what determins it. Also unfreezes right above a freezetiles on the ground are buggy as well. Even with small speed holding jump won't always yield in a jump after the unfreeze and you just fall through. This is quite heavily impacting gameplay. :(

I attached a screen of a part that I failed 2/3 times even though I held jump and had 5 tiles down speed at max. So a jump should always register there.

Core was generated by `./DDNet7-Server -f servers/9304.cfg'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  CCharacter::HandleTiles (this=this@entry=0x5570b89f6d48 <ms_PoolDataCCharacter+5160>, Index=92213)
    at /home/teeworlds/src7/master/src/game/server/entities/character.cpp:1506
1506		if (((m_TileIndex == TILE_TELE_GUN_ENABLE) || (m_TileFIndex == TILE_TELE_GUN_ENABLE)) && !m_HasTeleGun)
[Current thread is 1 (Thread 0x7f76d957d980 (LWP 27720))]
(gdb) bt
#0  CCharacter::HandleTiles (this=this@entry=0x5570b89f6d48 <ms_PoolDataCCharacter+5160>, Index=92213)
    at /home/teeworlds/src7/master/src/game/server/entities/character.cpp:1506
#1  0x00005570b894520b in CCharacter::DDracePostCoreTick (this=0x5570b89f6d48 <ms_PoolDataCCharacter+5160>)
    at /home/teeworlds/src7/master/src/game/server/entities/character.cpp:1985
#2  0x00005570b89455a6 in CCharacter::Tick (this=0x5570b89f6d48 <ms_PoolDataCCharacter+5160>)
    at /home/teeworlds/src7/master/src/game/server/entities/character.cpp:747
#3  CCharacter::Tick (this=0x5570b89f6d48 <ms_PoolDataCCharacter+5160>)
    at /home/teeworlds/src7/master/src/game/server/entities/character.cpp:734
#4  0x00005570b895a30d in CGameWorld::Tick (this=this@entry=0x7f76d83cfc30)
    at /home/teeworlds/src7/master/src/game/server/gameworld.cpp:174
#5  0x00005570b8954552 in CGameContext::OnTick (this=0x7f76d83c1010)
    at /home/teeworlds/src7/master/src/game/server/gamecontext.cpp:581
#6  0x00005570b89318f5 in CServer::Run (this=0x7f76d8bf2010)
    at /home/teeworlds/src7/master/src/engine/server/server.h:82
#7  0x00005570b892acec in main (argc=3, argv=0x7fff1434c418)
    at /home/teeworlds/src7/master/src/engine/server/server.cpp:2000

Looks like a player disconnected at the same time, so it was probably deleted:

[2020-01-10 03:46:48][server]: player is ready. ClientID=9 addr=X:51237
[2020-01-10 03:46:48][server]: 'Seeba' -> 'Seeba'
[2020-01-10 03:46:49][server]: player has entered the game. ClientID=9 addr=X:51237
[2020-01-10 03:46:49][sql]: Getting best time done 
[2020-01-10 03:47:07][chat-command]: 1 used /pause
[2020-01-10 03:47:08][chat-command]: 1 used /pause
[2020-01-10 03:47:08][whisper]: 0:3:maría ester: soy sola tuyaa miamor
[2020-01-10 03:47:13][whisper]: 1:3:ʑɑяηɑђ: te amo bb
[2020-01-10 03:47:19][whisper]: 0:3:maría ester: te amo más
[2020-01-10 03:47:21][chat]: 2:1:Meta: lel
[2020-01-10 03:47:22][chat]: 3:1:вlυeвerry: Y AHORA?
[2020-01-10 03:47:23][chat]: 2:1:Meta: xdddddddddd
[2020-01-10 03:47:25][chat-command]: 3 used /spec
[2020-01-10 03:47:26][chat-command]: 2 used /spec
[2020-01-10 03:47:34][chat]: 3:1:вlυeвerry: no entiendo nada 
[2020-01-10 03:47:35][chat-command]: 3 used /spec
[2020-01-10 03:47:37][server]: client dropped. cid=3 addr=unknown type 0 reason='Error sending data'
[2020-01-10 03:47:37][game]: kill killer='3:0:вlυeвerry' victim='3:0:вlυeвerry' weapon=-3 special=0

Happened on Chile, will keep the core file in case we need to look closer.

Spectators aren't allowed to vote (/pause)

Paused players should be able to call a vote.

ddnet / ddnet7 Goto Github PK

ddnet7's Introduction

ddnet7's People

Contributors

Stargazers

Watchers

Forkers

ddnet7's Issues

Recommend Projects

Recommend Topics

Recommend Org