dddshelf / ddd Goto Github PK

I'm confused about why EventStore is placed in Ddd\Application instead of Ddd\Domain. The interface is referenced by Ddd\Domain\PersistDomainEventSubscriber. This shouldn't be allowed because you don't want dependencies from the Domain namespace on the Application namespace. (I think?)

Or the class PersistDomainEventSubscriber should also be moved to Ddd\Application.

In 6.6.1 you have a definition of the class StoredEvent

There is a property in the class, that do not has an implementation

First of all I want to thank you boys for your job. I bought your e-book and find it useful.

Event's occurredOn attributes types should be immutable, but StoredEvent's occurredOn is mutable because of DateTime type.
https://github.com/dddinphp/ddd/blob/master/src/Domain/Event/StoredEvent.php#L34

Especially last-wishes app fires Event with DateTimeImmutable type - inconsistency that throws Exception.
https://github.com/bystro/last-wishes/blob/master/src/Lw/Domain/Model/User/UserRegistered.php#L19

Boys are you open for a PR? I can make some job.

Currently, CI is failing with error rbenv: version '5.4' not installed.

Hi,
can you suggest me how can I subscribe PersistDomainEventSubscriber globally on Symfony 3?

For now I have registered this two services:

  event.repository:
    class: Messenger\Infrastructure\Application\Notification\DoctrineEventStoreRepository
    factory: ['@doctrine', getRepository]
    arguments: ['Messenger\Domain\Event\StoredEvent']

  event.publisher:
    class: Messenger\Domain\DomainEventPublisher
    factory: ['Messenger\Domain\DomainEventPublisher', instance]

but I don't understand how (and where) can I subscribe my subscribers

Thanks

In the class Ddd\Infrastructure\Application\Notification\DoctrinePublishedMessageTracker on line 18 the code should be replaced with: $messageTracked = $this->findOneBy(array('typeName'=>$aTypeName), array('trackerId'=>'DESC')); in order to return the last PublishedMessageId