dbeurle / spkrd Goto Github PK

The list of crossover parameters do not currently allow selection and modification. This is a bug from the GTK2 to GTK3 port and needs to be fixed ASAP.

The ported enclosure design enclosure alignments need to be added:

• Butterworth
• Bessel
• Butterworth Inter-Order

alongside the volume, port length and diameter calculations.

The crossover filter drop downs should not include drivers that are not suitable for the filter (i.e. a woofer with a high pass filter).

Need to setup CI to run these tests automatically on push.

Hi!

I tried to build it in OSX (High Sierra). I got this error:

cmake .. && cmake --build .
CMake Error at /usr/local/Cellar/cmake/3.17.2/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:164 (message): Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE) Call Stack (most recent call first): /usr/local/Cellar/cmake/3.17.2/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:445 (_FPHSA_FAILURE_MESSAGE) /usr/local/Cellar/cmake/3.17.2/share/cmake/Modules/FindPkgConfig.cmake:45 (find_package_handle_standard_args) CMakeLists.txt:10 (find_package)

It was looking for libXml2, I have installed the package with brew but still the same error.

Do you have any suggestion.

Thanks in advance,
XL

The old GTK2 code should be ported to GTK3. A reduction in functionality may occur until all the remaining code is switched across.

JSON files would be easier to use than the XML input file. The current XML does not play that nicely with modern C++ and would make it easier to test the backend code.

We should put everything under the spkrd namespace to avoid name collisions and help organise the code.

With Gtk::make_managed<>() it should be possible to completely remove any manual memory management from the code. This would remove several memory leaks that are currently in the code.

There are multiple words for the same object. Let's go with

• Enclosure for the driver and crossover housing
• Driver for the cone and magnet structure
• Crossover for the electronic network

The old frequency response is left uncleared and accumulates the total frequency response when a new frequency response is added. We have a few options:

• Clear history on each pass
  • Easy to implement
  • Difficult to compare changes
• Keep history of each
  • Add legend to match plots to cross-over design
  • Easy to revert
  • Easy to compare
  • Additional implementation effort

The graph extends beyond 20kHz which is not required to design purposes. Expected between 20Hz and 20kHz.