Giter Club home page Giter Club logo

haring's People

Contributors

chrisdhaan avatar coeur avatar davidlari avatar hengyu avatar ivanbruel avatar kevincador avatar zmian avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

haring's Issues

Code regex doesn't handle complex markdown

For example:

If I'm trying to write this:

*bold*

For my instruction, but Haring handles this string as

*bold`*`

So it ignores second comment block.

To clarify, Haring ignores such construction too:

bold*

I tried to fix it in open class MarkdownCode, but it seems I can't handle it.

Can't get email link to work

Hi,

First of all, thanks for keeping MarkdownKit alive with this project. I'm almost finished making my first app and I'm using Haring for the About section.

Unfortunately, I haven't been able to get email links to work. Neither [Mail]([email protected]) nor [Mail](mailto:[email protected]) nor [Mail](message://[email protected]) are working. Just writing the email address still converts it to a link, but tapping it still doesn't do anything. A long press opens the Open/Copy/Share menu, but even then "Open" doesn't do anything.

Am I doing something wrong or is this a bug?

Thanks!

Link/Code text colour doesn't work

Setting the colour attribute for Link/Code doesn't work:

To recreate just add the following code to example project in Exemple2ViewController:

markdownParser.link.color = UIColor.red
markdownParser.code.color = UIColor.red

Showing "\002a" for "\\*"

Hello,
I've found an issue when I switched from "MarkdownKit".
"\002a" is showing instead of "\*".
This issue is caused by this line:
guard count > 4 else { return nil }
in String extension class func unescapeUTF16() -> String?
Is this necessary or can just remove the guard?
Would please take care of this?

Thanks

MarkdownHeader pattern also consumes hashtags

If you have text like "#hashtag\n# Header", both will be treated as a header. Since there's no space after the # in #hashtag, it shouldn't be processed into a header.

It would be nice if either the pattern was not fileprivate so consumers of the framework could change the behavior, or if the pattern in line 13 were changed to

fileprivate static let regex = "^(#{1,%@} \\s*(.+)$" # add space before \\s

Here's a reference to a similar issue and its resolution: markedjs/marked#201

Co-maintainers

The project from which this one is derived only had one maintainer, who then apparently abandoned it. To protect this project from the same fate, I'd like to have at least one co-maintainer who could continue it should I get hit by a bus. Interested persons, please reply.

haring 2.1 not building

attempting to update my packages, I'm getting the following error:

	Task failed with exit code 65:
	/usr/bin/xcrun xcodebuild -workspace 
/Users/jakeflaten/Dev/TheOther98iOS/Carthage/Checkouts/Haring/Example/Haring.xcworkspace -
scheme Haring -configuration Release -derivedDataPath 
/Users/jakeflaten/Library/Caches/org.carthage.CarthageKit/DerivedData/9.4.1_9F2000/Haring/2.1 -sdk 
iphoneos ONLY_ACTIVE_ARCH=NO CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= 
CARTHAGE=YES archive -archivePath /var/folders/my/fd8x03nn5rl65hpxlgb1q_v00000gn/T/Haring 
SKIP_INSTALL=YES GCC_INSTRUMENT_PROGRAM_FLOW_ARCS=NO 
CLANG_ENABLE_CODE_COVERAGE=NO STRIP_INSTALLED_PRODUCT=NO (launched in 
/Users/jakeflaten/Dev/TheOther98iOS/Carthage/Checkouts/Haring)

This usually indicates that project itself failed to compile. Please check the xcodebuild log for more details: /var/folders/my/fd8x03nn5rl65hpxlgb1q_v00000gn/T/carthage-xcodebuild.LEtzUD.log

if I set my cartfile to github "davidlari/Haring" == 2.0.8 the project builds
I havent updated to xcode 10 yet, i will report back and let you know if that works

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.