davidherney / moodle-format_onetopic Goto Github PK

styles.css are compiled and included site wide so
each selector should have a plugin unique identifier like .format-onetopic
is there a reason the new style rules do not?

Hello,

There is a bug in format_onetopic (san juan
2018010604) tested with Moodle 3.5.3 (Build: 20181112)

When you restrict a whole tab for a spesific group f.ex group1 and change your role to student as an teacher or administrator your browser displays an error "This page isn’t working http://nnnnn.nnnn redirected you too many times." and you cannot open Moodle unless you close your browser or clear cookies.

I belive this is because teacher doesn't belong to group 1 and plugin doesn't inherit any rights from the "parent" role (teacher/administrator) when chancing role.

The plugin should display error message f.ex. "you do not belong to group 1 so you cannot see this tab" or something, right now whole Moodle is being "replaced" with this error message and you cannot open Moodle anymore unless you close the whole browser or clear cookies from Moodle.

Steps to repeat:

0. Create group called group1
1. Restrict a tab for group1
2. Open this tab as a teacher or administrator
3. Change your role to student
4. See the problem

Hello,

at the moment any child tabs remains in the same position (under same parent topic location) if you move the parent tab with "Tabs edition utilities" and "Move current topic"

In my opinion child tabs should move with parent tabs because it requires lots of work to move every child tab manually if you have 20 of them.

Hello,

If you have images in course description they are not copied when you duplicate a tab.

URL changes as follows

before
http://moodle/33x/pluginfile.php/802/course/section/271/galleon.png
after
http://moodle/33x/pluginfile.php/802/course/section/390/galleon.png

Hi,

SUMMARY
If a new section is created and is moved as sub section of a section, all the following sections are renumbered. The previously made links are not targeting the right section anymore.

FAILED SOLUTION
In normal course format it is possible to use manually created anchors in the page... But they don't work here because Onetopic needs the section number in the url.

Best regards

Hello,

will this plugin support Moodle 3.9?

Hello,

by default topic 0 is in italic like Topic 0 Can you make it optional so that we can have it without styling if we want? The same style that Topic 1, Topic 2 etc. has.

Hello,

We tried to upgrade onetopic to version 3.3 but it failed with error;

PHP Fatal error: Call to undefined function format_topics_upgrade_hide_extra_sections() in /var/www/xxxx/course/format/onetopic/db/upgradelib.php on line 72

When in editing mode, if I delete a section 'Topic 5' for example, I will then be prompted to confirm the action, I click yes, I am then presented with the error displayed below - Moodle 3.1.4 and 3.1.5 has the same result.

If I click on continue it will send me to the home page, I will then have to logout and login again to not get that error message again when re-visiting the course, this occurs with any course new or old.
I wanted to find out if this error can be replicated and if the issue can be looked in to or it could just be an issue with our Moodle setup. Thanks for your time

Hello,

If you delete a section/tab in Onetopic everything is lost because the plugin doesn't support Moodle recycle bin;

https://docs.moodle.org/35/en/Recycle_bin

Could you make it so that a deleted section and its contents would go the recycle bin instead of instant permanent deletion?

Hello,

Are you planning to support Moodle 3.5? It's soon here and it's LTS version. @davidherney

When testing on Moodle 3.2 Boost theme, this format seems to be displaying the html structure as the title of each tab, caused by a problem with additional doublequote (and possibly other) characters. The text inside of the first tab shows as:

"<div style="" class="tab_content marker "><span>Topic 0</span></div>"

The anchor tag is being rendered as:

<a class="nav-link active " title="Topic" 0="" id="yui_3_17_2_1_1485987452297_35"><div style="" class="tab_content marker "><span>Topic 0</span></div></a>

If you edit the structure of the anchor tag, it displays properly:

<a class="nav-link active " title="Topic 0" id="yui_3_17_2_1_1485987452297_35"><div style="" class="tab_content marker "><span>Topic 0</span></div></a>

Seems that OneTopic format blocks creation of an Announcements forum when a new course is created. Am I missing something?

it would be nice if you could move several items (activities and materials) between tabs at once.

Tested with Moodle 3.3 and san juan (2018010604) & san juan (2018010602)

Hello,

I have a course that has multiple tabs which some of are hidden. If as a student I open the course and click the 0 tab (which is shown as a tab) it gives an error:

"Sorry, but you do not currently have permissions to do that (View hidden sections)"
Debug info:
Error code: nopermissions
Stack trace: •line 788 of /lib/accesslib.php: required_capability_exception thrown
•line 116 of /course/view.php: call to require_capability()

And if I click Continue nothing happens.

Only when I close the browser and open the course it works again. Also all activities on every tab are hidden from the student even when I have activities visible to students. And lastly If I open any other tab first than the 0 tab the course and tab 0 works normally.

Our users don't understand that "asynchronous edit actions" enables them to move resources between tabs. Please rename it to "Move resources between tabs" and the corresponding link to "Enable".

Thank you so much!

When you copy a set of courses from last year or so, you can inherit course format oneTopic but not the settings like the one to choose to show section zero as a tab.
Is it possible to create a settings page for that?

In San Juan we are getting errors when duplicating the last section/topic. Its fine for all other sections but if there is on last section it errors as follows in Moodle 3.3.4+
Debug info: SELECT * FROM {course} WHERE id IS NULL
[array (
)]
Error code: invalidrecord
Stack trace:
• line 1533 of /lib/dml/moodle_database.php: dml_missing_record_exception thrown
• line 1509 of /lib/dml/moodle_database.php: call to moodle_database->get_record_select()
• line 588 of /lib/datalib.php: call to moodle_database->get_record()
• line 443 of /lib/modinfolib.php: call to get_course()
• line 412 of /lib/modinfolib.php: call to course_modinfo->__construct()
• line 2095 of /lib/modinfolib.php: call to course_modinfo::instance()
• line 896 of /course/lib.php: call to get_fast_modinfo()
• line 939 of /course/lib.php: call to course_create_sections_if_missing()
• line 1882 of /course/lib.php: call to course_add_cm_to_section()
• line 132 of /course/format/onetopic/duplicate.php: call to moveto_module()
Regards,
Yvonne

This isn't exactly an 'issue', but I use docker to build my Moodle server, and I fetch the latest version of plugins via their git repositories. I notice that the latest version in this repository is one release behind the version in the Moodle plugins directory - is there any chance you can commit version 2018010608 to this repository?

Moodle: Moodle 3.5 (Build: 20180517)
onetopic: 2018010604
Theme tested: boost , fordson and moove

if a topic has access restriction in the onetopic format is not displayed

See:
to access topic 5 the student should complete the poll (name: enquete)

but student does not visualize the restriction and does not have access to the topic

and at the end the link to the top topic (topic 5)

if the format of the course is the Topics or buttom for example the topic 5 is displayed with the access restrictions

Format: Button

Format: Topic

Hello,

Onetopic doesn't log when a user deletes an section with the minus-sign to the Moodle log, could you add this?

Hello,

I would like to see an feature where you can use drag&drop to change topic position.

The version for Moodle 3.0 (2016020501) now has

$PAGE->requires->js('/course/format/onetopic/format.js');

on line 100 however format.js does not appear to be included in this branch and throws error:

"Coding error detected, it must be fixed by a programmer: Attempt to require a JavaScript file that does not exist."

Debug info: /course/format/onetopic/format.js
Error code: codingerror
Stack trace:
line 699 of \lib\outputrequirementslib.php: coding_exception thrown
line 422 of \lib\outputrequirementslib.php: call to page_requirements_manager->js_fix_url()
line 100 of \course\format\onetopic\format.php: call to page_requirements_manager->js()
line 280 of \course\view.php: call to require()

Hello,

We use Onetopic format with parent and child sections.
When we hide a parent section from students, we expect that its child tabs become hidden as well.
This is, however, not true: if a parent section is hidden, the students see its child tabs as child tabs of the previous parent section.

As a workaround, we are hiding each of the tabs in a nest: the parent tab and all its child tabs. But it can be very easy to overlook this and inadvertently leave child tabs available to students.

Are there any plans to fix this? Thank you.

When moving modules between tabs I get the following error:

The callback get_shortcuts has been deprecated. Please use get_course_content_items and get_all_content_items instead. Some features of the activity chooser, such as favourites and recommendations are not supported when providing content items via the deprecated callback.

    line 302 of /course/classes/local/repository/content_item_readonly_repository.php: call to debugging()
    line 75 of /course/classes/local/repository/caching_content_item_readonly_repository.php: call to core_course\local\repository\content_item_readonly_repository->find_all_for_course()
    line 236 of /course/classes/local/service/content_item_service.php: call to core_course\local\repository\caching_content_item_readonly_repository->find_all_for_course()
    line 311 of /course/renderer.php: call to core_course\local\service\content_item_service->get_content_items_for_user_in_course()
    line 441 of /course/format/onetopic/renderer.php: call to core_course_renderer->course_section_add_cm_control()
    line 75 of /course/format/onetopic/format.php: call to format_onetopic_renderer->print_single_section_page()
    line 290 of /course/view.php: call to require()

Hello,

Coudn't leave a message to the news forum here (no posting allowed even when registered);

http://aprendeenlinea.udea.edu.co/lms/investigacion/mod/forum/view.php?id=964

So I ask here, what does settings "Use topic summary as template" do? The help text isn't helpfull and I don't understand it.

Hi,

When navigating among a course sections, the breadcrumb is updated to reflect the navigation - it displays the current section as last element.

If you go out of the course (by going to Moodle's main page for example) then click on a link pointing to the course (on main page or in dashboard for example), it (Moodle ? The course format ?) remembers the section you were in and takes you back to it.

But, the breadcrumb only shows the course as last element, and the section part is missing.

Navigating in the course (changing section or activity for ex.) restores the normal behaviour.

As it also affects the block_course_contents plugin, I guess the Navigation system is to blame rather than the breadcrumb rendering.

Thanks,
Mathias

https://github.com/davidherney/moodle-format_onetopic/blob/master/lib.php#L177

throws a bunch of errors like this because $course is empty:
PHP Notice: Trying to get property of non-object in course/format/onetopic/lib.php on line 171

Hello, I installed the plugin on Moodle 3.9.1+ (Build: 20200822). When I enter a new course with Onetopic format and I turn edition mode on, this is the error (wich prevents me doing anything):

Coding error detected, it must be fixed by a programmer: section_edit_controls() can not be used anymore. Please use section_edit_control_items() instead.

When using child tabs, I am unable to style the very first tab. Thank you.

To reproduce: Style some tabs and create some child levels. Change course format to another format. Change course format back to Onetopic. All styling and child levels are lost for me.
Thank you.

Hi David,

I don't know how to message you, so I hope it's OK to ask here.

I've started writing a course format, with parent and child tabs for pages, like One-Topic Format, but also allowing multiple sections embedded in each page. I thought it would make sense to use One-Topic format's section "level" option with 0 and 1 for parent and child tabs, and extend it with 2 for embedded sections? Is this OK?

Thanks,
James

After deleting a topic, an error appears "This section does not exist"
Using Moodle 3.2,

1. create a course with a onetopic format
2. Navigate to a topic
3. Turn on editing
4. Using the edit button select delete
5. Confirm deletion.

The result is a redirection to viewing the course with the section does not exist, to get around this error you need to logout and log back in.

Hello,

In my opionin Topic 0 should be displayed in tab edition utilities because when you move child tabs and click topic 1 they are moved as child tabs under topic 0 but in the tabs editions utilities they show up as a main level/normal topics because topic 0 isn't displayed here. This can be very confusing for a normal user.

Hello,

I would like to see an feature where you could add more depth to child levels like:

parent
child
child's child
child's child's child

Moodle version: Moodle 3.5.2+ (Build: 20180914)
PHP version : PHP 7.2.11
Onetopic version: san juan 2018010604

This warning appears when editing course above tabs:
Warning: count(): Parameter must be an array or an object that implements Countable in /var/www/moodle/course/format/onetopic/renderer.php on line 395

This is the 395 line:

      if (!$course->hidetabsbar && count($tabs[0]) > 0) {

            if ($PAGE->user_is_editing() && has_capability('moodle/course:update', $context)) {

                // Increase number of sections.
                $straddsection = get_string('increasesections', 'moodle');
                $url = new moodle_url('/course/changenumsections.php',
                    array('courseid' => $course->id,
                        'increase' => true,
                        'sesskey' => sesskey(),
                        'insertsection' => 0));
                $icon = $this->output->pix_icon('t/switch_plus', $straddsection);
                $tabs[] = new tabobject("tab_topic_add", $url, $icon, s($straddsection));

            }

It seem count($tabs) is not an array so the latest PHP 7.2 shows a warning there, please check the changes here:
http://php.net/manual/en/migration72.incompatible.php
http://php.net/manual/en/function.count.php#refsect1-function.count-changelog

Is there any way to fix this error?

Hello David and dear friends,

Please kindly ask me, in the following question:

1- Consider, that a particular course, has 10 weeks. In the One Topic plugin, there will be 10 items: Week 1, Week 2, Week 3, ..., Week 10.

2 - Currently in the version we use, when the student enters the Moodle, you will always see Week 1 open, even if the Course is in Week 2.

3 - Would it be possible to configure the Plugin One Topic so that as soon as week 2 starts, all students see Week 2 open automatically?

Thank you! Marcelo.

Hello,

at the moment Onetopic doesn't warn the user anyway if he/she is about to delete a course section from the minus-sign.

There should be a warning "are you sure? This will delete the whole section and activities" since it's easy to delete by mistake.

Hello,

I just noticed that Moodle 3.3 new feature stealth-activities doesn't work with onetopic. You can hide the activity but you don't have the option "make available" in the menu like with f.ex. topic activity.

https://docs.moodle.org/33/en/Stealth_activities

We have a problem with onetopic, when we import a section we get errors.
Moodle is version 3.8.4 and classic theme

• First line - "Fejl ved skrivning til database" is danish for "Error writing to Database"

Hi, debugging:

Warning: require_once(.... /course/format/topics/db/upgradelib.php): failed to open stream: No such file or directory in .... /course/format/onetopic/db/upgradelib.php on line 27

Fatal error: require_once(): Failed opening required '.... /course/format/topics/db/upgradelib.php' (include_path='.... lib/pear:.:/usr/share/php') in .... /course/format/onetopic/db/upgradelib.php on line 27

only thing i've done is comment out that line to get it to install on a dev environment, not sure if more needs doing so hopefully you can have a look sometime to check.

Cheers

when changing the color of the fonts (text) of the tabs, this is not applied, this was checked in the chrome / firefox browser in developer mode and indicates an error when trying to apply the style

When I have chosen for all tabs to have a specific background and text color (from the section settings), then it's not obvious which tab is the active one.

Steps to reproduce:

1. Go to a course in Moodle with the One Topic format.
2. Turn editing on and edit one section.
3. Choose #424a52 for background colour and #ffffff for text colour and save changes.
4. Repeat step 4 for all sections.
5. Once you save changes, click through each section tab.

Not obvious which tab is the active one.

Is this something which can be solved by applying CSS in the "CSS properties" field at the bottom of the section settings?

In order to set a top-level tab as, for example, "English", it appears that all of the child topics need to be set with "English" as the text of the first tab in the sublevel in order for it to show when child topics are hidden. Otherwise the text in the first child tab is pulled from the settings in the first visible child section. This issue is to correct the tab text inheritance so that it is always defaulted to the parent tab instead of the first visible same-level tab.

We are using Moodle 3.3.4 with a mySQL database and the OneTopic plugin version san juan (2018010602). However, after an the upgrade of Moodle from 3.1.5 to 3.3.4 some course are now displaying the error message, "Unknown course section in course "XXX"" if they are set to the OneTopic format. If we switch the format to Topics the course shows fine.

I am currently not aware of how the error is being produced, so I cannot list how to replicate it for testing.

Next, I checked and compared some database entries in the course_format_options table for both a course that is showing the error and one that is not.

It appears the courses showing the error have only records for the sectionid 0, and none of the other sections used in the course have records in the table. The courses not showing the error have records for all the sectionids in the course.

Is there any way to possible resolve the error?

We currently use Moodle 3.6 and can see that there is official confirmation through the Moodle plugin catalogue that this course format is compatible up to 3.6.

Please can the plugin be tested and the Moodle catalogue be updated to provide confirmation of support for 3.7 and 3.8?

We are a University and are trying to stick to a policy that we only use plugins that have, amongst other things, forward compatibility of Moodle versions ahead of our current production environment. We review plugins for removal where future compatibility may be problematic if the author has not confirmed compatibility.

On moodle 3.9 When clicking on the menubars link/tab the browser scrolls down to the content. On chrome we noticed it scrolls down too much and it hides the top menu bar. We don't have this issue on Firefox. Could this issue be fixed so that on chrome it would not hide the menu when it scrolls down to the content.

Screenshot of boost theme using chrome browser after clinking on topic 1

Screenshot of boost theme using firefox browser after clinking on topic 1

I think the issue is that the scroll doesn't adjust to the height of the navigation bar. Could this issue be fixed so that it takes on account the height of the navbar automatically or that you could specify the height of the navbar trough the formats general settings?

Moodle 3.0.1+ (Build: 20151231) turning on editing using onetopic version 2015051700 produces the following warning. onetopic is working as expected, but this warning is visible:

section_edit_controls() is deprecated, please use section_edit_control_items() instead.

line 278 of /course/format/renderer.php: call to debugging()
line 115 of /course/format/onetopic/renderer.php: call to format_section_renderer_base->section_edit_controls()
line 613 of /course/format/onetopic/renderer.php: call to format_onetopic_renderer->section_edit_controls()
line 574 of /course/format/onetopic/renderer.php: call to format_onetopic_renderer->section_right_content()
line 446 of /course/format/onetopic/renderer.php: call to format_onetopic_renderer->section_header()
line 89 of /course/format/onetopic/format.php: call to format_onetopic_renderer->print_single_section_page()
line 280 of /course/view.php: call to require()

thank you for supporting this wonderful product!!

Hi
Springwood High School use OneTopicFormat and in Moodle 2.8 it has worked perfectly. They upgraded to Moodle 2.9 and the content within the whole course has moved and now appears as one list of content under one topic/section. Originally, the content was spread across 19 sections. I have attached an image which I hope helps. Please let me know if you need more information. All content is now in the Dance section.

Thanks

Jeremy

Cuando el usuario está en la última pestaña y la elimina se produce el error: "Error code: sectionnotexist"