Comments (3)
Weird, I thought I had compiled the unittest before I submitted the last SVN
revision, but maybe not. It does look like I did an incomplete job of adding
StrHash
as the hash function template-parameter everywhere I was hashing a string.
I believe the fix is to just change
sparse_hash_map<string, XXX>
to
sparse_hash_map<string, XXX, StrHash>
and likewise with dense_hash_map. We also need to change
sparse_hash_map<char*, XXX>
if any of those occur.
I'll take care of it after I'm back from vacation. If you'd like to do the
patch
earlier than that, feel free, and can attach it here!
Original comment by [email protected]
on 25 Dec 2009 at 7:17
- Changed state: Accepted
- Added labels: Priority-Medium, Type-Defect
from sparsehash.
I've got a fix that works for me, that I'm having reviewed right now. Once
it's been
ok'ed, I'll let you know. May be next year, though!
Original comment by [email protected]
on 31 Dec 2009 at 2:00
- Changed state: Started
from sparsehash.
This should be resolved in sparsehash 1.6, just released.
Original comment by [email protected]
on 11 Jan 2010 at 10:53
- Changed state: Fixed
from sparsehash.
Related Issues (20)
- Memory Corruption HOT 2
- Compile fails on up-to-date Fedora 18 system HOT 2
- Insert deleted key into hashmap will cause size() be increased
- Cannot compile sparsehash-2.0.2 on Ubuntu 12.04LTS
- [PATCH] Fix gcc warning: format '%p' expects argument of type 'void*'
- news page specifies wrong date
- clang compile failure on FreeBSD HOT 3
- failure during "make" of sparsehash on mac osx 10.8.5 HOT 1
- Please implement a check for try in case libstdc++ implements c++11 where tr1 is merged into std HOT 4
- Latest version of xcode Command Line tools breaks sparsehash. HOT 6
- Fix the compile problem's on llvm(macosx) HOT 1
- Call resize to preallocate for memory does not work
- SPARSEHASH_COMPILE_ASSERT HOT 2
- Repair compilation with clang
- Installation fails check on Red Hat 6
- Installation fails at "make" step on Red Hat Linux 6
- make check fails with GCC 4.9 on Mac OS 10.10.1
- [PATCH] Make dense_hash_map work with non-default-constructible values HOT 1
- Is it thread safe for insertion of sparse hash table? HOT 1
- Google Code is dying
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sparsehash.