Giter Club home page Giter Club logo

Comments (6)

GoogleCodeExporter avatar GoogleCodeExporter commented on July 21, 2024
I tried "make check" on sparsehash on a Mac with the latest xcode. It didn't 
work. The attached patch was able to fix 3 warnings and, more seriously, a type 
incompatibility.

I'm not ready to commit the patch yet (though I suspect it would be fine), and 
it may take me a week or two to get to it. But, the patch is here if you want 
to try it.

Original comment by [email protected] on 26 Mar 2014 at 12:17

  • Changed state: Started

Attachments:

from sparsehash.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 21, 2024
I now see that the patch mentioned in issue 100 is pretty much the same thing. 
Thanks Meno!

Original comment by [email protected] on 26 Mar 2014 at 12:21

from sparsehash.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 21, 2024
Issue 100 has been merged into this issue.

Original comment by [email protected] on 26 Mar 2014 at 12:21

from sparsehash.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 21, 2024
Is the fix going to be merged to master?

Original comment by [email protected] on 16 Apr 2014 at 4:15

from sparsehash.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 21, 2024
Correct me if I'm wrong, but I suspect the root cause was that 
sparse_hashtable_iterator::st_iterator, 
sparse_hashtable_const_iterator::st_iterator, and 
sparse_hashtable_destructive_iterator::st_iterator were not typedef-ef 
correctly. So I propose the following patch for the type incompatibility issue 
instead.

Original comment by [email protected] on 19 Apr 2014 at 10:22

Attachments:

from sparsehash.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 21, 2024
there are a number of warning in the unit tests after applying the patch, but 
otherwise is excellent

Original comment by cristeab on 17 May 2014 at 6:33

from sparsehash.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.