Giter Club home page Giter Club logo

Comments (4)

ssilnicki-dev avatar ssilnicki-dev commented on August 17, 2024

this fix works for me:

expression_ptr text_input_buffer::parse_expression(bool stopAtParen)
{
	next_token();
	unsigned long long leftVal;
	expression_ptr lhs;
	source_location l = location();
	switch (*(*this))
	{
		case '\'':
			consume('\'');
			if(!consume_char_literal(leftVal))
			{
				return nullptr;
			}
			lhs.reset(new terminal_expr(l, leftVal));
			skip_to('\'');
			if (!consume('\''))
			{
				return nullptr;
			}
			break;
		case '0'...'9':
			if (!consume_integer(leftVal))
			{
				return nullptr;
			}
			lhs.reset(new terminal_expr(l, leftVal));
			break;

is it a reasonable approach?

from dtc.

davidchisnall avatar davidchisnall commented on August 17, 2024

Looks good to me.

from dtc.

ssilnicki-dev avatar ssilnicki-dev commented on August 17, 2024

may I issue a PR?

from dtc.

jlduran avatar jlduran commented on August 17, 2024

may I issue a PR?

Yes please.

from dtc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.