Comments (9)
Sorry, I meant to mention but was in a crunch for time- I'll look at fixing and submitting a pull request, rather than just leaving this vague issue. =)
from dtc.
Ah, interesting. The fixups spec is practically nonexistent, and I was going by descriptions from slides when I wrote this. It shouldn't be too hard to construct nodes in a hierarchy like this. If you could send a pull request with a test (input file and expected output), that would help a lot.
from dtc.
Yeah, I noticed there was no spec for this. =( Anywho- I've added the test cases, split up amongst three to capture some of the more complex situations separately so it's easier to spot where things have gone wrong. I've no idea if I'll personally have the time to try implementing this; I noticed yesterday when I started looking at where to start that my C++ skills aren't what they used to be. =)
from dtc.
Thanks, that should help.
from dtc.
Should be fixed now. I've tweaked the expected values from the tests because the order of FOO
and BAR
in the __fixups__
section is different. I also modified one of your expected values because it said quz
instead of qux
and source didn't include the string quz
, so I don't know where that came from.
@emaste This version probably wants importing to FreeBSD at some point.
from dtc.
I'll test this and likely import to FreeBSD within the next couple of days, if neither of you have any objections to that timeline.
from dtc.
@kevans91 I'm fine with you handling the import in the next couple of days.
Note that we don't have this as vendor code in FreeBSD, it's just a straight copy and we generally do not have changes in the FreeBSD tree that are not here. That said, I see that pfg committed SPDX changes, have they made it here?
from dtc.
No, I don't think so, and trying to merge from my git-svn branch is giving some merge conflicts because other people have done the dcommits and it's confused about history.
from dtc.
I've submitted Pull Request #29 for SPDX additions
from dtc.
Related Issues (20)
- dtc crashes when there is a reference to a non-unique label
- Handle /delete-node/
- Nodes can have multiple labels HOT 1
- References to node@address are incorrectly handled HOT 1
- Missing /delete-property/
- /delete-node/ should work with node@address HOT 1
- dtc fails on rpi.dts in FreeBSD arm.GENERIC HOT 2
- overlay support required HOT 7
- FreeBSD head -r320133 got: /usr/src/usr.bin/dtc/input_buffer.cc:658:2: error: 'result' does not name a type HOT 4
- Node not correctly referenced when '@' is in one name HOT 1
- DTB not convertable by GPL dtc HOT 8
- No incbin support HOT 6
- incbin doesn't seems to work with u-boot-pine64 HOT 3
- Segfault with -s option
- Coverity reports an illegal access HOT 1
- dtb.cc needs to include stdlib.h HOT 1
- Handle top level /delete-node/ directives HOT 4
- error: 'auto' not allowed in lambda parameter HOT 4
- STM32MP1xxxx DTS fail to compile HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dtc.