dtc(1) writes invalid /__local_fixups__ node about dtc HOT 9 CLOSED

Sorry, I meant to mention but was in a crunch for time- I'll look at fixing and submitting a pull request, rather than just leaving this vague issue. =)

from dtc.

Ah, interesting. The fixups spec is practically nonexistent, and I was going by descriptions from slides when I wrote this. It shouldn't be too hard to construct nodes in a hierarchy like this. If you could send a pull request with a test (input file and expected output), that would help a lot.

from dtc.

Yeah, I noticed there was no spec for this. =( Anywho- I've added the test cases, split up amongst three to capture some of the more complex situations separately so it's easier to spot where things have gone wrong. I've no idea if I'll personally have the time to try implementing this; I noticed yesterday when I started looking at where to start that my C++ skills aren't what they used to be. =)

from dtc.

Thanks, that should help.

from dtc.

Should be fixed now. I've tweaked the expected values from the tests because the order of FOO and BAR in the __fixups__ section is different. I also modified one of your expected values because it said quz instead of qux and source didn't include the string quz, so I don't know where that came from.

@emaste This version probably wants importing to FreeBSD at some point.

from dtc.

I'll test this and likely import to FreeBSD within the next couple of days, if neither of you have any objections to that timeline.

from dtc.

@kevans91 I'm fine with you handling the import in the next couple of days.

Note that we don't have this as vendor code in FreeBSD, it's just a straight copy and we generally do not have changes in the FreeBSD tree that are not here. That said, I see that pfg committed SPDX changes, have they made it here?

from dtc.

No, I don't think so, and trying to merge from my git-svn branch is giving some merge conflicts because other people have done the dcommits and it's confused about history.

from dtc.

I've submitted Pull Request #29 for SPDX additions

from dtc.