davemane42 / comfyui_dave_customnode Goto Github PK

I don't know if I am missing the link but is there a sample working workflow that come with it as a demo?

Hello :)
since i don't need to upscale by 2 or 3, but doing latent upscale by adding 256 to H and W i was trying to use ConditioningStretch (CS).

am i correct with MultiAreaConditioning (MAC) when connecting conditioning/resolutionX/resolutionY to CS and after from CS to positive in KSampler?

question rose when i've tried generating without CS (connecting MAC and KSampler directly) result was more coherent. Maybe denoise or sampler/scheduler affected - dunno.

I tried to compose LORS with no luck.
Would you update in future?
Thank you so much for this great tool! I love it!

Is it possible to include __init__.py in this repo so installing can be done via a git clone? Currently, if this repo is cloned into the custom_nodes folder, it returns:

Cannot import C:\AI\ComfyUI\custom_nodes\ComfyUI_Dave_CustomNode module for custom nodes: [Errno 2] No such file or directory: 'C:\\AI\\ComfyUI\\custom_nodes\\ComfyUI_Dave_CustomNode\\__init__.py'

For reference:
https://github.com/WASasquatch/was-node-suite-comfyui
https://github.com/hnmr293/ComfyUI-nodes-hnmr

Neither multi composite nor multiconditioning work. The moment I try to change the index count it crashes ComfyUI. I have to refresh the browser & then clear the workspace to get ComfyUI to be responsive in a sensible way.

I am new to this tool so I do not know how it is supposed to work. I am following the SVGs you have here.

I'm using Windows 11, RTX 3060, most recent version of ComfyUI

MultiAreaConditioning is very useful in keeping the workflow tidy, however MultiAreaConditioning won't work in API requests as it uses workflow data.

Some way to be able to use prompts that use this node would be appreciated.
I've come across the same problem, and I've used a workaround using a disabled widget that aggregates all the input data. Not sure if this is the best way to solve the problem, but lacking any additional insights, this is the only hint I can provide.

Kind Regards.

Currently, it seems that it does not work when installing from git using clone. The 2.4 version files of Civitai work properly.
Also, it would be helpful if resolutionX and resolutionY could be turned into widgets like the default nodes.

I tried your custom multi-region node in a current version of comfyUI, but my outputs are only noise. When I mute the node and and use one of the inputs directly it works all fine.

Do you know any reason for this?

git clone git clone https://github.com/Davemane42/ComfyUI_Dave_CustomNode

You put git clone in there twice. it made me go -.-

When I adjust the number of 'index' to be greater than the number of 'condition' interfaces, the Comfy UI window will be frozen and I cannot click on any node until I refresh the webpage.

Reproduction steps:

1. Open the Comfy UI interface.
2. Add a MultiAreaConditon Node.
3. Adjust the value of 'index' to be greater than the number of input interfaces in the 'condition' node.

The same issue also occurs with the MultiLetentComposite node.

To reproduce:

1. Start a empty workflow
2. Just add a MultiAreaConditioning
3. Add more conditionings
4. Click a lot and keep switching to different index, i.e. 0 to 5 and repeat 5 to 0
5. The UI starts to freeze, the bottom panel become empty, cannot drag UI.
6. Try to add a new node, but the new node added will only appear after window resizing, and still cannot be selectable.
7. Save still work, but workflow may still freeze after reload the save.

Hi!

From README, I see there're 4 conditioning inputs.
However, after the installation, I could only find 2 conditioning inputs.

How can I add more conditioning inputs?

Thanks :)

hello :)

comfyui @27fc64ad469c07d8f84b2c2791a593f1cf2c7b59

after switching to update got this error.

python main.py --listen                    
A matching Triton is not available, some optimizations will not be enabled.                                             
Error caught was: No module named 'triton'                                                                              
Set vram state to: NORMAL VRAM 
Using xformers cross attention 
Skip /tmp/ComfyUI/custom_nodes/MultiAreaConditioning.py module for custom nodes due to the lack of NODE_CLASS_MAPPINGS.
Skip /tmp/ComfyUI/custom_nodes/MultiLatentComposite.py module for custom nodes due to the lack of NODE_CLASS_MAPPINGS.

I have been trying to merge the MultiAreaConditioning with the Derfuu nodes. It would be magical if it was possible to simplify the Derfuu workflow by adding the MultiAreaConditioning node.

When I wire up a conditioning node to the MultiAreaConditioning node, the square representing the area is the default size and location, so I guess it isn't implemented yet. If there is anything I can do to help, I wouldn't mind learning the ins and outs of custom nodes, but just by looking at the code, I am at a loss.

In the provided sample image, the Empty Latent Image node features endpoints that somehow connect width and height from the MultiAreaConditioning node. But when creating a regular Empty Latent Image node, these values cannot be connected to other nodes and need to be manually typed.

Is this another type of node, or how do we connect width and height from the MultiAreaConditioning node?

Not working, only 2 links on this node, one input, one output.

I am new to ComfyUI, so I may be doing this wrong. I have downloaded the portable windows build of ComfyUI and I have used mklink to point the models to the correct folders, so I have all my checkpoints/loras/embeddings/etc. I extracted and placed the custom node files(Both *.py and *.js) into the "custom_nodes" folder. The menu item shows up in Comfy UI under Add Node > Davemane42 > MultiAreaConditioning, however I only get 2 links. 1 input, named "conditioning0" and 1 output "CONDITIONING". When I right click input and output options are greyed out and properties does nothing.

Im guessing I need to place the files in a different location? I downloaded the v2.0 files from civitai.com, but I downloaded the v2.1 update from github when it wasnt working. no change with current configuration.

In Colab instead of creating a folder "Daveman42" in web\extensions, it makes folder "web\extensions\Davemane42" in ComfyUI folder