dataoneorg / d1_common_java Goto Github PK

Hi all, there appears to be some inaccuracies in the javadoc for the getConfiguration method of Settings.

From the javadoc:

     * System properties are always loaded first, followed by those
     * properties in an optional file (specified with the system
     * property "opt.overriding.properties.filename"), followed by
     * context-specific default properties files.

From what I can tell from testing and checking the code:

• System properties are not loaded at all
• opt.overriding.properties.filename is not used

opt.overriding.properties.filename is mentioned in a SettingsTest test, but that test isn't run (the @Test annotation is commented out).

Just some notes for our future selves, when we update from java 8:

This breaks with Java > 11 (found when working on d1_portal, which has this as a dependency)

org/dataone/service/util/TypeMarshaller.java:299

javax.xml.bind.JAXBException

• with linked exception:
  [java.lang.ClassNotFoundException: com.sun.xml.internal.bind.v2.ContextFactory]

/Users/brooke/.m2/repository/javax/xml/bind/jaxb-api/2.2.3/jaxb-api-2.2.3.jar!/javax/xml/bind/ContextFinder.class

return newInstance(classes, properties, "com.sun.xml.internal.bind.v2.ContextFactory");

com.sun.xml.internal.bind.v2.ContextFactory no longer available after JDK 11