datanucleus.query.jdoql.{varName}.join extension does not work when "varName" is not lower case about datanucleus-rdbms HOT 4 CLOSED

Handled in #461

from datanucleus-rdbms.

Yes, all query extensions are stored internally in lowercase (and should automatically be available in QueryToSQLMapper in lowercase, so no need to convert) ... and this is because they have to be stored in one case and are intended to be case insensitive, hence store in lower and check against lower.

If that specific extension is the problem then you should look at
https://github.com/datanucleus/datanucleus-rdbms/blob/master/src/main/java/org/datanucleus/store/rdbms/query/QueryToSQLMapper.java#L5157
and simply look at putting the "alias" in lowercase before the lookup.

from datanucleus-rdbms.

Thanks for the feedback. I am reporting this because prior to DN 6, the casing for variables used in JDOQL query expression did not matter.
The problem is not that the extension should be defined lowercase.
The problem is that when defining variables in query expressions, we are forced to have them in lowercase or join extensions will not work correctly anymore.

The join extension is NOT picked up in the following cases:

• The variable provided in the query is in camelCase and the extension that references it in camelCase
• The variable provided in the query is in camelCase and the extension that references it in lowercase

Here test-jdo.zip is a small example showing the unexpected behavior.

It seems that in QueryToSQLMapper the alias is actually picked up from the query variable name in the query expression.

In the provided test the path seems to be:
https://github.com/datanucleus/datanucleus-rdbms/blob/master/src/main/java/org/datanucleus/store/rdbms/query/QueryToSQLMapper.java#L2846 <-- This is where the Alias is picked up from the query expression

And at this point the extension is generated using the fully cased alias, which cannot be found in the extensionsByName map.

Thanks a lot for checking this out and sorry if my initial issue description was not clear enough.

from datanucleus-rdbms.

I updated the pull request with the correct fix, that makes the tests in my POC pass correctly and is less invasive than the previous one

from datanucleus-rdbms.